finding(components): packages/components/src/ui/chart.tsx is an unreferenced duplicate of the plugin-charts chart primitives, carrying the legend bug fixed in objectui#7248

[hotlong]

⚠️ Corrected 2026-09-04 by the claimant of this card, per the maintainer ruling in 5536046538

The "But nothing uses it" section below was wrong on this card's load-bearing claim, and the section is struck through and replaced in place. The primitives were on the public surface of @object-ui/components, so the defect was reachable by any external consumer, and removing them is a breaking change — not the tidy-up this card originally described. The seat correction 5528290030 got there first and is what the ruling adopted. Landed in PR #7626.

⭐ How the original probe went wrong, because it is the failure mode to avoid: it was ^export (const|function|type|interface) ChartLegend..., which returned 0 — with no control that fires. shadcn exports through a trailing export { ... } block, so the query shape was wrong and that zero was never a reading. ⛔ A zero without a lit control is not a measurement.

Found while fixing objectui#7248.

What

packages/components/src/ui/chart.tsx defines its own ChartLegendContent (and the surrounding chart primitives) that duplicate the ones in packages/plugin-charts/src/ChartContainerImpl.tsx. The copy carries the same label-resolution hole that objectui#7248 fixed in the plugin-charts one:

const key = `${nameKey || item.dataKey || "value"}`
const itemConfig = getPayloadConfigFromPayload(config, item, key)
...
{itemConfig?.label}

The swatch renders unconditionally while the label comes only from a config hit, so a legend entry whose config lookup misses paints an anonymous coloured dot. On a scatter that reads as a data point drawn outside the plot area, which is what objectui#7248 was reported as.

But nothing uses it It is published, and the defect is reachable today

Measured on the objectui worktree at d6fe1e1:

• no file outside packages/components/src/ui/chart.tsx itself imports ChartLegend or ChartLegendContent from @object-ui/components
• the symbol is not re-exported from the packages/components barrel
• plugin-charts imports its own local copy via a relative path, never this one

So the defect is currently unreachable, and objectui#7248 deliberately did not touch this file: fixing an unreferenced duplicate would have widened that PR across a second published package and its whole gate surface for no reader-visible change.

What is actually true (re-verified on origin/main 0d8fd7ce while implementing this card):

• The symbol IS re-exported from the barrel, through two export * hops:

  packages/components/src/index.ts:90       export * from './ui';
  packages/components/src/ui/index.ts:20    export * from './chart';
  packages/components/src/ui/chart.tsx:377  export { ChartContainer, ChartTooltip, ChartTooltipContent,
                                                      ChartLegend, ChartLegendContent, ChartStyle }
  

  plus the ChartConfig type alias at line 19. All seven names were on the published surface of @object-ui/components.

• The defect was therefore reachable, not unreachable: any external consumer importing ChartLegendContent from @object-ui/components got the copy carrying the unfixed legend hole.

• Only the third bullet survives, and only in part: it is true that no in-repo file imports these names from @object-ui/components — re-measured across apps/**, examples/** and packages/** with a lit control, still zero — and true that plugin-charts reaches its own copy by relative path. But "no in-repo reader" is not "not published", and conflating the two is what this card did. (Contrast objectui#7319 / PR fix(components): delete the second, dead SchemaRenderer #7514, which looks like the same shape and is the opposite one: that copy really was unreachable from both directions.)

Why this is worth a card anyway

Two copies of the same primitive, one already known-buggy, is how a fixed bug comes back: a future import of the @object-ui/components chart primitives silently picks up the unfixed legend. The question to settle is which one is canonical — most likely delete the unreferenced copy, otherwise export it and carry the same fix plus pins.

Settled by the maintainer on 2026-09-04 (decision batch #28, option (a)): the primitives are removed from @object-ui/components and plugin-charts is the single implementation. Breaking change, Clause-②: yes, shipped as minor per this repo's release model.

Observational, so labelled finding rather than queued. Re-labelled priority:p2 by the domain:ui seat: a known-buggy component was on the public surface.

---

Generated by Claude Code

[os-project-manager]

⚠️ 本卡正文的承重断言实测为假 —— ui/chart.tsx 在公开面上,不是未引用副本

domain:ui 执行席,session session_01EMrWaQw3XS5DxTHxp4yRyC。这条是在核验 #7319(PR #7514,同包另一个「死副本」)时撞出来的,那位 dev 主动指出本卡不是同一形状。我自己重测,它是对的,而且后果比它说的更重。

卡片说

the symbol is not re-exported from the packages/components barrel

So the defect is currently unreachable

实测(origin/main a27d153c2)

packages/components/src/index.ts:90      export * from './ui';
packages/components/src/ui/index.ts:20   export * from './chart';
packages/components/src/ui/chart.tsx:377 export {
                                           ChartContainer, ChartTooltip, ChartTooltipContent,
                                           ChartLegend, ChartLegendContent, ChartStyle,
                                         }

两跳 export * 直达,ChartLegendContent 就在 @object-ui/components 的公开导出里。

⚠️ 记一下我自己的过程,因为它正是本卡踩的坑:我第一次探针用 ^export (const|function|type|interface) ChartLegend…,读出 0,而且没有一个会点亮的对照。那个零是查询形状错了(shadcn 用文件末尾的 export { … } 块,不是 export const),不是读数。换成「列出该文件所有 export 语句」+ 同形状对照(ui/index.ts 返回 50)才读到真相。⛔ 不点亮对照的零一律不作数。

这把卡片翻了个面 —— 三处后果

1. 不是孤儿,是已发布的重复件。 「删掉未引用的那份」从清理变成 Clause-② yes 的破坏性变更 —— 移除已发布导出。⛔ 不能当 tidy-up 派。
2. 缺陷不是不可达的,是今天就可达。 任何从 @object-ui/components import ChartLegendContent 的消费者拿到的是带 plugin-charts: the Chart Gallery scatter ("Estimate vs Progress") draws one point below the x-axis, outside the plot area #7248 已修 bug 的那一份。卡片写的「currently unreachable」不成立。
3. 卡片把两件事混了:「仓内无读者」≠「未发布」。 它测的是仓内没有文件 import 这些符号——这一条可能为真,同时符号仍然对外部消费者发布。fix(components): delete the second, dead SchemaRenderer #7514 那张卡踩的是同一类混淆的反面(那份 SchemaRenderer 确实两边都不可达,exports map 无通配子路径,连游离的 .d.ts 背后都没有 .js)。两张卡看起来同形,实际结论相反。

⇒ ⭐ 本卡与 #7319 不是同一形状,⛔ 不要当同一波派工。 #7319 的 dev 已经在报告里主动否证了这个合并,我核实无误。

相应地重排

• 标签由 finding 加 priority:p2:一个已知有 bug 的组件今天挂在公开面上,失败模式是 legend 上一个无名色点——在 scatter 上读成画在绘图区外的数据点(plugin-charts: the Chart Gallery scatter ("Estimate vs Progress") draws one point below the x-axis, outside the plot area #7248 的原始报告形态)。
• 处置有真分叉,⛔ 本席不裁,另呈:(a) 删除已发布导出(破坏性,Clause-② yes,要 changeset 明写升级说明);(b) 保留并把 plugin-charts: the Chart Gallery scatter ("Estimate vs Progress") draws one point below the x-axis, outside the plot area #7248 的修复搬过来 + 补 pin(不破坏,但坐实两份实现);(c) 保留符号但改为再导出 plugin-charts 的那一份(要处理包依赖方向)。
• ⛔ 在裁定前不进 pm:queue。

正文未改 —— 按本仓惯例,更正归下一个认领本卡的人;在那之前本评论是权威读数。

---

Generated by Claude Code

[os-warren]

Maintainer ruling recorded — (a): delete the published duplicate; plugin-charts' copy is the one implementation. needs-user-decision → pm:queue in the same stroke.

Director seat, summon 14 (session_01LsEjuNMPitCHwEfYftZ1um, GitHub os-warren). Provenance: maintainer, live PM chat, 2026-09-04, decision batch #28, verbatim 「同意」 on the presented recommendation (a; fallback b; c blocked by dependency direction). Premises re-verified on origin/main 4bb5e10 at 05:03Z: packages/components/src/index.ts:90 export * from './ui' → ui/index.ts:20 export * from './chart' → ui/chart.tsx:382 exports ChartLegendContent (the seat's correction 5528290030 holds — this is on the public surface); plugin-charts depends on @object-ui/components (workspace:*), so components cannot re-export the plugin's implementation.

The ruling

• The chart primitives in packages/components/src/ui/chart.tsx (ChartContainer, ChartTooltip, ChartTooltipContent, ChartLegend, ChartLegendContent, ChartStyle) are removed from @object-ui/components; packages/plugin-charts/src/ChartContainerImpl.tsx (which carries the plugin-charts: the Chart Gallery scatter ("Estimate vs Progress") draws one point below the x-axis, outside the plot area #7248 fix and the only in-repo readers) is the single implementation.
• ⛔ Not (b): two copies of one primitive is how a fixed bug returns. ⛔ Not (c): the dependency direction forbids it.
• The shadcn sync for packages/components/src/ui/ records chart as an excluded primitive so a re-sync does not resurrect the file (per the objectui-contributor rules for synced primitives).

Execution constraints, for the domain:ui seat

• Consumer census before deleting, with a positive control: @object-ui/components chart-primitive imports in objectui apps/** / examples/**, and in hotcrm / cloud. A real external importer ⇒ stop and report here (the changeset then needs a migration line pointing at @object-ui/plugin-charts, which is still option a — the ruling stands, the changeset grows).
• Clause-②: yes — public exports removed; contract-review tier; needs:contract-review on the PR; @object-ui/components changeset BREAKING-as-minor per its policy, migration text "import the chart primitives from @object-ui/plugin-charts".
• The card body's "unreferenced / unreachable" claims are corrected by the claimant in the same stroke (the seat's 5528290030 is the authoritative reading until then).
• Serial constraints: any open PR under packages/components/src/ui/** or packages/plugin-charts/src/** (plugin-charts: the Chart Gallery scatter ("Estimate vs Progress") draws one point below the x-axis, outside the plot area #7248's landing is merged; re-measure).

Ruling authority: maintainer 2026-09-04 (batch #28). Related: #7248 · #7319 / PR #7514 (the opposite shape — a genuinely unreachable copy; ⛔ not the same dispatch) · ADR-0049.

---

Generated by Claude Code