Skip to content

[finding] After the jsonc retag (PR #7473), 11 JSON fences in skills/objectui/ still parse under no dialect (8 multi-document listings, 2 ... elisions, 1 kept json) and 7 now-parseable jsonc fences carry no os:check marker #7474

Description

@os-litant

Filed by the skills lane seat (session session_01LraLgQVGq8egUwfYZpbYt1) from the #7462 flight's report (PR #7473, comment 5522566624, out-of-scope items 1–3). One coherent content-edit follow-up on the same three files; the tag flight was tag-only by design. Unassigned, bare, for triage; landing surface governed skills/objectui/** (draft PR, human merge).

Measured by the flight at ec67429 with the repository's own parseJsonFence (scripts/check-skill-examples.mjs)

After the retag, 39 of the 40 remaining json fences parse strictly and 7 of the 16 jsonc fences parse under the JSONC dialect — 46 of 56. The residue:

shape sites (fence opener line) count
several top-level JSON documents listed in one fence guides/schema-expressions.md 32, 170, 206, 447, 463, 479, 492; rules/protocol.md 177 8
... elision inside the JSON rules/protocol.md 157, 166 2
total parsing under no dialect 10 (+ line 206 counted above stays json: a listing, not a dialect — 11 blocks by the card's parse-failure count)

And the coverage win left on the table: 7 retagged jsonc fences now parse and could carry the check-skill-examples opt-in marker (guides/schema-expressions.md 328, 355, 365, 374, 391; rules/protocol.md 187; rules/styling.md 170) — moving the enforced JSON population from 39 to 46. The flight proved the tag is load-bearing both ways (marker + jsonc → exit 0; marker + json → exit 1 naming rules/styling.md:171).

Scope

  1. Split each multi-document listing into one fence per document (or one array where the prose reads as a set), keeping the prose between them minimal; retag the split fences by their content (json if strict, jsonc if a comment stays).
  2. Replace the two ... elisions with a real value or a comment (// … is legal under jsonc; ... is not under any dialect).
  3. Add the os:check marker line above the 7 parseable jsonc fences (and above any fence made parseable by steps 1–2), then run node scripts/check-skill-examples.mjs — the JSON phase must report the new count with 0 failed.
  4. Report the fence census before/after (json / jsonc counts, parse-pass counts, marked counts) and the per-file byte/line arithmetic; there is no token ratchet over skills/** in objectui (measured by the flight), so the numbers are reported, not gated.

⛔ Not in scope: widening check-doc-fence-languages.mjs onto skills/ — measured and declined in PR #7473 (it reds on guides/project-setup.md:115, a genuine javascript postcss config, in the one UNKNOWN mode it never baselines, and its scan surface is pinned to check-doc-snippet-types's); pointing any doc gate at skills/ is the surface owner's decision per the UNGATED_DOCS note in check-doc-snippet-types.mjs.

Verified

Refs: #7462 · PR #7473 (comment 5522566624) · #7359 / PR #7427 (the fence gate and its marker convention).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions