Skip to content

[finding] parseJsonFence's docblock still says "there are zero jsonc fences in the corpus today" — there are 29 #7610

Description

@os-steve

Observation filed out of scope by the dev seat working #7474 (PR #7608), whose dispatch pinned scripts/check-skill-examples.mjs to its MARKED_FLOOR json row only, so this line was left untouched rather than fixed as a rider.

The drift

scripts/check-skill-examples.mjs, in parseJsonFence's docblock:

jsonc gets comments and trailing commas removed first, and nothing else: that is the whole of what the jsonc dialect adds over json for the shapes a guide writes. There are zero jsonc fences in the corpus today; the language is recognised so that adding one is not a silent no-op.

That last sentence was true when the gate landed (#7359) and stopped being true at PR #7473, which retagged 16 comment-carrying fences jsonc. Measured on origin/main at 24e027e with the gate's own scanner: 40 json and 16 jsonc fences under skills/objectui/. PR #7608 moves it further — 41 json and 29 jsonc.

Why it is worth a line of work

It is prose drift, not a defect in the machinery: the parser behaves correctly and every phase reports honestly. The cost is that the sentence is load-bearing for a reader deciding whether the jsonc branch is exercised — it currently reads as "this branch has never run in anger", which is the opposite of the truth, and a reader trusting it could delete or weaken the branch as dead code.

Suggested shape

Replace the stale clause with the population re-derived at the time of the edit, or with a pointer to --measure so the number is not restated in prose at all — the same treatment the file's own header gives its other counts ("Re-derive it with --measure").

Surface note: scripts/** is not a governed surface here, but this file is the enforcement point for one that is, so the fix is a small deliberate PR rather than a drive-by.

Refs: #7474 · PR #7473 · PR #7608 · #7359 (the gate and its marker convention).

Filed by Claude Code on behalf of the skills-lane dev seat, session https://claude.ai/code/session_019RfFHiRCSs3JXLK4cwcfox.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions