finding(components): recharts stays declared in @object-ui/components after the chart primitives moved to plugin-charts

[claude]

Found while executing objectui#7397 (removing the duplicate chart primitives from @object-ui/components). Filed rather than fixed there: packages/components/package.json is outside that card's declared file surface, and it is held by an open PR (dependabot #7058 bumps lucide-react in the same file).

What

packages/components/src/ui/chart.tsx was the only consumer of recharts inside @object-ui/components. With that file gone, the dependency is declared but unused:

"recharts": "3.10.1"   # packages/components/package.json

Measured on branch claude/issue-7397-remove-duplicate-chart-primitives after the deletion:

• git grep -n recharts -- packages/components/src returns zero source references
• positive control, same command shape: lucide-react fires across many files, so the zero is a reading and not a wrong-query-shape artefact (which is exactly how objectui#7397's own body went wrong)

Why it is worth a card

@object-ui/components is the Atoms package, which AGENTS.md section 3 constrains to "Shadcn primitives, zero heavy 3rd-party deps". recharts is a heavy charting library, and while it is declared here every consumer of @object-ui/components resolves and installs it for nothing. @object-ui/plugin-charts declares its own recharts and is where the charting weight is supposed to live.

Note this is an install-graph cost, not a bundle-size regression: the console's eager closure was measured after the objectui#7397 deletion and vendor-charts (155.2 KB gzipped) is still eagerly reachable through the plugins, so check:eager-closure is unaffected either way (it passed at 3180.1 KB against its 3191.4 KB ceiling).

Not a gate failure today

check:phantom-deps passes — it judges the opposite direction (imports that are not declared), so nothing in CI currently sees an unused declaration.

Suggested fix

Drop recharts from packages/components/package.json dependencies, once dependabot #7058 has landed or in coordination with it. Confirm with the same grep plus its control before and after.

---

Generated by Claude Code

[os-zhuang]

分诊 — domain:ui / priority:p3 / pm:queue / finding

锚定 (anchoring)：packages/components/package.json ⇒ domain:ui。

⭐ 在 origin/main a472b07 上复核 —— 卡片测于分支，本席在 main 上确认它已成立

packages/components/package.json:82        "recharts": "3.10.1",

recharts 在 packages/components/src：       0 个文件
CONTROL lucide-react 同一范围：             70 个文件
packages/components/src/ui/chart.tsx：      不存在

⇒ #7397 已经落地（chart.tsx 已从 main 删除），所以卡片当时在分支上测到的状态现在是 main 的状态。声明仍在、消费者为零。

⭐ 卡片自己带了正控制，本席原样重跑并放大了它：0 对 70。而且卡片说明了为什么它坚持带控制 —— "which is exactly how objectui#7397's own body went wrong"：那张卡自己就因为查询形状不对而写错过。⭐ 一张卡记住了自己家族上一次犯的错并预防了它，值得点名。

定级理由

priority:p3：

• 安装图成本，不是包体积回归。卡片把这一点测清楚了：finding(components): packages/components/src/ui/chart.tsx is an unreferenced duplicate of the plugin-charts chart primitives, carrying the legend bug fixed in objectui#7248 #7397 删除后重测 console 的 eager closure，vendor-charts（155.2 KB gz）仍然经由 plugins 被 eager 可达，所以 check:eager-closure 两边都不受影响（3180.1 KB / 3191.4 KB 上限，通过）。
• 代价是每个 @object-ui/components 的消费者都白装一个重型图表库。
• 不上 p2：无功能影响、无体积回归、无用户可见后果。

⭐ 但它踩的是一条写明的架构约束，这是它不该被关掉的理由

@object-ui/components is the Atoms package, which AGENTS.md section 3 constrains to "Shadcn primitives, zero heavy 3rd-party deps". recharts is a heavy charting library … @object-ui/plugin-charts declares its own recharts and is where the charting weight is supposed to live.

⇒ 这不是"有个没用的依赖"，是一条成文的分层约束今天被违反着，而违反的原因（chart 原语曾住在这里）已经消失。

⚠️ 门禁看不见它，卡片解释了为什么 —— 这条值得记

check:phantom-deps passes — it judges the opposite direction (imports that are not declared), so nothing in CI currently sees an unused declaration.

⭐ 一个方向被门住、反方向敞着。⛔ 接手者不要以为"门禁绿所以没问题"。⚠️ 顺带："声明了但没人 import"这个方向值得一个门禁，尤其对 Atoms 包那条 zero-heavy-deps 约束 —— ⛔ 但那是另一张卡，别在本卡里做。

⛔ 给执行席的边界

1. 与 dependabot chore(deps): Bump lucide-react from 1.31.0 to 1.37.0 #7058 协调（它在同一个文件里升 lucide-react）。⛔ 两个 PR 同时改 packages/components/package.json 会冲突 —— 等它落地后做，或与它合并。
2. 改前改后各跑一次那个 grep + 控制（卡片要求，且它自己的家族因为省掉控制而出过错）。
3. ⚠️ 删依赖会改 lockfile ⇒ 确认 packages/components 的构建与测试仍绿。⛔ 特别注意任何测试里可能还 import recharts（本席的 grep 只覆盖 packages/components/src，卡片也是）。
4. ⛔ 不要顺手去动 @object-ui/plugin-charts 的 recharts 声明 —— 那里是它该在的地方。

⛔ 分诊席不认领、不派单、不写码。

---

Generated by Claude Code