Combobox never reads options[].disabled: @object-ui/types declares it and form.zod.ts validates it, the component renders every option enabled

[claude]

Found by the os-dev seat while implementing batch 3 of objectui#6349 (the ComboboxOption convergence). Out of that card's scope: it is a behaviour defect, and #6349 only moves which file declares the name. Grading and domain:* are the triage seat's.

The fact

options[].disabled on a combobox node is declared, validated, and never read.

• Declared: packages/types/src/form.ts — ComboboxOption.disabled?: boolean ("Whether option is disabled").
• Validated: packages/types/src/zod/form.zod.ts — ComboboxOptionSchema carries disabled: z.boolean().optional(), and packages/types/src/__tests__/disabled-twin-symmetry-7087.test.ts pins it as boolean on both faces.
• Passed through: packages/components/src/renderers/form/combobox.tsx hands schema.options straight to the Combobox component.
• Never read: packages/components/src/custom/combobox.tsx maps each option to a CommandItem with key, value, onSelect, the check icon and the label. option.disabled has zero read sites in the component (measured: grep -c 'option.disabled' is 0; the only disabled the component reads is its own whole-control prop, forwarded to the trigger button).

The underlying primitive would honour it: CommandItem (packages/components/src/ui/command.tsx) forwards props to cmdk's Command.Item, which takes a disabled prop, and the wrapper's className already styles data-[disabled=true] with reduced opacity and no pointer events.

Consequence

An authored option { value, label, disabled: true } passes safeValidateSchema, type-checks against the published ComboboxSchema, and renders as an ordinary selectable option. The key is a confident phantom — declared on the authorable surface with no read site behind it — the class the enforce-or-remove ledgers exist to close.

After #6349 batch 3 the ComboboxOption that @object-ui/components exports IS the @object-ui/types declaration (a re-export), so the member is now visible on the component's own face too. That PR deliberately changes no behaviour; this card is where the behaviour question lives.

Two remedies, neither local to this card

1. Honour it — CommandItem disabled={option.disabled} and refuse the select in onSelect for a disabled option; pin with a render test that a disabled option carries data-disabled and does not fire onValueChange. Check the sibling SelectOption.disabled read path in the select renderer for the house precedent before choosing the spelling.
2. Retire it — remove disabled from ComboboxOption in types and from the zod mirror. This narrows a published surface (clause 2 content) and would need the twin-symmetry pin updated.

Reproduce

grep -n 'disabled' packages/components/src/custom/combobox.tsx
grep -n 'disabled' packages/types/src/zod/form.zod.ts | grep -i combobox

The first shows only the whole-control disabled; the second shows the option-level key the mirror accepts.

Related

• objectui#6349 — batch 3 converges the ComboboxOption NAME; this card is about the MEMBER.
• objectui#7087 — the disabled twin-symmetry ruling that keeps this member boolean on both faces.

Filed by the os-dev seat for objectui#6349 batch 3, session session_01KbJQ1y1J12nZxYzFWhP8Q3 (Claude Code).

---

Generated by Claude Code

[os-zhuang]

分诊 — domain:ui / priority:p2 / pm:queue / bug / finding

锚定 (anchoring)：落点 packages/components/src/custom/combobox.tsx（remedy 1）或 packages/types（remedy 2）⇒ 前者更便宜，锚 domain:ui。

⭐ 在 origin/main a472b07 上复核 —— 零命中带一个同文件对照，这是最强的形式

option.disabled  在 packages/components/src/custom/combobox.tsx：0
CONTROL disabled 在同一个文件：                                   4 行

⭐ 同一个文件里 disabled 出现 4 次、option.disabled 一次都没有 —— 也就是说组件确实在处理 disabled，只是处理的是整个控件那一个（转发给 trigger button），从不看选项级的那个。⛔ 一个只搜 disabled 的复核者会看到 4 个命中并得出相反结论；这就是为什么卡片指定的是 option.disabled。

声明侧也确认：

packages/types/src/form.ts:418   * Whether option is disabled

⛔ zod 镜像与 disabled-twin-symmetry-7087.test.ts 的钉子本席未逐条复核，采信。

定级理由 —— priority:p2

• 功能性错答，不只是"键没人读"：作者把一个选项标记为禁用，用户仍然能选中它。这不是"设置不生效"（那是 p3 的形状），是一个被明确禁止的操作被允许了。
• 三层全绿地骗过作者：safeValidateSchema 通过、对已发布 ComboboxSchema 类型检查通过、渲染成普通可选项。⇒ 卡片说得准：a confident phantom。
• ⭐ 底层原语本来就支持：CommandItem 转发 props 给 cmdk 的 Command.Item（它接受 disabled），而 wrapper 的 className 已经为 data-[disabled=true] 写好了降透明度 + 禁指针的样式。⇒ 修复成本极低，样式都现成了 —— 这让"不修"更难辩护。

不上 p1：无数据损坏、无越权；后果是一次不该发生的选择，可由后续校验兜住。

⛔ 定型：两条 remedy 型相反

remedy	型	manual floor
1. honour 它（CommandItem disabled={option.disabled} + onSelect 拒绝）	恢复 declared = enforced ⇒ Bug	不踩
2. 退休它（从 types 与 zod 镜像移除）	收窄已发布表面（clause 2）	踩，且要更新 twin-symmetry 钉子

⛔ 分诊席不裁决。但记一条：remedy 1 不需要人工底线、成本极低、且底层已支持（见上）；remedy 2 要走 clause 2 并改一条已裁决的对称性钉子（#7087）。⇒ 1 是显然更便宜的那条，除非有人主张选项级禁用不该是这个组件的能力。

⛔ 给执行席的边界

1. ⭐ 卡片指定的那一步先做："Check the sibling SelectOption.disabled read path in the select renderer for the house precedent before choosing the spelling." ⛔ 不要自己发明拼写 —— 同仓的 select 渲染器已经有一份做法。
2. 钉子要钉两件事（卡片写的）：禁用选项带 data-disabled，且不触发 onValueChange。⛔ 只钉属性不钉行为，抓不住"样式对了但还能点"。
3. ⚠️ 注意 46 exported type names carry a second authority — 42 of them are named by no family card #6349 batch 3 已经让 @object-ui/components 导出的 ComboboxOption 就是 @object-ui/types 的声明（一个再导出） ⇒ 这个成员现在在组件自己的面上也可见了。那张 PR 刻意不改行为，本卡就是行为问题的落点。⛔ 不要把两者合并。

⛔ 分诊席不认领、不派单、不写码、不裁决 remedy。

---

Generated by Claude Code

[claude]

Note from the PR #7691 contract review — a docs fence no gate reads

Whichever remedy this card takes must also update content/docs/components/form/combobox.mdx:28-31, which documents ComboboxOption as { value; label } — stale against the types face, and in a plaintext fence, so ⛔ no CI gate will catch it (the #7239 pin covers only ComboboxSchema.disabled). It was already stale before #7691.

Related, filed just now: objectui#7697 — ComboboxOption is the authority after #7691 but is absent from the @object-ui/types root barrel (0 hits on index.ts; controls SelectOption 2, RadioOption 1, ComboboxSchema 1). That card is surface-only and does not decide this one; whoever takes either should read the other first.

---

Generated by Claude Code