From dbc3d3e0bfeb62700e8937e3d50d4fcfde6d23e1 Mon Sep 17 00:00:00 2001 From: Rudi Grinberg Date: Sat, 29 Aug 2026 09:39:16 +0100 Subject: [PATCH] test(engine): cover failed action trace collection Have a failing action emit a valid trace event and snapshot the collected action traces afterward. The missing event records that result validation skips trace collection on action failure. Signed-off-by: Rudi Grinberg --- .../trace/action-traces/invalid-trace.t | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/test/blackbox-tests/test-cases/trace/action-traces/invalid-trace.t b/test/blackbox-tests/test-cases/trace/action-traces/invalid-trace.t index 3e032476b89..a3a09b10cac 100644 --- a/test/blackbox-tests/test-cases/trace/action-traces/invalid-trace.t +++ b/test/blackbox-tests/test-cases/trace/action-traces/invalid-trace.t @@ -16,3 +16,18 @@ Invalid traces should be an error Error: invalid action trace in _build/REDACTED [1] + +A failed action currently leaves its trace event uncollected. + + $ cat >dune <<'EOF' + > (rule + > (alias failed) + > (action + > (bash "action_trace -name failed -cat bar -arg baz; exit 1"))) + > EOF + + $ dune build @failed >/dev/null 2>&1 || + > dune trace cat --only-actions | + > jq_dune -s ' + > redactedActionTraces | select(.name == "failed") + > '