Some issues I had

[davidrios]

Hello,

First of all, thank you for your hard work on this.

I had a few issues while using the packages:

• m2 model: had to tweak the header reading a bit since it wasn't parsing v264 file correctly
• m2 blp: files don't seem to be parsed correctly. Here's what I get:

BlpTexture {
    header: BlpHeader {
        magic: [
            66,
            76,
            80,
            50,
        ],
        compression_type: Uncompressed,
        alpha_bits: 0,
        width: 0,
        height: 2,
        pixel_format: Dxt1,
        mipmap_levels: 1,
    },
    mipmaps: [
        BlpMipmap {
            data: [
                0,
                0,
                0,
                0,
                0,
                0,
                0,
            ] + 6541 elements,
            width: 1,
            height: 2,
        },
    ],
    palette: Some([
        0,
        0,
        0,
        0,
        0,
        0,
        0,
    ] + 249 elements),
}

If I change the parsing to be according to https://wowdev.wiki/BLP, here's what I got:

BlpTexture {
    header: BlpHeader {
        magic: [
            66,
            76,
            80,
            50,
        ],
        compression_type: Dxt,
        alpha_bits: 0,
        width: 64,
        height: 128,
        pixel_format: Dxt1,
        mipmap_levels: 1,
    },
    mipmaps: [
        BlpMipmap {
            data: [
                171,
                49,
                73,
                41,
                171,
                42,
                42,
            ] + 4089 elements,
            width: 64,
            height: 128,
        },
    ],
    palette: None,
    jpeg_info: Some(
        JpegInfo {
            header_size: 0,
            header_data: [
                0,
                0,
                0,
                0,
                0,
                0,
                0,
            ] + 1013 elements,
        },
    ),
}

• m2 skins: same thing, I get garbage trying to parse a skin file, then I checked https://wowdev.wiki/M2/.skin, changed the code to read the header format there and now it works.

Now, the 3 things I tried to use didn't work, I'm wondering if this is only compatible with specific versions, or which files you're using for testing. I'm using original files from 3.3.5

[danielsreichenbach]

Thanks for the feedback, those should be bug tickets in the project 😄

On a serious note: each of the crates is supposed to support all file format versions from WoW 1.12.1 to 5.4.8.

There may be bugs because I basically combined three or four handful of existing projects.

As for the above:

• BLP support should be complete for all variations but this looks like a bug. I will investigate that.
• m2 model format: the format version changes are many and this looks like I missed one or two specifics.
• M2 skin files: these are indeed not finished. I still have to work on the files that were extracted from the M2 models for Wrath.

[davidrios]

I have this work that I'm doing, but I also implemented debug output truncating for an easier time debugging: wowemulation-dev/warcraft-rs@main...davidrios:warcraft-rs:less-debug-output
Let me know if you have interest

[davidrios]

I'm not creating tickets because I don't have time for that as I need it working right now 😂

[danielsreichenbach]

Let me know if you have interest

First, thanks for using my stuff 😃
Second, I am very happy for any suggestions or pull requests for the project.

Will take a look at your fixes and see what I can do. Gonna run this over my data archive and test.

[danielsreichenbach]

I'm not creating tickets because I don't have time for that as I need it working right now 😂

That's fine. I will just port the fixes. Thanks for making them public. That's worth a lot!

[danielsreichenbach]

I have this work that I'm doing, but I also implemented debug output truncating for an easier time debugging: wowemulation-dev/warcraft-rs@main...davidrios:warcraft-rs:less-debug-output
Let me know if you have interest

Have back ported the fixes. Thanks again, much appreciated.

If you need anything else, we are here 😌

[danielsreichenbach]

Now, the 3 things I tried to use didn't work, I'm wondering if this is only compatible with specific versions, or which files you're using for testing. I'm using original files from 3.3.5

Things should be a little easier now. I pushed an update today, unifying the BLP usage in the project. This resolves the issue in the M2 crate, and from now on M2 files will use the BLP crate to parse BLPs in models.