'), true);
- assert.equal(isMediaOnly(""), true);
- assert.equal(isMediaOnly("![alt [with bracket]](https://example.com/x.png)"), true);
- assert.equal(isMediaOnly(".png)"), true);
- assert.equal(isMediaOnly('.png "title")'), true);
- assert.equal(isMediaOnly("b.png)"), false);
- assert.equal(isMediaOnly("\\"), false);
- // Reference-style images (Codex bot finding): inline ref + definition.
- assert.equal(isMediaOnly("![Image][shot]\n\n[shot]: https://example.com/x.png"), true);
- assert.equal(isMediaOnly("![Image][]\n\n[Image]: https://example.com/x.png"), true);
- assert.equal(isMediaOnly("![Image][shot]\n\n[shot]: https://example.com/x.png\ncaption"), false);
- // Fallback prose inside media blocks is preserved (Codex bot finding).
- assert.equal(
- isMediaOnly(""),
- false,
- );
- assert.equal(isMediaOnly(''), true);
- assert.equal(isMediaOnly("'), false);
- assert.equal(isMediaOnly(' '), false);
- assert.equal(isMediaOnly('\t'), false);
- // Reference labels with nested alt brackets (CodeRabbit finding).
- assert.equal(isMediaOnly("![Image [screenshot]][shot]\n\n[shot]: https://example.com/x.png"), true);
- assert.equal(
- isMediaOnly("![Image [screenshot]][shot]\n\n[shot]: https://example.com/x.png\ncaption"),
- false,
- );
- assert.equal(isMediaOnly('
\nCaption text'), false);
- assert.equal(isMediaOnly("Some real description."), false);
- assert.equal(stripMediaTokens('').trim(), "");
- assert.equal(stripMediaTokens('').trim(), "");
- assert.equal(stripMediaTokens('before  after').replace(/\s+/g, " ").trim(), "before after");
- });
-
- it("accepts a concise but actionable feature", () => {
- const body = [
- "### Area",
- "CLI",
- "### What are you trying to accomplish?",
- "Pin the proxy port across restarts.",
- "### What prevents this today?",
- "Port resets to 10100 after ocx stop.",
- "### What should OpenCodex do?",
- "Remember the last used port in config.",
- "### Example usage or interface",
- "ocx start --port 8080 && ocx stop && ocx start # still 8080",
- ].join("\n");
- const result = validateIssue({ title: "Persist port across restarts", body, labels: ["enhancement"] });
- assert.equal(result.kind, "feature");
- assert.equal(result.valid, true);
- });
-
- it("rejects issue #401-style low-effort feature with placeholder example", () => {
- const body = [
- "### Area",
- "Proxy and routing",
- "### What are you trying to accomplish?",
- "Quota for Chatgpt running out that can no longer use voice mode. Would like to change other model for that",
- "### What prevents this today?",
- "No usage without codex quota",
- "### What should OpenCodex do?",
- "Change another voice model",
- "### Example usage or interface",
- "NA",
- ].join("\n");
- const result = validateIssue({
- title: "Change voice chat to different model",
- body,
- labels: ["enhancement"],
- });
- assert.equal(result.kind, "feature");
- assert.equal(result.valid, false);
- assert.ok(result.reasons.some((r) => r.includes("placeholder")));
- assert.ok(result.reasons.some((r) => r.includes("expected behaviour")));
- });
-
- it("rejects feature reports with placeholder example variants", () => {
- const placeholders = [
- "NA",
- "N/A",
- "_N/A_",
- "NA.",
- "N/A.",
- "Not applicable",
- "Not applicable.",
- "Not available!",
- ];
- for (const example of placeholders) {
- const body = [
- "### What are you trying to accomplish?",
- "Route voice requests to a configured fallback provider when the primary quota is exhausted.",
- "### What prevents this today?",
- "Voice mode is hard-wired to the primary Codex quota and cannot switch providers.",
- "### What should OpenCodex do?",
- "Expose a setting to choose the fallback voice model and provider.",
- "### Example usage or interface",
- example,
- ].join("\n");
- const result = validateIssue({ title: "Voice fallback routing", body, labels: ["enhancement"] });
- assert.equal(result.valid, false, `Expected placeholder example "${example}" to be invalid`);
- assert.ok(
- result.reasons.some((r) => r.includes("placeholder")),
- `Expected placeholder reason for "${example}", got: ${result.reasons.join("; ")}`,
- );
- assert.ok(!result.reasons.some((r) => r.includes("example usage")));
- }
- });
-
- it("reports blank example usage as missing, not placeholder", () => {
- const body = [
- "### What are you trying to accomplish?",
- "Route voice requests to a configured fallback provider when the primary quota is exhausted.",
- "### What prevents this today?",
- "Voice mode is hard-wired to the primary Codex quota and cannot switch providers.",
- "### What should OpenCodex do?",
- "Expose a setting to choose the fallback voice model and provider.",
- "### Example usage or interface",
- "",
- ].join("\n");
- const result = validateIssue({ title: "Voice fallback routing", body, labels: ["enhancement"] });
- assert.equal(result.valid, false);
- assert.ok(result.reasons.some((r) => r.includes("example usage")));
- assert.ok(!result.reasons.some((r) => r.includes("placeholder")));
- });
-
- it("accepts a valid legacy feature request without blocker/example headings", () => {
- const body = [
- "### Problem to solve",
- "No way to set a custom timeout per provider in the proxy config.",
- "### Proposed solution",
- "Add a per-provider timeout field in the config JSON.",
- ].join("\n");
- const result = validateIssue({ title: "[Feature]: per-provider timeout", body, labels: ["enhancement"] });
- assert.equal(result.kind, "feature");
- assert.equal(result.valid, true, `Expected valid but got reasons: ${result.reasons.join(", ")}`);
- });
-
- it("accepts a detailed CJK submission", () => {
- const body = [
- "### Area",
- "Proxy and routing",
- "### What are you trying to accomplish?",
- "\u4ee3\u7406\u670d\u52a1\u5668\u9700\u8981\u652f\u6301\u591a\u4e2a\u4e0a\u6e38\u63d0\u4f9b\u5546\u7684\u81ea\u52a8\u6545\u969c\u8f6c\u79fb\uff0c\u5f53\u4e3b\u63d0\u4f9b\u5546\u8fd4\u56de\u9519\u8bef\u65f6\u81ea\u52a8\u5207\u6362\u5230\u5907\u7528\u63d0\u4f9b\u5546\u3002",
- "### What prevents this today?",
- "\u76ee\u524d\u4ee3\u7406\u4e0d\u652f\u6301\u6545\u969c\u8f6c\u79fb\uff0c\u9700\u8981\u624b\u52a8\u91cd\u542f\u5e76\u66f4\u6539\u914d\u7f6e\u3002",
- "### What should OpenCodex do?",
- "\u5f53\u4e3b\u63d0\u4f9b\u5546\u8fd4\u56de 5xx \u6216\u8d85\u65f6\u65f6\uff0c\u81ea\u52a8\u5c06\u8bf7\u6c42\u8f6c\u53d1\u5230\u914d\u7f6e\u7684\u5907\u7528\u63d0\u4f9b\u5546\u3002",
- "### Example usage or interface",
- "```json\n{\"routing\":{\"fallback_provider\":\"anthropic\"}}\n```",
- ].join("\n");
- const result = validateIssue({ title: "\u652f\u6301\u591a\u63d0\u4f9b\u5546\u6545\u969c\u8f6c\u79fb", body, labels: ["enhancement"] });
- assert.equal(result.kind, "feature");
- assert.equal(result.valid, true);
- });
-
- it("rejects terse goal sections that only contain a keyword, digit, or punctuation", () => {
- const terseGoals = ["API", "provider", "1", "/", "use CLI", "route 1"];
- for (const goal of terseGoals) {
- const result = validateIssue({
- title: "Improve feature request quality",
- body: featureBodyWithGoal(goal),
- labels: ["enhancement"],
- });
- assert.equal(result.kind, "feature");
- assert.equal(result.valid, false, `Expected terse goal "${goal}" to be invalid`);
- assert.ok(
- result.reasons.some((r) => r.includes("too vague") || /missing or empty/i.test(r)),
- `Expected too vague or empty reason for "${goal}", got: ${result.reasons.join(", ")}`,
- );
- }
- });
-
- it("rejects a single long non-CJK word as overly terse", () => {
- const terseGoals = [
- "провайдер",
- "маршрут",
- "πάροχος",
- "واجهة",
- ];
- for (const goal of terseGoals) {
- assert.equal(countWords(goal), 1, `Expected "${goal}" to count as one word`);
- const result = validateIssue({
- title: "Improve feature request quality",
- body: featureBodyWithGoal(goal),
- labels: ["enhancement"],
- });
- assert.equal(result.kind, "feature");
- assert.equal(result.valid, false, `Expected terse goal "${goal}" to be invalid`);
- assert.ok(
- result.reasons.some((r) => r.includes("too vague")),
- `Expected too vague reason for "${goal}", got: ${result.reasons.join(", ")}`,
- );
- }
- });
-
- it("counts mixed-script CJK text without inflating non-CJK letter length", () => {
- assert.equal(countWords("provider中"), 2);
- assert.equal(countWords("провайдер中"), 2);
- assert.equal(countWords("configuration中"), 2);
- assert.equal(countWords("中provider文"), 3);
- });
-
- it("rejects mixed-script CJK stubs that only inflate letter counts", () => {
- const terseGoals = ["provider中", "провайдер中", "configuration中"];
- for (const goal of terseGoals) {
- assert.ok(countWords(goal) < 8, `Expected "${goal}" to stay under 8 units`);
- const result = validateIssue({
- title: "Improve feature request quality",
- body: featureBodyWithGoal(goal),
- labels: ["enhancement"],
- });
- assert.equal(result.kind, "feature");
- assert.equal(result.valid, false, `Expected terse goal "${goal}" to be invalid`);
- assert.ok(
- result.reasons.some((r) => r.includes("too vague")),
- `Expected too vague reason for "${goal}", got: ${result.reasons.join(", ")}`,
- );
- }
- });
-
- it("accepts sufficiently detailed goal sections", () => {
- const detailedGoal =
- "Expose a dashboard setting to choose the fallback voice model and provider.";
- const detailedResult = validateIssue({
- title: "Voice fallback routing",
- body: featureBodyWithGoal(detailedGoal),
- labels: ["enhancement"],
- });
- assert.equal(detailedResult.kind, "feature");
- assert.equal(detailedResult.valid, true);
- assert.ok(countWords(detailedGoal) >= 8);
- });
-
- it("accepts a 6-7 word goal when it includes concrete technical detail", () => {
- const concreteGoal = "Route requests through the configured API provider.";
- assert.equal(countWords(concreteGoal), 7);
- assert.ok(countWords(concreteGoal) < 8);
- assert.ok(countWords(concreteGoal) >= 6);
- assert.equal(hasConcreteDetail(concreteGoal), true);
-
- const concreteResult = validateIssue({
- title: "Voice fallback routing",
- body: featureBodyWithGoal(concreteGoal),
- labels: ["enhancement"],
- });
- assert.equal(concreteResult.kind, "feature");
- assert.equal(concreteResult.valid, true);
- });
-
- it("rejects a 6-7 word goal that lacks concrete technical detail", () => {
- // Avoid keywords that count as concrete detail (api/provider/workflow/…).
- const vagueGoal = "Make this process easier for all users.";
- assert.equal(countWords(vagueGoal), 7);
- assert.equal(hasConcreteDetail(vagueGoal), false);
-
- const vagueResult = validateIssue({
- title: "Voice fallback routing",
- body: featureBodyWithGoal(vagueGoal),
- labels: ["enhancement"],
- });
- assert.equal(vagueResult.kind, "feature");
- assert.equal(vagueResult.valid, false);
- assert.ok(vagueResult.reasons.some((r) => r.includes("too vague")));
- });
-
- it("treats only commands, errors, paths, or exact actions as actionable reproduction detail", () => {
- assert.equal(hasActionableReproductionDetail("1. choose model deepseek\n2. send a message in codex plugin"), false);
- assert.equal(hasActionableReproductionDetail("I want to work with deepseek in VSCode, but it dont reply"), false);
- assert.equal(hasActionableReproductionDetail("1. ocx start --port 10100\n2. Send a request"), true);
- assert.equal(hasActionableReproductionDetail("Run ocx start and send any streaming request."), true);
- assert.equal(hasActionableReproductionDetail("ocx start on Raspberry Pi 4, send any streaming request."), true);
- assert.equal(hasActionableReproductionDetail("send a request"), false);
- assert.equal(hasActionableReproductionDetail("make a call"), false);
- assert.equal(hasActionableReproductionDetail("post a command"), false);
- assert.equal(hasActionableReproductionDetail("make an API call"), true);
- assert.equal(hasActionableReproductionDetail("send an HTTP request"), true);
- assert.equal(hasActionableReproductionDetail("send a request to /v1/responses"), true);
- assert.equal(hasActionableReproductionDetail("The proxy returns HTTP 502 after the first streaming chunk."), true);
- assert.equal(hasActionableReproductionDetail("Paste ~/.codex/config.toml, then restart the proxy."), true);
- assert.equal(hasActionableReproductionDetail("```\n\n```"), false);
- assert.equal(hasActionableReproductionDetail("~~~\n\n~~~"), false);
- assert.equal(hasActionableReproductionDetail("```\nSIGSEGV at 0x0000\n```"), true);
- });
-
- it("rejects fenced placeholder-only examples", () => {
- const fencedPlaceholders = [
- "```\nN/A\n```",
- "```text\nN/A\n```",
- "```json\nNot applicable.\n```",
- "~~~text\nN/A\n~~~",
- ];
- for (const example of fencedPlaceholders) {
- assert.equal(
- isPlaceholderOnlyValue(example),
- true,
- `Expected fenced placeholder to match: ${JSON.stringify(example)}`,
- );
- const result = validateIssue({
- title: "Voice fallback routing",
- body: featureBodyWithExample(example),
- labels: ["enhancement"],
- });
- assert.equal(result.valid, false, `Expected fenced placeholder to be invalid: ${JSON.stringify(example)}`);
- assert.ok(
- result.reasons.some((r) => r.includes("placeholder")),
- `Expected placeholder reason for ${JSON.stringify(example)}, got: ${result.reasons.join("; ")}`,
- );
- }
- });
-
- it("accepts real fenced examples that merely mention N/A", () => {
- const realExamples = [
- "```text\nThe API returns N/A when no provider is configured.\n```",
- '```json\n{"provider":"N/A","fallback":"anthropic"}\n```',
- ];
- for (const example of realExamples) {
- assert.equal(
- isPlaceholderOnlyValue(example),
- false,
- `Expected real example not to be placeholder-only: ${JSON.stringify(example)}`,
- );
- const result = validateIssue({
- title: "Voice fallback routing",
- body: featureBodyWithExample(example),
- labels: ["enhancement"],
- });
- assert.equal(
- result.valid,
- true,
- `Expected real fenced example to remain valid, got: ${result.reasons.join("; ")}`,
- );
- }
- });
-});
-// ---------------------------------------------------------------------------
-// Validation: bug
-// ---------------------------------------------------------------------------
-
-describe("validateIssue - bug", () => {
- it("rejects an empty bug report", () => {
- const body = [
- "### Client or integration",
- "Codex CLI",
- "### Area",
- "CLI",
- "### Summary",
- "No response",
- "### Reproduction",
- "No response",
- "### Version",
- "No response",
- "### Operating system",
- "No response",
- ].join("\n");
- const result = validateIssue({ title: "Bug", body, labels: ["bug"] });
- assert.equal(result.kind, "bug");
- assert.equal(result.valid, false);
- });
-
- it("rejects a bug with Summary filled but Reproduction empty", () => {
- const body = [
- "### Client or integration",
- "Codex CLI",
- "### Area",
- "CLI",
- "### Summary",
- "The 'gpt-5.6-sol' model is not supported when using Codex with a ChatGPT account.",
- "### Reproduction",
- "No response",
- "### Version",
- "2.7.42",
- "### Operating system",
- "macOS",
- ].join("\n");
- const result = validateIssue({ title: "Open Codex Error", body, labels: ["bug"] });
- assert.equal(result.kind, "bug");
- assert.equal(result.valid, false);
- assert.ok(result.reasons.some((r) => /Reproduction is empty/i.test(r)));
- assert.ok(!result.reasons.some((r) => /Summary is empty/i.test(r)));
- });
-
- it("rejects a bug whose Reproduction is only an ellipsis (#598)", () => {
- const body = [
- "### Client or integration",
- "Codex CLI",
- "### Area",
- "CLI",
- "### Summary",
- "{\"detail\":\"The 'gpt-5.6-sol' model is not supported when using Codex with a ChatGPT account.\"}",
- "### Reproduction",
- "...",
- "### Version",
- "2.7.42",
- "### Operating system",
- "mac os",
- ].join("\n");
- const result = validateIssue({ title: "Open Codex Error", body, labels: ["bug"] });
- assert.equal(result.kind, "bug");
- assert.equal(result.valid, false);
- assert.ok(result.reasons.some((r) => /Reproduction is empty/i.test(r)));
- });
-
- it("rejects a bug with Reproduction filled but Summary empty", () => {
- const body = [
- "### Client or integration",
- "Codex CLI",
- "### Area",
- "CLI",
- "### Summary",
- "",
- "### Reproduction",
- "1. Run ocx start\n2. Send a request",
- "### Version",
- "2.7.42",
- "### Operating system",
- "macOS",
- ].join("\n");
- const result = validateIssue({ title: "Crash", body, labels: ["bug"] });
- assert.equal(result.kind, "bug");
- assert.equal(result.valid, false);
- assert.ok(result.reasons.some((r) => /Summary is empty/i.test(r)));
- });
-
- it("accepts a terse real crash report", () => {
- const body = [
- "### Client or integration",
- "Codex CLI",
- "### Area",
- "Proxy and routing",
- "### Summary",
- "Proxy segfaults on ARM64 when streaming is enabled.",
- "### Reproduction",
- "ocx start on Raspberry Pi 4, send any streaming request.",
- "### Version",
- "2.7.30",
- "### Operating system",
- "Debian 12 aarch64",
- "### Logs or error output",
- "```",
- "SIGSEGV at 0x0000 in bun_runtime",
- "```",
- ].join("\n");
- const result = validateIssue({ title: "Segfault on ARM64 streaming", body, labels: ["bug"] });
- assert.equal(result.kind, "bug");
- assert.equal(result.valid, true);
- });
-
- it("accepts a valid legacy bug report without version/OS headings", () => {
- const body = [
- "### Summary",
- "The proxy crashes when streaming is enabled.",
- "### Reproduction",
- "Run ocx start and send a streaming request.",
- ].join("\n");
- const result = validateIssue({ title: "[Bug]: crash on streaming", body, labels: ["bug"] });
- assert.equal(result.kind, "bug");
- assert.equal(result.valid, true, `Expected valid but got reasons: ${result.reasons.join(", ")}`);
- });
-
- it("accepts a legacy bug with _No response_ in old optional env fields", () => {
- const body = [
- "### Summary",
- "Proxy crashes on startup.",
- "### Reproduction",
- "Run ocx start.",
- "### Version",
- "_No response_",
- "### OS",
- "_No response_",
- ].join("\n");
- const result = validateIssue({ title: "[Bug]: crash", body, labels: ["bug"] });
- assert.equal(result.kind, "bug");
- assert.equal(result.valid, true, `Expected valid but got: ${result.reasons.join(", ")}`);
- });
-
- it("accepts a legacy bug with N/A-style placeholders in Version and Operating system", () => {
- for (const placeholder of ["N/A", "NA", "Not applicable.", "Not available!"]) {
- const body = [
- "### Summary",
- "Proxy crashes on startup when streaming is enabled.",
- "### Reproduction",
- "Run ocx start and send any streaming request.",
- "### Version",
- placeholder,
- "### Operating system",
- placeholder,
- ].join("\n");
- const result = validateIssue({ title: "[Bug]: crash", body, labels: ["bug"] });
- assert.equal(result.kind, "bug");
- assert.equal(
- result.valid,
- true,
- `Expected legacy env placeholder "${placeholder}" to remain valid, got: ${result.reasons.join(", ")}`,
- );
- assert.ok(!result.reasons.some((r) => r.includes("Version")));
- }
- });
-
- it("rejects a new-form bug where env fields were actively cleared", () => {
- const body = [
- "### Client or integration",
- "Codex CLI",
- "### Summary",
- "Proxy crashes.",
- "### Reproduction",
- "Run ocx start.",
- "### Version",
- "",
- "### Operating system",
- "",
- ].join("\n");
- const result = validateIssue({ title: "Crash", body, labels: ["bug"] });
- assert.equal(result.kind, "bug");
- assert.equal(result.valid, false);
- assert.ok(result.reasons.some((r) => r.includes("Version")));
- });
-
- it("rejects unknown / don't-know Version values (#624)", () => {
- const versions = [
- "Unknown",
- "Uknown",
- "unkown",
- "Don't know",
- "dont know",
- "idk",
- "모름",
- "잘 모름",
- "?",
- "???",
- ];
- for (const version of versions) {
- const body = [
- "### Client or integration",
- "Codex CLI",
- "### Area",
- "CLI",
- "### Summary",
- "The OpenCodex proxy keeps dropping the Codex CLI connection mid-request.",
- "### Reproduction",
- "1. ocx start --port 10100",
- "2. Send any Codex CLI request through the proxy",
- "3. Observe the connection drop",
- "### Version",
- version,
- "### Operating system",
- "Windows 11",
- ].join("\n");
- const result = validateIssue({
- title: "Unexpected interruption continues to occur",
- body,
- labels: ["bug"],
- });
- assert.equal(result.kind, "bug");
- assert.equal(
- result.valid,
- false,
- `Expected unusable Version "${version}" to be invalid, got: ${result.reasons.join("; ")}`,
- );
- assert.ok(
- result.reasons.some((r) => /Version/i.test(r) && /unknown|missing/i.test(r)),
- `Expected Version unknown/missing reason for "${version}", got: ${result.reasons.join("; ")}`,
- );
- }
- });
-
- it("rejects issue #624-style low-effort new-form bug", () => {
- const body = [
- "### Client or integration",
- "Codex CLI",
- "### Area",
- "CLI",
- "### Summary",
- "CLI로 확인해봤는데 오픈코덱스 프록시가 중간에 자꾸 연결이 끊어져서 그런거라고 합니다.",
- "",
- "수정 바랍니다.",
- "### Reproduction",
- "예기치않게중단됨",
- "### Version",
- "모름",
- "### Operating system",
- "윈11",
- "### Provider and model",
- "_No response_",
- "### Logs or error output",
- "```shell",
- "",
- "```",
- ].join("\n");
- const result = validateIssue({
- title: "Unexpected interruption continues to occur",
- body,
- labels: ["bug"],
- });
- assert.equal(result.kind, "bug");
- assert.equal(result.valid, false);
- assert.ok(result.reasons.some((r) => /Version/i.test(r)));
- assert.ok(result.reasons.some((r) => /Reproduction/i.test(r) && /vague|empty/i.test(r)));
- });
-
- it("rejects a new-form bug with a usable Version but placeholder OS", () => {
- const body = [
- "### Client or integration",
- "Codex CLI",
- "### Area",
- "CLI",
- "### Summary",
- "Proxy returns 502 when streaming is enabled on Windows.",
- "### Reproduction",
- "1. ocx start",
- "2. Send a streaming /v1/responses request",
- "### Version",
- "2.7.42",
- "### Operating system",
- "No response",
- ].join("\n");
- const result = validateIssue({ title: "Streaming 502", body, labels: ["bug"] });
- assert.equal(result.kind, "bug");
- assert.equal(result.valid, false);
- assert.ok(result.reasons.some((r) => /Operating system/i.test(r)));
- });
-
- it("rejects a new-form bug when the Version heading was removed", () => {
- const body = [
- "### Client or integration",
- "Codex CLI",
- "### Area",
- "CLI",
- "### Summary",
- "Proxy returns 502 when streaming is enabled on Windows.",
- "### Reproduction",
- "1. ocx start",
- "2. Send a streaming /v1/responses request",
- "### Operating system",
- "Windows 11",
- ].join("\n");
- const result = validateIssue({ title: "Streaming 502", body, labels: ["bug"] });
- assert.equal(result.kind, "bug");
- assert.equal(result.valid, false);
- assert.ok(result.reasons.some((r) => /Version/i.test(r) && /missing/i.test(r)));
- });
-
- it("rejects a new-form bug when the Operating system heading was removed", () => {
- const body = [
- "### Client or integration",
- "Codex CLI",
- "### Area",
- "CLI",
- "### Summary",
- "Proxy returns 502 when streaming is enabled on Windows.",
- "### Reproduction",
- "1. ocx start",
- "2. Send a streaming /v1/responses request",
- "### Version",
- "2.7.42",
- ].join("\n");
- const result = validateIssue({ title: "Streaming 502", body, labels: ["bug"] });
- assert.equal(result.kind, "bug");
- assert.equal(result.valid, false);
- assert.ok(result.reasons.some((r) => /Operating system/i.test(r) && /missing/i.test(r)));
- });
-
- it("rejects a new-form bug whose Reproduction is only a vague phrase", () => {
- const body = [
- "### Client or integration",
- "Codex CLI",
- "### Area",
- "CLI",
- "### Summary",
- "The OpenCodex proxy keeps dropping the Codex CLI connection mid-request.",
- "### Reproduction",
- "Unexpected interruption",
- "### Version",
- "2.7.42",
- "### Operating system",
- "Windows 11",
- ].join("\n");
- const result = validateIssue({
- title: "Unexpected interruption continues to occur",
- body,
- labels: ["bug"],
- });
- assert.equal(result.kind, "bug");
- assert.equal(result.valid, false);
- assert.ok(result.reasons.some((r) => /Reproduction/i.test(r) && /vague/i.test(r)));
- });
-
- it("rejects a #977-shaped bug with product keywords but no actionable reproduction", () => {
- const body = [
- "### Client or integration",
- "Other",
- "### Area",
- "Proxy and routing",
- "### Summary",
- "I want to work with deepseek in VSCode, but it dont reply,just thinking",
- "### Reproduction",
- "1.choose model deepseek",
- "2.send a message in codex plugin",
- "### Version",
- "2.10.0",
- "### Operating system",
- "Ubuntu 24.04",
- "### Provider and model",
- "deepseek",
- ].join("\n");
- const result = validateIssue({
- title: "Dont work in VSCode Codex plugin",
- body,
- labels: ["bug", "proxy"],
- });
- assert.equal(result.kind, "bug");
- assert.equal(result.valid, false);
- assert.ok(
- result.reasons.some((r) => /Reproduction/i.test(r) && /vague/i.test(r)),
- `Expected a vague Reproduction reason, got: ${result.reasons.join("; ")}`,
- );
- assert.ok(
- result.guidance.some((g) => /commands|steps/i.test(g)),
- `Expected reproduction guidance, got: ${result.guidance.join("; ")}`,
- );
- });
-
- it("rejects unknown Operating system stand-ins on the new bug form", () => {
- const body = [
- "### Client or integration",
- "Codex CLI",
- "### Area",
- "CLI",
- "### Summary",
- "The OpenCodex proxy keeps dropping the Codex CLI connection mid-request.",
- "### Reproduction",
- "1. ocx start --port 10100",
- "2. Send any Codex CLI request through the proxy",
- "3. Observe the connection drop",
- "### Version",
- "2.7.42",
- "### Operating system",
- "Unknown",
- ].join("\n");
- const result = validateIssue({
- title: "Unexpected interruption continues to occur",
- body,
- labels: ["bug"],
- });
- assert.equal(result.kind, "bug");
- assert.equal(result.valid, false);
- assert.ok(result.reasons.some((r) => /Operating system/i.test(r)));
- });
-});
-
-// ---------------------------------------------------------------------------
-// Validation: provider-compatibility
-// ---------------------------------------------------------------------------
-
-describe("validateIssue - provider-compatibility", () => {
- it("rejects when request and response are both absent", () => {
- const body = [
- "### Client or integration",
- "Codex CLI",
- "### Provider or upstream service",
- "mistral",
- "### OpenCodex version",
- "2.7.31",
- "### Endpoint or capability",
- "/v1/chat/completions",
- "### Current behaviour",
- "Returns 500.",
- "### Expected behaviour",
- "Returns 200.",
- "### Minimal redacted request or reproduction",
- "No response",
- "### Actual response or error",
- "No response",
- "### Upstream documentation",
- "https://docs.mistral.ai/api/",
- ].join("\n");
- const result = validateIssue({ title: "Mistral 500", body, labels: ["enhancement"] });
- assert.equal(result.kind, "provider-compatibility");
- assert.equal(result.valid, false);
- });
-
- it("accepts a complete provider compatibility report", () => {
- const body = [
- "### Client or integration",
- "Codex CLI",
- "### Provider or upstream service",
- "anthropic",
- "### OpenCodex version",
- "2.7.31",
- "### Endpoint or capability",
- "/v1/messages",
- "### Current behaviour",
- "Proxy strips the system field from the request.",
- "### Expected behaviour",
- "Proxy preserves the system field as documented.",
- "### Minimal redacted request or reproduction",
- "curl -X POST http://localhost:10100/v1/messages -d '{\"model\":\"claude-sonnet-4-20250514\",\"system\":\"You are helpful.\",\"messages\":[]}'",
- "### Actual response or error",
- "400: system is required",
- "### Upstream documentation",
- "https://docs.anthropic.com/en/api/messages",
- ].join("\n");
- const result = validateIssue({ title: "System field stripped", body, labels: ["enhancement"] });
- assert.equal(result.kind, "provider-compatibility");
- assert.equal(result.valid, true);
- });
-
- it("rejects provider compat report when provider/endpoint fields are cleared", () => {
- const body = [
- "### Client or integration",
- "Codex CLI",
- "### Provider or upstream service",
- "",
- "### OpenCodex version",
- "2.7.31",
- "### Endpoint or capability",
- "",
- "### Current behaviour",
- "Returns 400.",
- "### Expected behaviour",
- "Returns 200.",
- "### Minimal redacted request or reproduction",
- "curl ...",
- "### Actual response or error",
- "400 Bad Request",
- "### Upstream documentation",
- "https://docs.example.com",
- ].join("\n");
- const result = validateIssue({ title: "400 error", body, labels: ["provider-compatibility"] });
- assert.equal(result.kind, "provider-compatibility");
- assert.equal(result.valid, false);
- assert.ok(result.reasons.some((r) => r.includes("provider")));
- });
-});
-
-// ---------------------------------------------------------------------------
-// Validation: documentation
-// ---------------------------------------------------------------------------
-
-describe("validateIssue - documentation", () => {
- it("rejects an empty documentation report", () => {
- const body = [
- "### Documentation problem type",
- "Missing documentation",
- "### Documentation location",
- "No response",
- "### What is wrong or missing?",
- "No response",
- "### What should the documentation explain instead?",
- "No response",
- ].join("\n");
- const result = validateIssue({ title: "Docs", body, labels: ["documentation"] });
- assert.equal(result.kind, "documentation");
- assert.equal(result.valid, false);
- });
-
- it("accepts a complete documentation correction", () => {
- const body = [
- "### Documentation problem type",
- "Incorrect documentation",
- "### Documentation location",
- "https://lidge-jun.github.io/opencodex/providers/",
- "### What is wrong or missing?",
- "The page says kimi uses /v1/chat/completions but it actually uses /v1/responses.",
- "### What should the documentation explain instead?",
- "Update the endpoint to /v1/responses and add a note about the model discovery step.",
- ].join("\n");
- const result = validateIssue({ title: "Wrong kimi endpoint in docs", body, labels: ["documentation"] });
- assert.equal(result.kind, "documentation");
- assert.equal(result.valid, true);
- });
-});
-
-// ---------------------------------------------------------------------------
-// Normalisation
-// ---------------------------------------------------------------------------
-
-describe("normalisation", () => {
- it("treats 'No response' as empty", () => {
- assert.equal(clean("No response"), "");
- assert.equal(clean("_No response_"), "");
- });
-
- it("treats NA and not applicable as placeholders", () => {
- assert.equal(clean("NA"), "");
- assert.equal(clean("N/A"), "");
- assert.equal(clean("_N/A_"), "");
- assert.equal(clean("NA."), "");
- assert.equal(clean("N/A."), "");
- assert.equal(clean("not applicable"), "");
- assert.equal(clean("Not applicable."), "");
- assert.equal(clean("Not available!"), "");
- });
-
- it("detects unusable Version stand-ins without treating them as generic placeholders", () => {
- for (const value of ["Unknown", "Uknown", "모름", "idk", "don't know"]) {
- assert.equal(isUnusableVersion(value), true, value);
- assert.equal(isPlaceholderOnlyValue(value), false, value);
- }
- for (const value of ["2.7.42", "N/A", "No response", "main@abc1234"]) {
- assert.equal(isUnusableVersion(value), false, value);
- }
- });
-
- it("does not treat sentences containing placeholder phrases as empty", () => {
- assert.equal(clean("This is N/A for voice mode today."), "This is N/A for voice mode today.");
- assert.equal(clean("Not applicable to Claude Code."), "Not applicable to Claude Code.");
- });
-
- it("shares one placeholder matcher across clean, isPlaceholder, and isRawPlaceholder", () => {
- const placeholders = [
- "No response",
- "NA",
- "N/A",
- "_N/A_",
- "NA.",
- "N/A.",
- "None",
- "Todo",
- "TBD",
- "Not applicable",
- "Not applicable.",
- "Not available!",
- "```\nN/A\n```",
- "```text\nN/A\n```",
- "```json\nNot applicable.\n```",
- "~~~text\nN/A\n~~~",
- ];
- for (const value of placeholders) {
- assert.equal(isPlaceholderOnlyValue(value), true, value);
- assert.equal(isPlaceholder(value), true, value);
- assert.equal(isRawPlaceholder(value), true, value);
- assert.equal(clean(value), "", value);
- }
- assert.equal(isPlaceholderOnlyValue("Route voice traffic to provider N/A fallback"), false);
- assert.equal(isPlaceholderOnlyValue("```text\nThe API returns N/A when no provider is configured.\n```"), false);
- assert.equal(isPlaceholderOnlyValue('```json\n{"provider":"N/A","fallback":"anthropic"}\n```'), false);
- assert.equal(isPlaceholder("use CLI"), false);
- assert.equal(isRawPlaceholder(""), false);
- assert.equal(isRawPlaceholder(null), false);
- });
-
- it("strips HTML comments", () => {
- assert.equal(clean("Hello world"), "Hello world");
- });
-
- it("normalises punctuation and capitalisation", () => {
- assert.equal(normalise("Hello, World!"), normalise("hello world"));
- });
-
- it("removes filler phrases", () => {
- const a = canonicalise("I want to add streaming support");
- const b = canonicalise("add streaming support");
- assert.equal(a, b);
- });
-});
-
-// ---------------------------------------------------------------------------
-// extractSection
-// ---------------------------------------------------------------------------
-
-describe("extractSection", () => {
- it("extracts content between headings", () => {
- const body = "### Summary\nProxy crashes.\n### Reproduction\nRun ocx start.";
- assert.equal(extractSection(body, "Summary"), "Proxy crashes.");
- assert.equal(extractSection(body, "Reproduction"), "Run ocx start.");
- });
-
- it("returns null for missing sections", () => {
- assert.equal(extractSection("### Summary\nHello", "Reproduction"), null);
- });
-});
-
-// ---------------------------------------------------------------------------
-// Closure ownership (shouldReopen)
-// ---------------------------------------------------------------------------
-
-describe("shouldReopen", () => {
- const baseBotState = {
- version: 2,
- active: true,
- kind: "feature",
- closedAt: "2026-07-20T10:00:00Z",
- stateReason: "not_planned",
- };
-
- it("allows reopen when timestamps and state match", () => {
- const issue = { state: "closed", closed_at: "2026-07-20T10:00:00Z", state_reason: "not_planned" };
- assert.equal(shouldReopen(baseBotState, issue, false), true);
- });
-
- it("forbids reopen when timestamp differs", () => {
- const issue = { state: "closed", closed_at: "2026-07-21T12:00:00Z", state_reason: "not_planned" };
- assert.equal(shouldReopen(baseBotState, issue, false), false);
- });
-
- it("forbids reopen when state reason differs", () => {
- const issue = { state: "closed", closed_at: "2026-07-20T10:00:00Z", state_reason: "completed" };
- assert.equal(shouldReopen(baseBotState, issue, false), false);
- });
-
- it("forbids reopen when bot state is inactive", () => {
- const inactive = { ...baseBotState, active: false };
- const issue = { state: "closed", closed_at: "2026-07-20T10:00:00Z", state_reason: "not_planned" };
- assert.equal(shouldReopen(inactive, issue, false), false);
- });
-
- it("returns false when issue is already open", () => {
- const issue = { state: "open", closed_at: null, state_reason: null };
- assert.equal(shouldReopen(baseBotState, issue, false), false);
- });
-
- it("forbids reopen on maintainer override", () => {
- const issue = { state: "closed", closed_at: "2026-07-20T10:00:00Z", state_reason: "not_planned" };
- assert.equal(shouldReopen(baseBotState, issue, true), false);
- });
-
- it("forbids reopen when a human closed the issue (closed_by is not the bot)", () => {
- const issue = {
- state: "closed",
- closed_at: "2026-07-20T10:00:00Z",
- state_reason: "not_planned",
- closed_by: "lidge-jun",
- };
- assert.equal(shouldReopen(baseBotState, issue, false), false);
- });
-
- it("allows reopen when the bot is the recorded closer", () => {
- const issue = {
- state: "closed",
- closed_at: "2026-07-20T10:00:00Z",
- state_reason: "not_planned",
- closed_by: "github-actions[bot]",
- };
- assert.equal(shouldReopen(baseBotState, issue, false), true);
- });
-});
-
-describe("shouldEnforceClosure", () => {
- it("enforces when there is no bot state yet", () => {
- assert.equal(shouldEnforceClosure(null), true);
- });
-
- it("enforces while the bot still owns an active closure", () => {
- assert.equal(
- shouldEnforceClosure({
- version: 2,
- active: true,
- kind: "feature",
- closedAt: "2026-07-20T10:00:00Z",
- stateReason: "not_planned",
- }),
- true,
- );
- });
-
- it("does not enforce after a maintainer override", () => {
- assert.equal(
- shouldEnforceClosure({
- version: 2,
- active: false,
- kind: "feature",
- closedAt: "2026-07-20T10:00:00Z",
- stateReason: "not_planned",
- maintainerOverride: true,
- }),
- false,
- );
- });
-
- it("still enforces after a normal active:false without maintainer override", () => {
- assert.equal(
- shouldEnforceClosure({
- version: 2,
- active: false,
- kind: "feature",
- closedAt: "2026-07-20T10:00:00Z",
- stateReason: "not_planned",
- }),
- true,
- );
- });
-});
-
-// ---------------------------------------------------------------------------
-// Translated / soft-pass / labels
-// ---------------------------------------------------------------------------
-
-describe("translated feature headings and soft-pass", () => {
- it("accepts Goal / Problem + Expected behaviour as a valid feature", () => {
- const body = [
- "### Goal / Problem",
- "Codex App rejects image paste for noVisionModels before the vision sidecar can run.",
- "### Expected behaviour",
- "Catalog should advertise image input when the vision sidecar covers the model.",
- "### Environment",
- "opencodex 2.7.36 on macOS with Codex App.",
- ].join("\n");
- const result = validateIssue({
- title: "[Feature]: Auto-advertise image inputModalities for noVisionModels",
- body,
- labels: [],
- });
- assert.equal(result.kind, "feature");
- assert.equal(result.valid, true, `Expected valid but got: ${result.reasons.join("; ")}`);
- assert.equal(result.softPass, false);
- });
-
- it("soft-passes [Feature]: with rich custom headings outside the alias map", () => {
- const body = [
- "### Concrete user workflow that fails",
- "User pastes an image in Codex App while a text-only routed model is selected and the App blocks upload.",
- "### Why this matters",
- "Vision sidecar is advertised but never reached from the App client path.",
- "### Verification",
- "Same proxy config works end-to-end in Claude Code with the sidecar describing the image.",
- ].join("\n");
- const result = validateIssue({
- title: "[Feature]: Vision sidecar unusable from Codex App",
- body,
- labels: [],
- });
- assert.equal(result.kind, "feature");
- assert.equal(result.softPass, true);
- assert.equal(result.valid, false);
- });
-
- it("soft-passes retitled feature reports that drop the [Feature]: prefix", () => {
- const body = [
- "### Concrete user workflow that fails",
- "User pastes an image in Codex App while a text-only routed model is selected and the App blocks upload.",
- "### Why this matters",
- "Vision sidecar is advertised but never reached from the App client path.",
- "### Verification",
- "Same proxy config works end-to-end in Claude Code with the sidecar describing the image.",
- ].join("\n");
- const result = validateIssue({
- title: "Vision sidecar unusable from Codex App",
- body,
- labels: ["enhancement"],
- storedKind: "feature",
- });
- assert.equal(result.kind, "feature");
- assert.equal(result.softPass, true);
- });
-
- it("soft-passes retitled bug reports with substantial non-English structure (#545)", () => {
- // Maintainer retitle removed `[Bug]:`; Korean structured body has no English
- // Summary/Reproduction headings but is clearly actionable.
- const body = [
- "## 환경",
- "- opencodex 2.7.41 (launchd, port 10100)",
- "- Claude Desktop 3P + Anthropic OAuth (Pro/Max)",
- "- Auto Mode classifier model = `claude-sonnet-5`",
- "",
- "## 증상",
- "Auto Mode classifier requests truncate at outputTokens=64 with max_output_tokens,",
- "then retry the same payload up to 5 times. Dashboard previously showed 502.",
- "",
- "## 재현",
- "1. `ocx login anthropic` and enable Claude Desktop 3P gateway key mode",
- "2. Enable Auto Mode and trigger a tool permission classifier turn",
- "3. Observe five identical 64-token incomplete terminals for one approval",
- "",
- "## 증거",
- "Inbound+outbound correlated captures show max_tokens:64 and stop_sequences preserved.",
- ].join("\n");
- const result = validateIssue({
- title: "Claude Desktop 3P Auto Mode classifier retries after 64-token Anthropic OAuth outputs",
- body,
- labels: ["bug", "provider-compatibility"],
- storedKind: "bug",
- });
- assert.equal(result.kind, "bug");
- assert.equal(result.softPass, true, `Expected soft-pass but got: ${result.reasons.join("; ")}`);
- assert.equal(result.valid, false);
- });
-
- it("does not soft-pass a single arbitrary rich heading (Codex #564)", () => {
- const result = validateIssue({
- title: "Something broke after upgrade",
- body: [
- "## Notes",
- "x".repeat(80),
- ].join("\n"),
- labels: ["bug"],
- storedKind: "bug",
- });
- assert.equal(result.kind, "bug");
- assert.equal(result.softPass, false);
- assert.equal(result.valid, false);
- assert.match(result.reasons.join(" "), /Summary and Reproduction are empty/);
- });
-
- it("does not soft-pass provider reports that only fill mapped metadata headings", () => {
- const result = validateIssue({
- title: "Provider X fails on Responses",
- body: [
- "### Provider or upstream service",
- "custom-openai-compatible gateway hosted on our internal mesh",
- "### OpenCodex version",
- "2.7.41",
- "### Endpoint or capability",
- "`POST /v1/responses` with streaming tool calls",
- "## Extra notes",
- "We see intermittent 502s after rotating the upstream API key for this gateway.",
- ].join("\n"),
- labels: ["provider-compatibility"],
- storedKind: "provider-compatibility",
- });
- assert.equal(result.kind, "provider-compatibility");
- assert.equal(result.softPass, false);
- assert.equal(result.valid, false);
- assert.match(result.reasons.join(" "), /current behaviour|expected behaviour/i);
- });
-
- it("still rejects empty [Feature]: bodies", () => {
- const result = validateIssue({
- title: "[Feature]: do something cool",
- body: "please add this",
- labels: [],
- });
- assert.equal(result.kind, "feature");
- assert.equal(result.valid, false);
- assert.equal(result.softPass, false);
- });
-
- it("does not treat a title containing problem as a bug", () => {
- assert.equal(
- detectIssueKind({
- title: "Problem with documentation wording",
- body: "The docs are confusing about install.",
- labels: [],
- }),
- null,
- );
- });
-
- it("does not soft-pass long unstructured bodies without headings", () => {
- const result = validateIssue({
- title: "[Feature]: please add thing",
- body: "x".repeat(250),
- labels: [],
- });
- assert.equal(result.kind, "feature");
- assert.equal(result.softPass, false);
- assert.equal(result.valid, false);
- });
-
- it("does not classify Expected behaviour + Example as feature without a feature hint", () => {
- assert.equal(
- detectIssueKind({
- title: "Something broke in the proxy",
- body: [
- "### Expected behaviour",
- "Proxy should return 200.",
- "### Example",
- "curl localhost:10100/v1/responses",
- ].join("\n"),
- labels: [],
- }),
- null,
- );
- });
-
- it("classifies alias headings as feature when a goal heading is present", () => {
- assert.equal(
- detectIssueKind({
- title: "Advertise image input for sidecar models",
- body: [
- "### Goal / Problem",
- "App blocks images before the sidecar runs.",
- "### Expected behaviour",
- "Catalog should advertise image input.",
- ].join("\n"),
- labels: [],
- }),
- "feature",
- );
- });
-
- it("lets a strong bug form override a stale stored feature kind", () => {
- const result = validateIssue({
- title: "Crash on start",
- body: [
- "### Client or integration",
- "Codex CLI",
- "### Summary",
- "Proxy segfaults on ARM64 when streaming is enabled.",
- "### Reproduction",
- "ocx start on Raspberry Pi 4, send any streaming request.",
- "### Version",
- "2.7.36",
- "### Operating system",
- "Linux",
- ].join("\n"),
- labels: ["bug"],
- storedKind: "feature",
- });
- assert.equal(result.kind, "bug");
- assert.equal(result.valid, true, `Expected valid bug but got: ${result.reasons.join("; ")}`);
- });
-
- it("accepts US spelling Expected behavior as a behaviour alias", () => {
- const result = validateIssue({
- title: "[Feature]: Auto-advertise image inputModalities",
- body: [
- "### Goal / Problem",
- "App blocks images before the vision sidecar can run.",
- "### Expected behavior",
- "Catalog should advertise image input when the sidecar covers the model.",
- ].join("\n"),
- labels: [],
- });
- assert.equal(result.kind, "feature");
- assert.equal(result.valid, true, `Expected valid but got: ${result.reasons.join("; ")}`);
- });
-
- it("does not treat enhancement + non-goal aliases as a feature detect hit", () => {
- assert.equal(
- detectIssueKind({
- title: "Something odd in the proxy",
- body: [
- "### Current limitation",
- "No fallback provider today for upstream 5xx responses.",
- "### Expected behaviour",
- "Auto failover to a backup provider.",
- ].join("\n"),
- labels: ["enhancement"],
- }),
- null,
- );
- });
-
- it("does not let a weak title-prefix detection override stored documentation kind", () => {
- assert.equal(
- detectIssueKind({
- title: "[Feature]: rewrite the docs",
- body: "Still working on the write-up.",
- labels: [],
- storedKind: "documentation",
- }),
- "documentation",
- );
- });
-});
-
-describe("labelForKind", () => {
- it("maps kinds to triage labels", () => {
- assert.equal(labelForKind("bug"), "bug");
- assert.equal(labelForKind("feature"), "enhancement");
- assert.equal(labelForKind("documentation"), "documentation");
- assert.equal(labelForKind("provider-compatibility"), "provider-compatibility");
- assert.equal(labelForKind(null), null);
- assert.equal(labelForKind("unknown"), null);
- });
-});
-
-// ---------------------------------------------------------------------------
-// Freeform / non-template bypass (e.g. issue #521)
-// ---------------------------------------------------------------------------
-
-describe("validateIssue - freeform / non-template", () => {
- it("rejects a plain freeform body that previously skipped validation", () => {
- const result = validateIssue({
- title: "How do I configure?",
- body: "Just a random question about setup.",
- labels: [],
- });
- assert.equal(result.kind, null);
- assert.equal(result.valid, false);
- assert.equal(result.softPass, false);
- assert.ok(result.reasons.some((r) => /recognized issue template/i.test(r)));
- assert.ok(result.guidance.some((g) => /Bug report|Feature request/i.test(g)));
- });
-
- it("rejects a #521-shaped Description/Reproduction/Log entry body with a clear message", () => {
- const body = [
- "### Description",
- "Proxy returns 502 when streaming is enabled on Windows.",
- "### Reproduction",
- "1. ocx start",
- "2. Send a streaming request",
- "3. Observe 502",
- "### Log entry",
- "```",
- "upstream connect error or disconnect/reset before headers",
- "```",
- ].join("\n");
- assert.equal(
- detectIssueKind({ title: "Proxy 502 on streaming", body, labels: [] }),
- null,
- "near-miss headings must not silently classify as a structured bug",
- );
- assert.equal(looksLikeUntemplatedBugReport({ title: "Proxy 502 on streaming", body }), true);
-
- const result = validateIssue({
- title: "Proxy 502 on streaming",
- body,
- labels: [],
- });
- assert.equal(result.kind, null);
- assert.equal(result.valid, false);
- assert.ok(
- result.reasons.some((r) => /bug report/i.test(r) && /template/i.test(r)),
- `Expected bug-template reason, got: ${result.reasons.join("; ")}`,
- );
- assert.ok(
- result.guidance.some((g) => /Client or integration|Summary|Reproduction/i.test(g)),
- `Expected template-heading guidance, got: ${result.guidance.join("; ")}`,
- );
- });
-
- it("still detects and validates a real structured bug as before", () => {
- const body = [
- "### Client or integration",
- "Codex CLI",
- "### Summary",
- "Proxy segfaults on ARM64 when streaming is enabled.",
- "### Reproduction",
- "ocx start on Raspberry Pi 4, send any streaming request.",
- "### Version",
- "2.7.30",
- "### Operating system",
- "Debian 12 aarch64",
- ].join("\n");
- const result = validateIssue({
- title: "Segfault on ARM64 streaming",
- body,
- labels: ["bug"],
- });
- assert.equal(result.kind, "bug");
- assert.equal(result.valid, true);
- });
-
- it("does not treat Summary+Reproduction alone as a bug without prefix or label", () => {
- // Existing anti-false-positive rule; freeform gate still fails these as untemplated.
- const body = [
- "### Summary",
- "Something went wrong in the proxy.",
- "### Reproduction",
- "Run ocx start.",
- ].join("\n");
- assert.equal(detectIssueKind({ title: "Something went wrong", body, labels: [] }), null);
- const result = validateIssue({ title: "Something went wrong", body, labels: [] });
- assert.equal(result.kind, null);
- assert.equal(result.valid, false);
- });
-
- it("keeps label-backed storedKind validation for enhancement freeform", () => {
- // Workflow passes storedKind from the enhancement label; empty feature form still fails.
- const result = validateIssue({
- title: "How do I configure?",
- body: "Just a random question about setup.",
- labels: ["enhancement"],
- storedKind: "feature",
- });
- assert.equal(result.kind, "feature");
- assert.equal(result.valid, false);
- assert.ok(result.reasons.some((r) => /missing or empty/i.test(r)));
- });
-});
-
-// ---------------------------------------------------------------------------
-// workflow_dispatch guards
-// ---------------------------------------------------------------------------
-
-describe("rejectsWorkflowDispatchPullRequest", () => {
- it("rejects pull request numbers on workflow_dispatch", () => {
- assert.equal(
- rejectsWorkflowDispatchPullRequest({ pull_request: {} }, 423, "workflow_dispatch"),
- "#423 is a pull request. This workflow only accepts issue numbers.",
- );
- });
-
- it("allows issues and non-dispatch events", () => {
- assert.equal(rejectsWorkflowDispatchPullRequest({ pull_request: {} }, 423, "issues"), null);
- assert.equal(rejectsWorkflowDispatchPullRequest({}, 42, "workflow_dispatch"), null);
- });
-});
-
-describe("rejectsWorkflowDispatchNonDefaultBranch", () => {
- it("rejects workflow_dispatch runs that are not on the default branch", () => {
- assert.equal(
- rejectsWorkflowDispatchNonDefaultBranch(
- "workflow_dispatch",
- "refs/heads/fix/issue-quality-low-effort-reports",
- "main",
- ),
- "workflow_dispatch must run from the default branch (main); selected ref was refs/heads/fix/issue-quality-low-effort-reports.",
- );
- });
-
- it("allows default-branch dispatches and normal issue events", () => {
- assert.equal(
- rejectsWorkflowDispatchNonDefaultBranch("workflow_dispatch", "refs/heads/main", "main"),
- null,
- );
- assert.equal(
- rejectsWorkflowDispatchNonDefaultBranch(
- "issues",
- "refs/heads/fix/issue-quality-low-effort-reports",
- "main",
- ),
- null,
- );
- });
-});
-
-// ---------------------------------------------------------------------------
-// Orthogonal area labels
-// ---------------------------------------------------------------------------
-
-describe("mapAreaFieldToLabels", () => {
- it("maps canonical Area dropdown values", () => {
- assert.deepEqual(mapAreaFieldToLabels("CLI"), ["cli"]);
- assert.deepEqual(mapAreaFieldToLabels("Proxy and routing"), ["proxy"]);
- assert.deepEqual(mapAreaFieldToLabels("Dashboard"), ["gui"]);
- assert.deepEqual(mapAreaFieldToLabels("Provider adapter"), ["provider"]);
- assert.deepEqual(mapAreaFieldToLabels("Provider adapters"), ["provider"]);
- assert.deepEqual(mapAreaFieldToLabels("Authentication and account pool"), ["account-pool"]);
- assert.deepEqual(mapAreaFieldToLabels("Catalog / models"), ["catalog"]);
- assert.deepEqual(mapAreaFieldToLabels("Streaming"), ["streaming"]);
- assert.deepEqual(mapAreaFieldToLabels("Tools / MCP / web search"), ["tools"]);
- assert.deepEqual(mapAreaFieldToLabels("Installation or packaging"), ["install"]);
- assert.deepEqual(mapAreaFieldToLabels("Service lifecycle"), ["service"]);
- assert.deepEqual(mapAreaFieldToLabels("Platform (Windows / macOS / Linux)"), ["platform"]);
- assert.deepEqual(mapAreaFieldToLabels("Documentation"), []);
- });
-
- it("maps legacy Service lifecycle wording and ignores Other / Multiple areas", () => {
- assert.deepEqual(mapAreaFieldToLabels("Service lifecycle (config injection)"), ["service"]);
- assert.deepEqual(mapAreaFieldToLabels("Other"), []);
- assert.deepEqual(mapAreaFieldToLabels("Multiple areas"), []);
- assert.deepEqual(mapAreaFieldToLabels(""), []);
- assert.deepEqual(mapAreaFieldToLabels(null), []);
- });
-
- it("exposes metadata for every non-documentation area label", () => {
- for (const name of Object.keys(AREA_LABELS)) {
- assert.ok(AREA_LABELS[name].color, name);
- assert.ok(AREA_LABELS[name].description, name);
- }
- });
-});
-
-describe("detectAreaLabels", () => {
- it("applies Area mapping plus orthogonal heuristics", () => {
- const labels = detectAreaLabels({
- title: "Pool failover stalls on SSE without terminal frame",
- body: [
- "### Area",
- "Authentication and account pool",
- "### Summary",
- "Account pool failover waits forever when the upstream SSE stream ends without a terminal frame.",
- ].join("\n"),
- labels: ["bug"],
- });
- assert.ok(labels.includes("account-pool"));
- assert.ok(labels.includes("streaming"));
- });
-
- it("adds provider for provider-compatibility form and label", () => {
- const fromLabel = detectAreaLabels({
- title: "AgentRouter Anthropic streams can end without terminal SSE frames",
- body: "### Summary\nStream ends early.",
- labels: ["provider-compatibility"],
- });
- assert.ok(fromLabel.includes("provider"));
- assert.ok(fromLabel.includes("streaming"));
-
- const fromHeading = detectAreaLabels({
- title: "Custom relay rejects tool_calls",
- body: [
- "### Provider or upstream service",
- "Volcengine Ark",
- "### Current behaviour",
- "tool_calls with empty content return 400.",
- ].join("\n"),
- labels: [],
- });
- assert.ok(fromHeading.includes("provider"));
- assert.ok(fromHeading.includes("tools"));
- });
-
- it("runs heuristics for Multiple areas / Other without inventing per-provider labels", () => {
- const labels = detectAreaLabels({
- title: "Dashboard ACL hardening blocks management API on Windows",
- body: [
- "### Area",
- "Multiple areas",
- "### Summary",
- "Management API fails closed when icacls hardening cannot be verified.",
- ].join("\n"),
- labels: ["bug"],
- });
- assert.ok(labels.includes("gui"), `got ${labels.join(",")}`);
- assert.ok(labels.includes("platform"), `got ${labels.join(",")}`);
- assert.ok(labels.includes("proxy"), `got ${labels.join(",")}`);
- assert.equal(labels.includes("kiro"), false);
- assert.equal(labels.includes("gemini"), false);
- assert.equal(labels.includes("windows"), false);
- });
-
- it("does not map Documentation Area onto the documentation kind label", () => {
- const labels = detectAreaLabels({
- title: "Codex Auth UI/docs conflate usage-based switching",
- body: ["### Area", "Documentation", "### Summary", "Docs misdefine new session."].join("\n"),
- labels: ["enhancement"],
- });
- assert.equal(labels.includes("documentation"), false);
- assert.equal(labels.includes("docs"), false);
- });
-
- it("ignores Operating system metadata for platform heuristics", () => {
- const labels = detectAreaLabels({
- title: "Dashboard shows empty providers tab",
- body: [
- "### Area",
- "Dashboard",
- "### Summary",
- "Providers tab is blank after login.",
- "### Operating system",
- "Windows 11",
- "### Reproduction",
- "1. Open the dashboard",
- ].join("\n"),
- labels: ["bug"],
- });
- assert.ok(labels.includes("gui"));
- assert.equal(labels.includes("platform"), false);
- });
-
- it("uses heuristicBody translation text when Area is Other", () => {
- const labels = detectAreaLabels({
- title: "问题报告",
- body: ["### Area", "Other", "### Summary", "原始描述"].join("\n"),
- heuristicBody: [
- "### Area",
- "Other",
- "### Summary",
- "Account pool failover fails when refresh token is already used.",
- ].join("\n"),
- labels: ["bug"],
- });
- assert.ok(labels.includes("account-pool"), `got ${labels.join(",")}`);
- });
-
- it("matches truncated streaming wording via truncat stem", () => {
- const labels = detectAreaLabels({
- title: "Upstream streaming response truncated mid-turn",
- body: ["### Area", "Other", "### Summary", "The streaming response was truncated."].join("\n"),
- labels: ["bug"],
- });
- assert.ok(labels.includes("streaming"), `got ${labels.join(",")}`);
- });
-});
diff --git a/.github/scripts/issue-translation.cjs b/.github/scripts/issue-translation.cjs
deleted file mode 100644
index c7d546bc23..0000000000
--- a/.github/scripts/issue-translation.cjs
+++ /dev/null
@@ -1,911 +0,0 @@
-"use strict";
-
-const crypto = require("crypto");
-
-const MARKER = "";
-const END_MARKER = "";
-const LEGACY_STATE_RE = /\s*/;
-const CONTROL_MARKER = "";
-const CONTROL_STATE_V2_RE =
- //;
-const CONTROL_STATE_LEGACY_RE =
- //;
-/** Trailing standalone marker (+ optional final whitespace). Never mid-body. */
-const TRAILING_ORPHAN_BODY_STATE_RE =
- /[ \t]*(?:\r?\n)?[ \t]*$/;
-const ISSUE_BODY_MAX = 65536;
-const BOT_LOGIN = "github-actions[bot]";
-const SOURCE_HASH_RE = /^[a-f0-9]{16}$/;
-const ISSUE_SOURCE_KEY = "issue";
-const MAX_SOURCE_HASHES = 64;
-const MAX_RECENT = 32;
-/** Allow small clock skew; far-future timestamps are rejected. */
-const MAX_CLOCK_SKEW_MS = 5 * 60 * 1000;
-
-const DEFAULT_RATE_LIMIT = {
- minIntervalMs: 60_000,
- maxPerHour: 10,
- minSourceChars: 20,
-};
-
-/**
- * Deterministic fingerprint of the original issue source (title + stripped body).
- */
-function hashTranslationSource({ title = "", body = "" } = {}) {
- const payload = [
- "title:",
- String(title || ""),
- "\nbody:\n",
- String(body || ""),
- ].join("");
- return crypto.createHash("sha256").update(payload, "utf8").digest("hex").slice(0, 16);
-}
-
-/**
- * Locate the first generated inline translation block.
- * @returns {{ start: number, end: number } | null}
- */
-function findTranslationBlockRange(text) {
- const markerIdx = String(text || "").indexOf(MARKER);
- if (markerIdx === -1) return null;
-
- let cursor = markerIdx + MARKER.length;
- const afterMarker = String(text).slice(cursor);
- const legacyState = afterMarker.match(/^\s*\s*/);
- if (legacyState) {
- cursor += legacyState.index + legacyState[0].length;
- }
-
- const rest = String(text).slice(cursor);
- const endRel = rest.indexOf(END_MARKER);
- if (endRel !== -1) {
- return { start: markerIdx, end: cursor + endRel + END_MARKER.length };
- }
-
- // Legacy blocks (pre-END_MARKER): fall back to first .
- if (/^\s*/i.test(rest)) {
- const closeRel = rest.search(/<\/details>/i);
- if (closeRel !== -1) {
- return { start: markerIdx, end: cursor + closeRel + "
".length };
- }
- return { start: markerIdx, end: cursor };
- }
-
- if (legacyState) {
- return { start: markerIdx, end: cursor };
- }
-
- return { start: markerIdx, end: markerIdx + MARKER.length };
-}
-
-/**
- * Split an issue body into user prefix/suffix and the generated translation block.
- */
-function splitTranslationBlock(body) {
- const text = String(body || "");
- const range = findTranslationBlockRange(text);
- if (!range) {
- const sourceBody = text.replace(/\s+$/, "");
- return {
- found: false,
- prefix: sourceBody,
- block: "",
- suffix: "",
- sourceBody,
- };
- }
-
- const prefix = text.slice(0, range.start).replace(/\s+$/, "");
- const block = text.slice(range.start, range.end);
- const suffix = text.slice(range.end).replace(/^\s+/, "");
- const sourceBody = suffix
- ? (prefix ? `${prefix}\n\n${suffix}` : suffix).replace(/\s+$/, "")
- : prefix;
-
- return { found: true, prefix, block, suffix, sourceBody };
-}
-
-function stripTranslationBlock(body) {
- return splitTranslationBlock(body).sourceBody;
-}
-
-/** Legacy body-embedded state (ignored for rate limits). */
-function extractTranslationState(body) {
- const match = String(body || "").match(LEGACY_STATE_RE);
- if (!match) return null;
- try {
- const parsed = JSON.parse(match[1]);
- if (!parsed || typeof parsed !== "object") return null;
- return parsed;
- } catch {
- return null;
- }
-}
-
-function scrubDetectedLanguage(value) {
- return (
- String(value || "")
- .replace(/[^\p{L}\p{N}\s\-()]/gu, "")
- .replace(/\s+/g, " ")
- .trim()
- .slice(0, 64) || "non-English"
- );
-}
-
-/**
- * True when the model (or caller) reported English / no translation needed.
- */
-function isEnglishDetectedLanguage(value) {
- const lang = scrubDetectedLanguage(value).toLowerCase();
- return lang === "english" || lang === "en" || lang === "eng";
-}
-
-/**
- * Language written into control-state on the no-translation persist path.
- *
- * Confirmed English only when `sourceComplete` is true (valid parsed
- * `requires_translation: false`). Incomplete AI/parse/action failures always
- * record `unknown` — never retain a language label that could look confirmed.
- */
-function detectedLanguageForControlPersist({ detectedLanguage, sourceComplete } = {}) {
- if (sourceComplete !== true) return "unknown";
- return scrubDetectedLanguage(detectedLanguage || "English");
-}
-
-/**
- * Visible bookkeeping language label for the sticky control comment.
- * Always non-empty so the bot bubble never renders as a blank ghost comment.
- * Missing language is `unknown` — never invent a confirmed English label.
- */
-function bookkeepingLanguageLabel(state) {
- if (state?.detectedLanguage) return scrubDetectedLanguage(state.detectedLanguage);
- return "unknown";
-}
-
-/**
- * Strip obsolete bot-owned body control markers from the legacy trailing
- * storage position only. Markers inside fenced code, quotes, or prose are
- * left untouched. Surrounding author whitespace is preserved byte-for-byte.
- */
-function stripOrphanBodyControlState(body) {
- let text = String(body || "");
- // Only remove exact trailing tokens (legacy bot storage). Repeat in case
- // multiple obsolete markers were appended at EOF.
- while (TRAILING_ORPHAN_BODY_STATE_RE.test(text)) {
- text = text.replace(TRAILING_ORPHAN_BODY_STATE_RE, "");
- }
- return text;
-}
-
-function isValidControlTimestamp(ts, now = Date.now()) {
- return typeof ts === "number"
- && Number.isFinite(ts)
- && ts <= now + MAX_CLOCK_SKEW_MS;
-}
-
-function findAllControlComments(comments) {
- return (Array.isArray(comments) ? comments : []).filter(
- (comment) => comment?.user?.login === BOT_LOGIN && comment?.body?.includes(CONTROL_MARKER),
- );
-}
-
-function encodeControlState(state) {
- return Buffer.from(JSON.stringify(state), "utf8").toString("base64url");
-}
-
-function isValidSourceKey(key) {
- return key === ISSUE_SOURCE_KEY || /^comment:[1-9][0-9]*$/.test(String(key || ""));
-}
-
-/**
- * Per-source completed hashes. Legacy flat `sourceHash` maps only to the issue key.
- */
-function migrateSourceHashes(state) {
- if (!state || typeof state !== "object") return {};
- const out = {};
- if (state.sourceHashes && typeof state.sourceHashes === "object" && !Array.isArray(state.sourceHashes)) {
- for (const [key, value] of Object.entries(state.sourceHashes)) {
- if (isValidSourceKey(key) && typeof value === "string" && SOURCE_HASH_RE.test(value)) {
- out[key] = value;
- }
- }
- return out;
- }
- if (
- typeof state.sourceHash === "string"
- && SOURCE_HASH_RE.test(state.sourceHash)
- && state.sourceHash !== "0000000000000000"
- ) {
- out[ISSUE_SOURCE_KEY] = state.sourceHash;
- }
- return out;
-}
-
-function completedHashFor(state, sourceKey) {
- const key = isValidSourceKey(sourceKey) ? sourceKey : ISSUE_SOURCE_KEY;
- const hashes = migrateSourceHashes(state);
- return hashes[key] || null;
-}
-
-function withCompletedSourceHash(hashes, sourceKey, sourceHash) {
- const next = { ...hashes };
- if (isValidSourceKey(sourceKey) && typeof sourceHash === "string" && SOURCE_HASH_RE.test(sourceHash)) {
- next[sourceKey] = sourceHash;
- }
- const keys = Object.keys(next);
- if (keys.length <= MAX_SOURCE_HASHES) return next;
- // Prefer keeping the issue key; drop oldest-inserted comment keys first.
- const commentKeys = keys.filter((k) => k !== ISSUE_SOURCE_KEY);
- while (Object.keys(next).length > MAX_SOURCE_HASHES && commentKeys.length) {
- delete next[commentKeys.shift()];
- }
- return next;
-}
-
-function validateControlState(parsed, now = Date.now()) {
- if (!parsed || typeof parsed !== "object" || Array.isArray(parsed)) return null;
- if (parsed.v !== 2) return null;
- if (typeof parsed.sourceHash !== "string" || !SOURCE_HASH_RE.test(parsed.sourceHash)) {
- return null;
- }
- if (!isValidControlTimestamp(parsed.attemptedAt, now)) {
- return null;
- }
- if (!Array.isArray(parsed.recent)) return null;
- const recent = parsed.recent
- .filter((ts) => isValidControlTimestamp(ts, now))
- .slice(-MAX_RECENT);
- if (typeof parsed.requiresTranslation !== "boolean") return null;
-
- let detectedLanguage = null;
- if (parsed.detectedLanguage != null) {
- if (typeof parsed.detectedLanguage !== "string") return null;
- detectedLanguage = scrubDetectedLanguage(parsed.detectedLanguage);
- }
-
- return {
- v: 2,
- sourceHash: parsed.sourceHash,
- sourceHashes: migrateSourceHashes(parsed),
- attemptedAt: parsed.attemptedAt,
- recent,
- requiresTranslation: parsed.requiresTranslation,
- detectedLanguage,
- };
-}
-
-function decodeControlState(encoded, now = Date.now()) {
- try {
- const json = Buffer.from(String(encoded || ""), "base64url").toString("utf8");
- return validateControlState(JSON.parse(json), now);
- } catch {
- return null;
- }
-}
-
-/** Legacy JSON-in-HTML-comment state (read-only migration). */
-function parseLegacyControlState(raw, now = Date.now()) {
- try {
- return validateControlState(JSON.parse(raw), now);
- } catch {
- return null;
- }
-}
-
-function parseControlStateFromCommentBody(body, now = Date.now()) {
- const text = String(body || "");
- const v2 = text.match(CONTROL_STATE_V2_RE);
- if (v2) return decodeControlState(v2[1], now);
- const legacy = text.match(CONTROL_STATE_LEGACY_RE);
- if (legacy) return parseLegacyControlState(legacy[1], now);
- return null;
-}
-
-/**
- * Newest github-actions control comment with a valid decoded state.
- * Author-forged comments and far-future poisoned payloads are ignored.
- * Used for *reading* authoritative rate-limit state.
- */
-function findControlComment(comments, now = Date.now()) {
- let best = null;
- let bestState = null;
- for (const comment of findAllControlComments(comments)) {
- const state = parseControlStateFromCommentBody(comment.body, now);
- if (!state) continue;
- if (!bestState || state.attemptedAt >= bestState.attemptedAt) {
- best = comment;
- bestState = state;
- }
- }
- return best;
-}
-
-/**
- * Sticky upsert target: the oldest bot-owned control comment (by id).
- * Prefer updating this in place so the bubble stays near the top of the
- * thread instead of creating a new comment at the bottom after every
- * English classification. Corrupt/unparseable bodies still qualify — we
- * overwrite them — so a bad decode never forces a duplicate create.
- */
-function findStickyControlComment(comments) {
- let sticky = null;
- for (const comment of findAllControlComments(comments)) {
- if (!Number.isSafeInteger(comment?.id) || comment.id <= 0) continue;
- if (!sticky || comment.id < sticky.id) sticky = comment;
- }
- return sticky;
-}
-
-function extractTranslationControlState(comments, now = Date.now()) {
- const newest = findControlComment(comments, now);
- if (!newest) return null;
- return parseControlStateFromCommentBody(newest.body, now);
-}
-
-/**
- * Authoritative control state comes only from verified bot-owned comments.
- * Issue body markers and author comments are never consulted.
- * The optional second argument is ignored (kept for call-site compatibility).
- */
-function resolveControlState(comments, _issueNumber, now = Date.now()) {
- return extractTranslationControlState(comments, now);
-}
-
-/**
- * Always false: control comments always include a visible bookkeeping line
- * so GitHub never renders an HTML-comment-only ghost bubble.
- * Kept as an exported predicate for workflow/tests that assert the contract.
- */
-function shouldOmitVisibleBookkeeping(_state) {
- return false;
-}
-
-function buildTranslationControlComment(state) {
- const safe = validateControlState(state) || {
- v: 2,
- sourceHash: "0000000000000000",
- sourceHashes: {},
- attemptedAt: Date.now(),
- recent: [],
- requiresTranslation: false,
- detectedLanguage: null,
- };
- const encoded = encodeControlState(safe);
- const lang = bookkeepingLanguageLabel(safe);
- return [
- CONTROL_MARKER,
- ``,
- "",
- `Automated translation bookkeeping — detected language: ${lang}.`,
- ].join("\n");
-}
-
-function pruneRecent(recent, now, windowMs = 3_600_000) {
- const cutoff = now - windowMs;
- const maxTs = now + MAX_CLOCK_SKEW_MS;
- return (Array.isArray(recent) ? recent : []).filter(
- (ts) => typeof ts === "number" && Number.isFinite(ts) && ts > cutoff && ts <= maxTs,
- );
-}
-
-function countRecentAttempts(recent, now, windowMs = 3_600_000) {
- return pruneRecent(recent, now, windowMs).length;
-}
-
-/**
- * Merge bounded recent-attempt histories from every valid bot control comment
- * so canonicalisation does not drop hourly-limit evidence.
- */
-function collectMergedRecentFromComments(comments, priorState = null, now = Date.now()) {
- const collected = [];
- if (Array.isArray(priorState?.recent)) collected.push(...priorState.recent);
- for (const comment of findAllControlComments(comments)) {
- const state = parseControlStateFromCommentBody(comment.body, now);
- if (state?.recent) collected.push(...state.recent);
- }
- return [...new Set(pruneRecent(collected, now))].sort((a, b) => a - b).slice(-MAX_RECENT);
-}
-
-/**
- * Record a new attempt. Far-future poisoned prior state is ignored/healed.
- * New attemptedAt always uses wall-clock `now` so skew cannot stick forever.
- *
- * Completed hashes are stored per `sourceKey` (`issue` vs `comment:",
- "",
- "
",
- END_MARKER,
- "",
- ].join("\n");
-}
-
-function maxTranslationChars(sourceBody) {
- const base = stripTranslationBlock(sourceBody);
- const emptyBlock = buildTranslationBlock("");
- return Math.max(0, ISSUE_BODY_MAX - base.length - emptyBlock.length - 64);
-}
-
-function fitTranslationBody(sourceBody, translatedBody) {
- let safe = sanitizeTranslationBody(translatedBody);
- const maxChars = maxTranslationChars(sourceBody);
- if (safe.length <= maxChars) return safe;
- const note = "\n\n_(Translation truncated to fit GitHub issue body limit.)_";
- const budget = Math.max(0, maxChars - note.length);
- return safe.slice(0, budget).trimEnd() + note;
-}
-
-function appendTranslationBlock(sourceBody, translatedBody) {
- const base = stripTranslationBlock(sourceBody);
- const fitted = fitTranslationBody(base, translatedBody);
- const next = base + buildTranslationBlock(fitted);
- if (next.length > ISSUE_BODY_MAX) {
- throw new Error("Translated issue body exceeds GitHub limit after truncation.");
- }
- return next;
-}
-
-module.exports = {
- MARKER,
- END_MARKER,
- CONTROL_MARKER,
- BOT_LOGIN,
- ISSUE_BODY_MAX,
- ISSUE_SOURCE_KEY,
- DEFAULT_RATE_LIMIT,
- MAX_CLOCK_SKEW_MS,
- hashTranslationSource,
- findTranslationBlockRange,
- splitTranslationBlock,
- stripTranslationBlock,
- extractTranslationState,
- findControlComment,
- findStickyControlComment,
- findAllControlComments,
- deleteVerifiedControlComments,
- extractTranslationControlState,
- resolveControlState,
- encodeControlState,
- decodeControlState,
- validateControlState,
- isValidControlTimestamp,
- buildTranslationControlComment,
- mergeTranslationAttemptState,
- collectMergedRecentFromComments,
- upsertTranslationControlComment,
- persistTranslationControlState,
- shouldOmitVisibleBookkeeping,
- isPreparedSourceStillCurrent,
- commentSourceTitle,
- shouldSkipCommentTranslation,
- shouldTranslateComment,
- buildTranslatedCommentBody,
- missingRequiredTranslationFields,
- shouldTranslate,
- completedHashFor,
- migrateSourceHashes,
- sanitizeTranslationBody,
- scrubDetectedLanguage,
- isEnglishDetectedLanguage,
- detectedLanguageForControlPersist,
- bookkeepingLanguageLabel,
- stripOrphanBodyControlState,
- buildTranslationBlock,
- maxTranslationChars,
- fitTranslationBody,
- appendTranslationBlock,
- pruneRecent,
- countRecentAttempts,
-};
diff --git a/.github/scripts/issue-translation.test.cjs b/.github/scripts/issue-translation.test.cjs
deleted file mode 100644
index f6c754fb9e..0000000000
--- a/.github/scripts/issue-translation.test.cjs
+++ /dev/null
@@ -1,1688 +0,0 @@
-"use strict";
-
-const { describe, it } = require("node:test");
-const assert = require("node:assert/strict");
-const {
- MARKER,
- END_MARKER,
- CONTROL_MARKER,
- BOT_LOGIN,
- ISSUE_BODY_MAX,
- DEFAULT_RATE_LIMIT,
- hashTranslationSource,
- splitTranslationBlock,
- stripTranslationBlock,
- appendTranslationBlock,
- buildTranslationBlock,
- buildTranslationControlComment,
- findControlComment,
- findStickyControlComment,
- extractTranslationControlState,
- resolveControlState,
- encodeControlState,
- decodeControlState,
- validateControlState,
- mergeTranslationAttemptState,
- persistTranslationControlState,
- upsertTranslationControlComment,
- isPreparedSourceStillCurrent,
- shouldTranslate,
- commentSourceTitle,
- shouldSkipCommentTranslation,
- shouldTranslateComment,
- buildTranslatedCommentBody,
- missingRequiredTranslationFields,
- sanitizeTranslationBody,
- scrubDetectedLanguage,
- isEnglishDetectedLanguage,
- detectedLanguageForControlPersist,
- bookkeepingLanguageLabel,
- stripOrphanBodyControlState,
- fitTranslationBody,
- shouldOmitVisibleBookkeeping,
- deleteVerifiedControlComments,
- MAX_CLOCK_SKEW_MS,
- collectMergedRecentFromComments,
- isValidControlTimestamp,
- pruneRecent,
- completedHashFor,
-} = require("./issue-translation.cjs");
-
-const HASH_A = "aaaaaaaaaaaaaaaa";
-const HASH_B = "bbbbbbbbbbbbbbbb";
-const ORPHAN_MARKER = ``;
-
-const SOURCE = [
- "### Was funktioniert nicht?",
- "Der Proxy startet nicht nach dem Update.",
- "### Schritte",
- "1. ocx start",
- "2. Fehler in der Konsole",
-].join("\n");
-
-function botComment(body, id = 1) {
- return { id, user: { login: BOT_LOGIN }, body };
-}
-
-function mockGithub(handlers = {}) {
- const calls = [];
- const github = {
- paginate: async (_fn, args) => {
- calls.push(["paginate", args]);
- return handlers.listComments || [];
- },
- rest: {
- issues: {
- listComments: async (args) => {
- calls.push(["list", args]);
- return { data: handlers.listComments || [] };
- },
- createComment: async (args) => {
- calls.push(["create", args]);
- if (handlers.create) return handlers.create(args);
- return { data: { id: handlers.nextId || 99, body: args.body, user: { login: BOT_LOGIN } } };
- },
- updateComment: async (args) => {
- calls.push(["update", args]);
- if (handlers.update) return handlers.update(args);
- return { data: { id: args.comment_id, body: args.body, user: { login: BOT_LOGIN } } };
- },
- deleteComment: async (args) => {
- calls.push(["delete", args]);
- if (handlers.delete) return handlers.delete(args);
- return {};
- },
- update: async (args) => {
- calls.push(["issueUpdate", args]);
- if (handlers.issueUpdate) return handlers.issueUpdate(args);
- return { data: args };
- },
- },
- },
- };
- return { github, calls };
-}
-
-describe("hashTranslationSource", () => {
- it("changes when only the title changes", () => {
- const bodyOnly = hashTranslationSource({ body: SOURCE });
- const withTitle = hashTranslationSource({ title: "Neuer Titel", body: SOURCE });
- assert.notEqual(bodyOnly, withTitle);
- });
-
- it("changes when only the body changes", () => {
- const base = hashTranslationSource({ title: "Titel", body: SOURCE });
- const edited = hashTranslationSource({ title: "Titel", body: SOURCE + "\nmehr" });
- assert.notEqual(base, edited);
- });
-
- it("is stable for unchanged title and body", () => {
- const a = hashTranslationSource({ title: "T", body: SOURCE });
- const b = hashTranslationSource({ title: "T", body: SOURCE });
- assert.equal(a, b);
- });
-});
-
-describe("splitTranslationBlock", () => {
- it("handles generated block at end", () => {
- const translated = appendTranslationBlock(SOURCE, "English");
- const split = splitTranslationBlock(translated);
- assert.equal(split.sourceBody, SOURCE);
- assert.ok(split.block.includes(MARKER));
- });
-
- it("preserves suffix after generated block", () => {
- const suffix = "Extra logs added by contributor.";
- const translated = appendTranslationBlock(SOURCE, "English") + "\n\n" + suffix;
- const split = splitTranslationBlock(translated);
- assert.equal(split.suffix, suffix);
- assert.equal(split.sourceBody, `${SOURCE}\n\n${suffix}`);
- });
-
- it("preserves prefix before generated block", () => {
- const prefix = "Preface";
- const translated = prefix + "\n\n" + appendTranslationBlock(SOURCE, "English").trimStart();
- const split = splitTranslationBlock(translated);
- assert.equal(split.prefix, `${prefix}\n\n${SOURCE}`);
- assert.equal(split.sourceBody, `${prefix}\n\n${SOURCE}`);
- });
-
- it("does not remove contributor-authored details elsewhere", () => {
- const contributorDetails = [
- "Translated Message
", - "", - safeBody, - "", - "My notes
", - "private repro notes", - "\n",
- "still translation",
- ].join("\n");
- const body = appendTranslationBlock(SOURCE, nested) + "\n\nuser suffix";
- assert.ok(body.includes(END_MARKER));
- const split = splitTranslationBlock(body);
- assert.equal(split.suffix, "user suffix");
- assert.equal(split.sourceBody, `${SOURCE}\n\nuser suffix`);
- assert.ok(split.block.includes("inner"));
- assert.ok(split.block.includes("still translation"));
- });
-
- it("removes multi-level nested details only inside the generated block", () => {
- const before = "";
- const after = "";
- const nested = [
- "top",
- "",
- "",
- "tail",
- ].join("\n");
- const body = [
- before,
- "",
- appendTranslationBlock(SOURCE, nested).trimStart(),
- "",
- after,
- ].join("\n");
- const stripped = stripTranslationBlock(body);
- assert.ok(stripped.includes("before-log"));
- assert.ok(stripped.includes("after-log"));
- assert.ok(!stripped.includes("deep"));
- assert.ok(!stripped.includes("top"));
- assert.ok(!stripped.includes(MARKER));
- assert.ok(!stripped.includes(END_MARKER));
- });
-
- it("migrates legacy blocks that close on first details end", () => {
- const legacy = [
- SOURCE,
- "",
- MARKER,
- "",
- "
Translated Message
\n\noops`; - const split = splitTranslationBlock(malformed); - assert.ok(split.sourceBody.includes("oops")); - assert.ok(split.sourceBody.includes(SOURCE)); - }); - - it("preserves nested details inside translated content via end marker", () => { - const nested = [ - "Outer translation", - "logs
", - "inner", - "before
\nbefore-log\nafter
\nafter-log\nL1
", - "L2
", - "deep", - "",
- "",
- "
",
- "",
- "user after",
- ].join("\n");
- const split = splitTranslationBlock(legacy);
- assert.equal(split.suffix, "user after");
- assert.equal(split.sourceBody, `${SOURCE}\n\nuser after`);
- const migrated = appendTranslationBlock(split.sourceBody, "fresh");
- assert.ok(migrated.includes(END_MARKER));
- assert.equal((migrated.match(new RegExp(MARKER, "g")) || []).length, 1);
- assert.ok(migrated.includes("user after"));
- });
-
- it("does not greedily erase across duplicate end markers", () => {
- const block = buildTranslationBlock("one");
- const forged = `${SOURCE}${block}\n${END_MARKER}\nkeep me`;
- const split = splitTranslationBlock(forged);
- assert.ok(split.sourceBody.includes("keep me"));
- assert.ok(!split.block.includes("keep me"));
- assert.equal(split.suffix, `${END_MARKER}\nkeep me`);
- });
-});
-
-describe("isPreparedSourceStillCurrent", () => {
- it("detects body changes between prepare and apply", () => {
- const prepared = hashTranslationSource({ title: "T", body: SOURCE });
- assert.equal(
- isPreparedSourceStillCurrent({
- preparedHash: prepared,
- liveTitle: "T",
- liveBody: SOURCE + "\nnew logs",
- }),
- false,
- );
- });
-
- it("detects title changes between prepare and apply", () => {
- const prepared = hashTranslationSource({ title: "Alt", body: SOURCE });
- assert.equal(
- isPreparedSourceStillCurrent({
- preparedHash: prepared,
- liveTitle: "Neu",
- liveBody: SOURCE,
- }),
- false,
- );
- });
-
- it("allows apply when only generated translation changed", () => {
- const prepared = hashTranslationSource({ title: "T", body: SOURCE });
- const withBlock = appendTranslationBlock(SOURCE, "English");
- assert.equal(
- isPreparedSourceStillCurrent({
- preparedHash: prepared,
- liveTitle: "T",
- liveBody: stripTranslationBlock(withBlock),
- }),
- true,
- );
- });
-});
-
-describe("bot-owned control state", () => {
- it("always includes visible bookkeeping, including English", () => {
- const german = buildTranslationControlComment({
- v: 2,
- sourceHash: HASH_A,
- attemptedAt: 1,
- recent: [1],
- requiresTranslation: true,
- detectedLanguage: "German",
- });
- assert.match(german, /Automated translation bookkeeping — detected language: German/);
- assert.equal(shouldOmitVisibleBookkeeping({
- requiresTranslation: true,
- detectedLanguage: "German",
- }), false);
-
- const english = buildTranslationControlComment({
- v: 2,
- sourceHash: HASH_A,
- attemptedAt: 1,
- recent: [1],
- requiresTranslation: false,
- detectedLanguage: "English",
- });
- assert.match(english, /Automated translation bookkeeping — detected language: English/);
- assert.equal(shouldOmitVisibleBookkeeping({
- requiresTranslation: false,
- detectedLanguage: "English",
- }), false);
- });
-
- it("incomplete AI/parse failures bookkeep as unknown, never false-English", async () => {
- assert.equal(
- detectedLanguageForControlPersist({ detectedLanguage: "", sourceComplete: false }),
- "unknown",
- );
- assert.equal(
- detectedLanguageForControlPersist({ detectedLanguage: undefined, sourceComplete: false }),
- "unknown",
- );
- assert.equal(
- detectedLanguageForControlPersist({ detectedLanguage: "unknown", sourceComplete: false }),
- "unknown",
- );
- assert.equal(
- detectedLanguageForControlPersist({ detectedLanguage: "English", sourceComplete: false }),
- "unknown",
- );
- assert.equal(
- detectedLanguageForControlPersist({ detectedLanguage: "", sourceComplete: true }),
- "English",
- );
- assert.equal(
- detectedLanguageForControlPersist({ detectedLanguage: "English", sourceComplete: true }),
- "English",
- );
- assert.equal(bookkeepingLanguageLabel({ requiresTranslation: false, detectedLanguage: null }), "unknown");
- assert.equal(bookkeepingLanguageLabel({ requiresTranslation: false, detectedLanguage: "English" }), "English");
-
- const { github, calls } = mockGithub({ nextId: 77 });
- const result = await persistTranslationControlState({
- github,
- owner: "o",
- repo: "r",
- issue_number: 9,
- comments: [],
- attempt: {
- sourceHash: HASH_A,
- requiresTranslation: false,
- detectedLanguage: detectedLanguageForControlPersist({
- detectedLanguage: "",
- sourceComplete: false,
- }),
- sourceComplete: false,
- },
- now: 100,
- });
- assert.equal(result.state.sourceHash, "0000000000000000");
- assert.equal(result.state.detectedLanguage, "unknown");
- assert.match(calls[0][1].body, /detected language: unknown/);
- assert.doesNotMatch(calls[0][1].body, /detected language: English/);
- // Attempt counted (recent) but source stays retryable.
- assert.deepEqual(result.state.recent, [100]);
- assert.equal(completedHashFor(result.state, "issue"), null);
- });
-
- it("English creates a bot comment with visible English bookkeeping", async () => {
- const { github, calls } = mockGithub({ nextId: 42 });
- const result = await persistTranslationControlState({
- github,
- owner: "o",
- repo: "r",
- issue_number: 7,
- comments: [],
- attempt: {
- sourceHash: HASH_A,
- requiresTranslation: false,
- detectedLanguage: "English",
- sourceComplete: true,
- },
- now: 100,
- });
- assert.equal(result.storage, "comment");
- assert.equal(result.markerOnly, false);
- assert.equal(result.comment.id, 42);
- assert.deepEqual(calls.map((c) => c[0]), ["create"]);
- assert.match(calls[0][1].body, new RegExp(CONTROL_MARKER));
- assert.match(calls[0][1].body, /Automated translation bookkeeping — detected language: English/);
- assert.equal(extractTranslationControlState([botComment(calls[0][1].body, 42)]).sourceHash, HASH_A);
- });
-
- it("English updates the canonical bot comment instead of creating duplicates", async () => {
- const priorBody = buildTranslationControlComment({
- v: 2,
- sourceHash: HASH_B,
- attemptedAt: 1,
- recent: [1],
- requiresTranslation: false,
- detectedLanguage: "English",
- });
- const prior = botComment(priorBody, 11);
- const { github, calls } = mockGithub();
- const result = await persistTranslationControlState({
- github,
- owner: "o",
- repo: "r",
- issue_number: 7,
- comments: [prior],
- priorState: extractTranslationControlState([prior]),
- attempt: {
- sourceHash: HASH_A,
- requiresTranslation: false,
- detectedLanguage: "English",
- sourceComplete: true,
- },
- now: 200,
- });
- assert.equal(result.comment.id, 11);
- assert.deepEqual(calls.map((c) => c[0]), ["update"]);
- assert.equal(calls[0][1].comment_id, 11);
- assert.match(calls[0][1].body, /Automated translation bookkeeping — detected language: English/);
- });
-
- it("updates the oldest sticky control comment even when its state is corrupt", async () => {
- const corrupt = botComment(
- `${CONTROL_MARKER}\n`,
- 3,
- );
- const validNewer = botComment(buildTranslationControlComment({
- v: 2,
- sourceHash: HASH_B,
- attemptedAt: 50,
- recent: [50],
- requiresTranslation: false,
- detectedLanguage: "English",
- }), 9);
- const { github, calls } = mockGithub();
- const result = await persistTranslationControlState({
- github,
- owner: "o",
- repo: "r",
- issue_number: 7,
- comments: [corrupt, validNewer],
- priorState: extractTranslationControlState([corrupt, validNewer]),
- attempt: {
- sourceHash: HASH_A,
- requiresTranslation: false,
- detectedLanguage: "English",
- sourceComplete: true,
- },
- now: 100,
- });
- assert.equal(findStickyControlComment([corrupt, validNewer]).id, 3);
- assert.equal(result.comment.id, 3);
- assert.deepEqual(calls.map((c) => c[0]), ["update", "delete"]);
- assert.equal(calls[0][1].comment_id, 3);
- assert.match(calls[0][1].body, /detected language: English/);
- assert.equal(calls[1][1].comment_id, 9);
- });
-
- it("non-English persist writes or updates a visible bot-owned comment", async () => {
- const { github, calls } = mockGithub({ nextId: 50 });
- const created = await persistTranslationControlState({
- github,
- owner: "o",
- repo: "r",
- issue_number: 11,
- comments: [],
- attempt: {
- sourceHash: HASH_A,
- requiresTranslation: true,
- detectedLanguage: "German",
- sourceComplete: true,
- },
- now: 100,
- });
- assert.equal(created.storage, "comment");
- assert.equal(created.markerOnly, false);
- assert.equal(created.comment.id, 50);
- assert.match(calls[0][1].body, /detected language: German/);
-
- const prior = botComment(calls[0][1].body, 50);
- calls.length = 0;
- const updated = await persistTranslationControlState({
- github,
- owner: "o",
- repo: "r",
- issue_number: 11,
- comments: [prior],
- priorState: extractTranslationControlState([prior]),
- attempt: {
- sourceHash: HASH_B,
- requiresTranslation: true,
- detectedLanguage: "French",
- sourceComplete: true,
- },
- now: 200,
- });
- assert.equal(updated.storage, "comment");
- assert.deepEqual(calls.map((c) => c[0]), ["update"]);
- assert.equal(calls[0][1].comment_id, 50);
- assert.match(calls[0][1].body, /detected language: French/);
- });
-
- it("ignores author comments containing the control marker", () => {
- const forged = {
- id: 9,
- user: { login: "attacker" },
- body: buildTranslationControlComment({
- v: 2,
- sourceHash: HASH_B,
- attemptedAt: 99,
- recent: [99],
- requiresTranslation: false,
- detectedLanguage: "English",
- }),
- };
- const bot = botComment(buildTranslationControlComment({
- v: 2,
- sourceHash: HASH_A,
- attemptedAt: 1,
- recent: [1],
- requiresTranslation: true,
- detectedLanguage: "German",
- }), 10);
- assert.equal(resolveControlState([forged, bot]).sourceHash, HASH_A);
- assert.equal(findControlComment([forged, bot]).id, 10);
- });
-
- it("treats corrupt control state as missing", () => {
- const comments = [
- botComment(`${CONTROL_MARKER}\n`),
- ];
- assert.equal(extractTranslationControlState(comments), null);
- assert.equal(resolveControlState(comments), null);
- });
-
- it("never treats the issue body as authoritative control state", () => {
- const orphan = `${SOURCE}\n\n\n`;
- assert.equal(resolveControlState([], 1), null);
- assert.equal(extractTranslationControlState([]), null);
- assert.equal(stripOrphanBodyControlState(orphan).includes("control-state-v2:"), false);
- });
-
- it("failed sticky update preserves existing control comments and does not delete", async () => {
- // Corrupt sticky comment is still the upsert target; update failure must
- // not cascade into deleting it (or any sibling) as "redundant."
- const stale = botComment(
- `${CONTROL_MARKER}\n`,
- 5,
- );
- const { github, calls } = mockGithub({
- update: async () => {
- throw new Error("API update failed");
- },
- });
- await assert.rejects(
- () => persistTranslationControlState({
- github,
- owner: "o",
- repo: "r",
- issue_number: 1,
- comments: [stale],
- attempt: {
- sourceHash: HASH_A,
- requiresTranslation: false,
- detectedLanguage: "English",
- sourceComplete: true,
- },
- }),
- /persistence failed/,
- );
- assert.deepEqual(calls.map((c) => c[0]), ["update"]);
- assert.equal(calls[0][1].comment_id, 5);
- assert.ok(!calls.some((c) => c[0] === "delete"));
- assert.equal(findControlComment([stale]), null);
- assert.equal(findStickyControlComment([stale]).id, 5);
- });
-
- it("re-fetches comments when none are supplied and still verifies authorship", async () => {
- const forged = {
- id: 9,
- user: { login: "attacker" },
- body: `please ignore ${CONTROL_MARKER} forged`,
- };
- const bot = botComment(buildTranslationControlComment({
- v: 2,
- sourceHash: HASH_A,
- attemptedAt: 1,
- recent: [1],
- requiresTranslation: true,
- detectedLanguage: "German",
- }), 10);
- const { github, calls } = mockGithub({ listComments: [forged, bot] });
- const result = await deleteVerifiedControlComments({
- github,
- owner: "o",
- repo: "r",
- issue_number: 1,
- commentIds: [9, 10],
- });
- assert.deepEqual(result.deleted, [10]);
- assert.deepEqual(result.skipped, [9]);
- assert.ok(calls.some((c) => c[0] === "paginate"));
- });
-
- it("failed comment update preserves the previous comment", async () => {
- const priorBody = buildTranslationControlComment({
- v: 2,
- sourceHash: HASH_B,
- attemptedAt: 1,
- recent: [1],
- requiresTranslation: false,
- detectedLanguage: "English",
- });
- const prior = botComment(priorBody, 8);
- const { github, calls } = mockGithub({
- update: async () => {
- throw new Error("API update failed");
- },
- });
- await assert.rejects(
- () => persistTranslationControlState({
- github,
- owner: "o",
- repo: "r",
- issue_number: 1,
- comments: [prior],
- priorState: extractTranslationControlState([prior]),
- attempt: {
- sourceHash: HASH_A,
- requiresTranslation: false,
- detectedLanguage: "English",
- sourceComplete: true,
- },
- now: 200,
- }),
- /persistence failed/,
- );
- assert.deepEqual(calls.map((c) => c[0]), ["update"]);
- assert.ok(!calls.some((c) => c[0] === "delete"));
- assert.equal(extractTranslationControlState([prior]).sourceHash, HASH_B);
- });
-
- it("deletes redundant bot comments only after sticky replacement succeeds", async () => {
- const older = botComment(buildTranslationControlComment({
- v: 2,
- sourceHash: HASH_B,
- attemptedAt: 1,
- recent: [1],
- requiresTranslation: true,
- detectedLanguage: "German",
- }), 1);
- const newer = botComment(buildTranslationControlComment({
- v: 2,
- sourceHash: HASH_A,
- attemptedAt: 2,
- recent: [1, 2],
- requiresTranslation: false,
- detectedLanguage: "English",
- }), 2);
- const { github, calls } = mockGithub();
- const result = await persistTranslationControlState({
- github,
- owner: "o",
- repo: "r",
- issue_number: 1,
- comments: [older, newer],
- priorState: extractTranslationControlState([older, newer]),
- attempt: {
- sourceHash: HASH_A,
- requiresTranslation: false,
- detectedLanguage: "English",
- sourceComplete: true,
- },
- now: 300,
- });
- // Sticky = oldest id; update it in place and delete the newer duplicate.
- assert.equal(result.comment.id, 1);
- assert.deepEqual(calls.map((c) => c[0]), ["update", "delete"]);
- assert.equal(calls[0][1].comment_id, 1);
- assert.equal(calls[1][1].comment_id, 2);
- assert.deepEqual(result.cleanup.deleted, [2]);
- });
-
- it("cleanup failure leaves valid fallback comments intact", async () => {
- const older = botComment(buildTranslationControlComment({
- v: 2,
- sourceHash: HASH_B,
- attemptedAt: 1,
- recent: [1],
- requiresTranslation: true,
- detectedLanguage: "German",
- }), 1);
- const newer = botComment(buildTranslationControlComment({
- v: 2,
- sourceHash: HASH_A,
- attemptedAt: 2,
- recent: [1, 2],
- requiresTranslation: false,
- detectedLanguage: "English",
- }), 2);
- const { github, calls } = mockGithub({
- delete: async () => {
- throw new Error("delete denied");
- },
- });
- const result = await persistTranslationControlState({
- github,
- owner: "o",
- repo: "r",
- issue_number: 1,
- comments: [older, newer],
- priorState: extractTranslationControlState([older, newer]),
- attempt: {
- sourceHash: HASH_A,
- requiresTranslation: false,
- detectedLanguage: "English",
- sourceComplete: true,
- },
- now: 300,
- });
- assert.equal(result.comment.id, 1);
- assert.equal(result.cleanup.failed.length, 1);
- assert.equal(result.cleanup.failed[0].id, 2);
- assert.ok(calls.some((c) => c[0] === "update"));
- // Newer duplicate remains when delete fails — durable fallback remains.
- assert.equal(extractTranslationControlState([older, newer]).sourceHash, HASH_A);
- assert.equal(extractTranslationControlState([older]).sourceHash, HASH_B);
- });
-
- it("cooldown and hourly limits survive repeated issue events via bot comments", () => {
- const now = 1_700_000_000_000;
- const body = buildTranslationControlComment({
- v: 2,
- sourceHash: HASH_A,
- attemptedAt: now,
- recent: [now],
- requiresTranslation: false,
- detectedLanguage: "English",
- });
- const priorState = resolveControlState([botComment(body)]);
- const decision = shouldTranslate({
- sourceTitle: "Hello",
- sourceBody: "Still English but edited enough to change the hash.",
- priorState,
- now: now + 5_000,
- });
- assert.equal(decision.ok, false);
- assert.equal(decision.reason, "rate_limited_interval");
-
- const hourly = resolveControlState([botComment(buildTranslationControlComment({
- v: 2,
- sourceHash: HASH_A,
- attemptedAt: now,
- recent: Array.from({ length: 10 }, (_, i) => now - i * 60_000),
- requiresTranslation: false,
- detectedLanguage: "English",
- }))]);
- const hourlyDecision = shouldTranslate({
- sourceTitle: "Hello again",
- sourceBody: "Another English edit that would otherwise probe the model.",
- priorState: hourly,
- now: now + 120_000,
- });
- assert.equal(hourlyDecision.ok, false);
- assert.equal(hourlyDecision.reason, "rate_limited_hourly");
- });
-
- it("rapid sequential edits cannot invoke the model repeatedly", async () => {
- const { github, calls } = mockGithub({ nextId: 3 });
- const first = await persistTranslationControlState({
- github,
- owner: "o",
- repo: "r",
- issue_number: 9,
- comments: [],
- attempt: {
- sourceHash: HASH_A,
- requiresTranslation: false,
- detectedLanguage: "English",
- sourceComplete: true,
- },
- now: 1_000,
- });
- const comments = [botComment(first.comment.body, first.comment.id)];
- const priorState = resolveControlState(comments);
- const second = shouldTranslate({
- sourceTitle: "Edit two",
- sourceBody: "Changed body content that must still be rate limited.",
- priorState,
- now: 1_000 + 10_000,
- });
- assert.equal(second.ok, false);
- assert.equal(second.reason, "rate_limited_interval");
- assert.equal(calls.filter((c) => c[0] === "create").length, 1);
- });
-
- it("persistence never mutates the issue title or body", async () => {
- const { github, calls } = mockGithub();
- await persistTranslationControlState({
- github,
- owner: "o",
- repo: "r",
- issue_number: 9,
- comments: [],
- attempt: {
- sourceHash: HASH_A,
- requiresTranslation: false,
- detectedLanguage: "English",
- sourceComplete: true,
- },
- });
- assert.ok(!calls.some((c) => c[0] === "issueUpdate"));
- });
-
- it("selects only github-actions control comments", () => {
- const state = {
- v: 2,
- sourceHash: HASH_A,
- sourceHashes: { issue: HASH_A },
- attemptedAt: 1,
- recent: [1],
- requiresTranslation: true,
- detectedLanguage: "German",
- };
- const comments = [
- botComment("random bot comment"),
- botComment(buildTranslationControlComment(state)),
- { user: { login: "contributor" }, body: buildTranslationControlComment(state) },
- ];
- assert.deepEqual(extractTranslationControlState(comments), state);
- });
-
- it("reader and selector agree on the newest control comment", () => {
- const older = {
- v: 2,
- sourceHash: HASH_A,
- sourceHashes: { issue: HASH_A },
- attemptedAt: 1,
- recent: [1],
- requiresTranslation: true,
- detectedLanguage: "German",
- };
- const newer = {
- v: 2,
- sourceHash: HASH_B,
- sourceHashes: { issue: HASH_B },
- attemptedAt: 2,
- recent: [1, 2],
- requiresTranslation: true,
- detectedLanguage: "Japanese",
- };
- const comments = [
- { id: 1, user: { login: BOT_LOGIN }, body: buildTranslationControlComment(older) },
- { id: 2, user: { login: BOT_LOGIN }, body: buildTranslationControlComment(newer) },
- ];
- const selected = findControlComment(comments);
- assert.equal(selected.id, 2);
- assert.deepEqual(extractTranslationControlState(comments), newer);
- });
-
- it("round-trips base64url control state without HTML breakout", () => {
- const state = {
- v: 2,
- sourceHash: HASH_A,
- attemptedAt: 42,
- recent: [40, 42],
- requiresTranslation: true,
- detectedLanguage: "German --> @username