prebuilt binary or docker image

[DeoLeung]

Hi,

I tried building the binary myself(not a go programmer), by mounting the code into a go image. With no luck it failed, will be better if we can get a pre-build binary or a docker hub image for a quick check out, thanks!

[v0112358]

You can download pgpool2_exporter image from https://hub.docker.com/u/pgpool.

[nejco]

@v0112358 it seems mentioned docker image is outdated. Can we make a new release?

[pengbo0328]

I am going to update the docker image.

[pengbo0328]

Docker image is updated.

[zagr0]

Seems it does not respect env variables as the previous 1.0 did, like PGPOOL_SERVICE, PGPOOL_SERVICE_PORT, POSTGRES_USERNAME, POSTGRES_PASSWORD, but I have managed to run it with DATA_SOURCE_NAME
Thanks a lot!

[zagr0]

Also not sure that this is the issue, but exporter shows the password value with clear text in the logs:

time="2021-07-01T07:56:15Z" level=info msg="Starting pgpool2_exporter (version=0.0.0-dev, branch=master, revision=1d7883b98e99173103922191a3c9ad078a092077) for postgresql://user:jdloidfg,,3878743jmjmdf@localhost:5432/postgres" source="pgpool2_exporter.go:668"
time="2021-07-01T07:56:15Z" level=info msg="Listening on :9719" source="pgpool2_exporter.go:669"

just a suggestion for improvement to mask a password

[aljoshare]

And its very problematic to just overwrite the tag with a new version including a modifcation that changes the behavior. I would expect a new version tag 1.1 or 2.0 or something like that.

[pengbo0328]

Also not sure that this is the issue, but exporter shows the password value with clear text in the logs:

@zagr0 You are right.
It is an unexpected behavior.
I will make docker images to accept env variables (PGPOOL_SERVICE, PGPOOL_SERVICE_PORT, POSTGRES_USERNAME, POSTGRES_PASSWORD) and set to DATA_SOURCE_NAME.

[pratik-pagade]

Hi @pengbo0328 can you also make a PGPOOL_DBNAME variable and set it to the DATA_SOURCE_NAME in the docker image ? Right now I'm not able to use it for other databases other than "postgres". Also is the binary cross compiled ? Since I compiled the binary on macOS and tried to do docker run it gave me the following error Syntax error: "(" unexpected