From aea06c7009be214daf9ae462de3e64c56e4ad20d Mon Sep 17 00:00:00 2001 From: Jason Date: Mon, 22 Dec 2025 13:06:40 -0800 Subject: [PATCH 1/2] Use shortened names and enable benchmarks on trunk. A number of the benchmarks I added are now merged into trunk and thus can be run to compare PRs to pre-released versions of the code. Signed-off-by: Jason Marshall --- CHANGELOG.md | 1 + benchmarks/index.js | 6 +++--- benchmarks/util.js | 8 ++------ 3 files changed, 6 insertions(+), 9 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 61bf9334..992e16ce 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -32,6 +32,7 @@ project adheres to [Semantic Versioning](http://semver.org/). - AggregatorRegistry renamed to ClusterRegistry, old name deprecated - chore: update faceoff to 1.1 - perf: Stat aggregation uses similar strategy to collection. 60% faster aggregation +- ci: Run additional benchmarks against trunk ### Added diff --git a/benchmarks/index.js b/benchmarks/index.js index f6d4324e..83ccd388 100644 --- a/benchmarks/index.js +++ b/benchmarks/index.js @@ -13,9 +13,9 @@ const debug = require('debug')('benchmark'); */ const benchmarks = new Benchmark({ - 'prom-client@latest': 'prom-client@latest', - 'prom-client@trunk': 'git@github.com:siimon/prom-client', - 'prom-client@current': { location: process.cwd() }, + released: 'prom-client@latest', + trunk: 'git@github.com:siimon/prom-client', + current: { location: process.cwd() }, }); benchmarks.suite('counter', require('./counter')); diff --git a/benchmarks/util.js b/benchmarks/util.js index a4f05086..013f8587 100644 --- a/benchmarks/util.js +++ b/benchmarks/util.js @@ -5,7 +5,7 @@ const Path = require('path'); module.exports = setupUtilSuite; function setupUtilSuite(suite) { - const skip = ['prom-client@latest']; + const skip = ['released']; suite.add( 'hashObject', @@ -57,10 +57,6 @@ function setupUtilSuite(suite) { suite.add( 'LabelGrouper.keyFrom()', (client, labelGrouper) => { - if (labelGrouper === undefined) { - return; - } - labelGrouper.keyFrom({ foo: 'longish', user_agent: 'Chrome', @@ -77,7 +73,7 @@ function setupUtilSuite(suite) { return new Util.LabelGrouper(); }, - skip: ['prom-client@latest', 'prom-client@trunk'], + skip: ['released', 'trunk'], }, ); } From 130b4fee80d154e601b9c6eeedf6b2266836e5f8 Mon Sep 17 00:00:00 2001 From: Jason Marshall Date: Sun, 25 Jan 2026 00:24:56 -0800 Subject: [PATCH 2/2] Upgrade to get better jitter analysis. Signed-off-by: Jason Marshall --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 0e79ebe0..9b4c3614 100644 --- a/package.json +++ b/package.json @@ -42,7 +42,7 @@ "eslint-plugin-n": "^17.20.0", "eslint-plugin-prettier": "^5.0.1", "express": "^5.1.0", - "faceoff": "^1.1.0", + "faceoff": "~1.3.1", "globals": "^16.2.0", "husky": "^9.0.0", "jest": "^30.0.2",