Skip to content

SQLAlchemy compliance: restore reflection and identifier coverage #757

Description

@laughingman7743

Context

Parent issue: #736

ComponentReflectionTest, ComponentReflectionTestExtra, QuotedNameArgumentTest, and LongNameBlowoutTest are deleted from the compliance suite.
HasTableTest.test_has_table_cache is also skipped.
The dialect already implements table, view, comment, and column reflection, while constraint and index reflection remain unsupported.

Scope

  • Re-enable reflection tests already covered by dialect capabilities.
  • Use existing requirement gates for unsupported PK, FK, unique, and index reflection.
  • Verify quoted identifiers and Athena or Glue identifier length limits.
  • Investigate the has_table cache behavior and fix it if the dialect violates SQLAlchemy expectations.

Acceptance criteria

  • Supported reflection tests run instead of being deleted wholesale.
  • Unsupported reflection features remain gated by their existing requirements.
  • Quoted and long identifier behavior is either enabled or documented as an Athena or Glue limitation.
  • Cache behavior has a regression test if code changes are required.
  • just lint passes.
  • Athena tests are executed by class or node with -n 1.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions