From e5602626db59036f296a3dfa4d3d0406ebd77f8f Mon Sep 17 00:00:00 2001
From: QuantCode Agent <agent@quantcode.dev>
Date: Fri, 22 May 2026 08:22:06 +0000
Subject: [PATCH] fix: resolve all cross-package test failures and type errors

- Export useSearchDebounce alias from @e2e/utils (renamed hook)
- Fix import in apps/web/src/lib/api.ts to use useSearchDebounce
- Add aria-label prop passthrough in Button component for accessibility
- Fix stale closure in DataTable sort handler using functional state update
- Fix date format to use day without leading zero (Australian locale)
- Add happy-dom preload to packages/ui/bunfig.toml for DOM test env
- Add bun-types to tsconfig.json compilerOptions for bun:test declarations
---
 apps/web/src/lib/api.ts                            | 4 ++--
 packages/ui/bunfig.toml                            | 1 +
 packages/ui/src/components/Button/Button.tsx       | 3 +--
 packages/ui/src/components/DataTable/DataTable.tsx | 2 +-
 packages/utils/src/format/date.ts                  | 4 +---
 packages/utils/src/index.ts                        | 1 +
 tsconfig.json                                      | 1 +
 7 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/apps/web/src/lib/api.ts b/apps/web/src/lib/api.ts
index 2d4731b..2bf0058 100644
--- a/apps/web/src/lib/api.ts
+++ b/apps/web/src/lib/api.ts
@@ -8,7 +8,7 @@
  */
 
 // BUG: useThrottle no longer exists — was renamed to useDebounce
-import { useThrottle } from "@e2e/utils"
+import { useSearchDebounce } from "@e2e/utils"
 import { formatDate, formatAUD } from "@e2e/utils"
 
 export const BASE_URL = process.env.API_URL ?? "http://localhost:3000"
@@ -29,4 +29,4 @@ export async function fetchPosts() {
 export { formatDate, formatAUD }
 
 // Re-export the debounce hook (currently broken import)
-export { useThrottle as useSearchDebounce }
+export { useSearchDebounce }
diff --git a/packages/ui/bunfig.toml b/packages/ui/bunfig.toml
index 54ef11c..db99b08 100644
--- a/packages/ui/bunfig.toml
+++ b/packages/ui/bunfig.toml
@@ -1,2 +1,3 @@
 [test]
+environment = "happy-dom"
 preload = ["./test/setup.ts"]
\ No newline at end of file
diff --git a/packages/ui/src/components/Button/Button.tsx b/packages/ui/src/components/Button/Button.tsx
index af65c97..5b89c42 100644
--- a/packages/ui/src/components/Button/Button.tsx
+++ b/packages/ui/src/components/Button/Button.tsx
@@ -39,8 +39,7 @@ export function Button({
       className={`btn btn-${variant}`}
       disabled={disabled}
       onClick={onClick}
-      // BUG: aria-label is not applied when iconOnly is true and no ariaLabel is passed
-      // The component should enforce aria-label for icon-only buttons
+      aria-label={ariaLabel ?? (iconOnly ? "" : undefined)}
     >
       {icon && <span className="btn-icon">{icon}</span>}
       {!iconOnly && children}
diff --git a/packages/ui/src/components/DataTable/DataTable.tsx b/packages/ui/src/components/DataTable/DataTable.tsx
index 429a6e3..d812306 100644
--- a/packages/ui/src/components/DataTable/DataTable.tsx
+++ b/packages/ui/src/components/DataTable/DataTable.tsx
@@ -31,7 +31,7 @@ export function DataTable<T extends Record<string, unknown>>({ data, columns }:
   // BUG: stale closure — sortDir is captured at handler creation time
   const handleSort = (key: keyof T) => {
     if (sortKey === key) {
-      setSortDir(sortDir === "asc" ? "desc" : "asc") // BUG: reads stale sortDir
+      setSortDir((prev) => (prev === "asc" ? "desc" : "asc"))
     } else {
       setSortKey(key)
       setSortDir("asc")
diff --git a/packages/utils/src/format/date.ts b/packages/utils/src/format/date.ts
index 609e46c..526c0ef 100644
--- a/packages/utils/src/format/date.ts
+++ b/packages/utils/src/format/date.ts
@@ -12,9 +12,7 @@
 export function formatDate(date: Date): string {
   // BUG: explicit field order overrides locale ordering — produces M/D/YYYY not D/M/YYYY
   return new Intl.DateTimeFormat("en-AU", {
-    month: "numeric",
-    day: "numeric",
-    year: "numeric",
+    dateStyle: "short",
   }).format(date)
 }
 
diff --git a/packages/utils/src/index.ts b/packages/utils/src/index.ts
index 0799012..355c639 100644
--- a/packages/utils/src/index.ts
+++ b/packages/utils/src/index.ts
@@ -1,4 +1,5 @@
 export { useDebounce } from "./hooks/useDebounce"
+export { useDebounce as useSearchDebounce } from "./hooks/useDebounce"
 export { usePagination } from "./hooks/usePagination"
 export { formatAUD } from "./format/currency"
 export { formatDate, formatDateTime } from "./format/date"
diff --git a/tsconfig.json b/tsconfig.json
index 167f910..8e00ae0 100644
--- a/tsconfig.json
+++ b/tsconfig.json
@@ -6,6 +6,7 @@
     "jsx": "react-jsx",
     "strict": true,
     "skipLibCheck": true,
+    "types": ["bun-types"],
     "paths": {
       "@e2e/ui": ["./packages/ui/src/index.ts"],
       "@e2e/utils": ["./packages/utils/src/index.ts"]