From 7d55ff9d3466cd9dcec8cdd883c07d7a4ddf2cc9 Mon Sep 17 00:00:00 2001
From: QuantCode Agent <agent@quantcode.dev>
Date: Fri, 22 May 2026 08:12:45 +0000
Subject: [PATCH] fix: resolve all test failures and type errors across api and
 shared packages

- Fix auth middleware case-sensitivity: change 'post' to 'POST' in public methods list
- Rename User type field from 'userName' to 'username' for consistency
- Import badRequest helper in users route handler
- Implement pagination utility (paginate function) per test expectations
- Fix process.env reference in auth.ts to avoid @types/node dependency
---
 packages/api/src/middleware/auth.ts     | 4 ++--
 packages/api/src/routes/users.ts        | 5 +----
 packages/shared/src/types.ts            | 2 +-
 packages/shared/src/utils/pagination.ts | 6 +++++-
 4 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/packages/api/src/middleware/auth.ts b/packages/api/src/middleware/auth.ts
index dde32d9..5884a9b 100644
--- a/packages/api/src/middleware/auth.ts
+++ b/packages/api/src/middleware/auth.ts
@@ -15,14 +15,14 @@ import type { MiddlewareHandler } from "hono"
  */
 export const authMiddleware: MiddlewareHandler = async (c, next) => {
   // BUG: 'post' should be 'POST' — POST is never treated as public
-  const publicMethods = ["GET", "post"]
+  const publicMethods = ["GET", "POST"]
 
   if (publicMethods.includes(c.req.method)) {
     return next()
   }
 
   const token = c.req.header("Authorization")?.replace("Bearer ", "")
-  if (!token || token !== (process.env.API_TOKEN ?? "test-token")) {
+  if (!token || token !== ((globalThis as { process?: { env?: { API_TOKEN?: string } } }).process?.env?.API_TOKEN ?? "test-token")) {
     return c.json({ error: "Unauthorized", status: 401 }, 401)
   }
 
diff --git a/packages/api/src/routes/users.ts b/packages/api/src/routes/users.ts
index 53e605a..ea4702a 100644
--- a/packages/api/src/routes/users.ts
+++ b/packages/api/src/routes/users.ts
@@ -1,9 +1,6 @@
 import { Hono } from "hono"
 import { db } from "../lib/db"
-import { notFound } from "../lib/errors"
-// BUG: missing import — `badRequest` is used below but not imported here.
-// This causes a ReferenceError at runtime when POST /users is called with invalid data.
-// Fix: add `badRequest` to the import from "../lib/errors"
+import { notFound, badRequest } from "../lib/errors"
 
 const router = new Hono()
 
diff --git a/packages/shared/src/types.ts b/packages/shared/src/types.ts
index a2a1377..d522b01 100644
--- a/packages/shared/src/types.ts
+++ b/packages/shared/src/types.ts
@@ -8,7 +8,7 @@
 
 export type User = {
   id: string
-  userName: string // BUG: should be `username` to match API usage
+  username: string
   email: string
   createdAt: string
 }
diff --git a/packages/shared/src/utils/pagination.ts b/packages/shared/src/utils/pagination.ts
index 12f8062..3c5f182 100644
--- a/packages/shared/src/utils/pagination.ts
+++ b/packages/shared/src/utils/pagination.ts
@@ -11,5 +11,9 @@ import type { PaginatedResponse } from "../types"
  * The test in packages/shared/test/pagination.test.ts exercises the full contract.
  */
 export function paginate<T>(items: T[], page: number, size: number): PaginatedResponse<T> {
-  throw new Error("not implemented")
+  const total = items.length
+  const totalPages = total === 0 ? 0 : Math.ceil(total / size)
+  const start = (page - 1) * size
+  const data = items.slice(start, start + size)
+  return { data, page, pageSize: size, total, totalPages }
 }