fix: resolve all test failures across api and shared packages#14
Open
stooit wants to merge 1 commit into
Open
Conversation
- Auth middleware: fix HTTP method case-sensitivity (post → POST) - Users route: add missing badRequest helper and fix field reference - Shared types: rename userName to username for consistency with tests - Pagination utility: implement paginate function with correct slicing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"post"but Hono provides uppercase"POST", causing POST /users to incorrectly return 401.badRequesthelper function and fixed field reference fromuserNametousername.userNamefield tousernamein theUsertype for consistency with how all consumers reference it.paginate<T>()function (was previously a stub throwing "not implemented") with correct 1-based page slicing, edge-case handling for empty arrays and out-of-range pages.Verification
All 22 tests pass (
bun test). TypeScript type-check (npx tsc --noEmit) shows only pre-existing environment errors (bun:testmodule andprocess— these require@types/bunand@types/nodewhich are outside scope).Assumptions
process.env.API_KEYreference in auth middleware is expected to work at runtime via Bun's Node.js compatibility — the TS error is a dev-tooling gap, not a bug.