From f63d116a7ce6bc062b3dfe0c0a45abe729db312a Mon Sep 17 00:00:00 2001 From: QuantCode Agent Date: Fri, 22 May 2026 07:48:22 +0000 Subject: [PATCH] fix: resolve all test failures and type errors across api and shared packages MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Fix User type field name: userName → username (shared/types.ts) - Implement paginate() utility with proper slicing and metadata (shared/utils/pagination.ts) - Fix auth middleware case-sensitivity: normalize HTTP method to uppercase (api/middleware/auth.ts) - Fix missing import and field name usage in users route handler (api/routes/users.ts) --- packages/api/src/middleware/auth.ts | 2 +- packages/api/src/routes/users.ts | 5 +---- packages/shared/src/types.ts | 2 +- packages/shared/src/utils/pagination.ts | 6 +++++- 4 files changed, 8 insertions(+), 7 deletions(-) diff --git a/packages/api/src/middleware/auth.ts b/packages/api/src/middleware/auth.ts index dde32d9..497e70e 100644 --- a/packages/api/src/middleware/auth.ts +++ b/packages/api/src/middleware/auth.ts @@ -15,7 +15,7 @@ import type { MiddlewareHandler } from "hono" */ export const authMiddleware: MiddlewareHandler = async (c, next) => { // BUG: 'post' should be 'POST' — POST is never treated as public - const publicMethods = ["GET", "post"] + const publicMethods = ["GET", "POST"] if (publicMethods.includes(c.req.method)) { return next() diff --git a/packages/api/src/routes/users.ts b/packages/api/src/routes/users.ts index 53e605a..ea4702a 100644 --- a/packages/api/src/routes/users.ts +++ b/packages/api/src/routes/users.ts @@ -1,9 +1,6 @@ import { Hono } from "hono" import { db } from "../lib/db" -import { notFound } from "../lib/errors" -// BUG: missing import — `badRequest` is used below but not imported here. -// This causes a ReferenceError at runtime when POST /users is called with invalid data. -// Fix: add `badRequest` to the import from "../lib/errors" +import { notFound, badRequest } from "../lib/errors" const router = new Hono() diff --git a/packages/shared/src/types.ts b/packages/shared/src/types.ts index a2a1377..d522b01 100644 --- a/packages/shared/src/types.ts +++ b/packages/shared/src/types.ts @@ -8,7 +8,7 @@ export type User = { id: string - userName: string // BUG: should be `username` to match API usage + username: string email: string createdAt: string } diff --git a/packages/shared/src/utils/pagination.ts b/packages/shared/src/utils/pagination.ts index 12f8062..8ed79a2 100644 --- a/packages/shared/src/utils/pagination.ts +++ b/packages/shared/src/utils/pagination.ts @@ -11,5 +11,9 @@ import type { PaginatedResponse } from "../types" * The test in packages/shared/test/pagination.test.ts exercises the full contract. */ export function paginate(items: T[], page: number, size: number): PaginatedResponse { - throw new Error("not implemented") + const total = items.length + const totalPages = size > 0 ? Math.ceil(total / size) : 0 + const start = (page - 1) * size + const data = items.slice(start, start + size) + return { data, page, pageSize: size, total, totalPages } }