From 03f3925d728c8c548012600939131b3db8d6305b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E9=AB=98=E8=89=B3=E5=85=B5?= Date: Thu, 30 Apr 2026 14:16:41 +0800 Subject: [PATCH] fix: wrap item label when extra exists --- src/utils/nodeUtil.tsx | 12 +++++++++--- tests/__snapshots__/MenuItem.spec.tsx.snap | 12 ++++++++++-- 2 files changed, 19 insertions(+), 5 deletions(-) diff --git a/src/utils/nodeUtil.tsx b/src/utils/nodeUtil.tsx index c0b81106..aef40010 100644 --- a/src/utils/nodeUtil.tsx +++ b/src/utils/nodeUtil.tsx @@ -48,11 +48,17 @@ function convertItemsToNodes( return ; } + const hasExtra = !!extra || extra === 0; + return ( - {label} - {(!!extra || extra === 0) && ( - {extra} + {hasExtra ? ( + <> + {label} + {extra} + + ) : ( + label )} ); diff --git a/tests/__snapshots__/MenuItem.spec.tsx.snap b/tests/__snapshots__/MenuItem.spec.tsx.snap index dc957d18..c4e28718 100644 --- a/tests/__snapshots__/MenuItem.spec.tsx.snap +++ b/tests/__snapshots__/MenuItem.spec.tsx.snap @@ -22,7 +22,11 @@ exports[`MenuItem overwrite default role should set extra to group option 1`] = role="menuitem" tabindex="-1" > - Menu Item 1 + + Menu Item 1 + @@ -40,7 +44,11 @@ exports[`MenuItem overwrite default role should set extra to option 1`] = ` role="menuitem" tabindex="-1" > - Top Menu Item + + Top Menu Item +