From f0663f7ecbb50888c736912a21776c6ea5c0d0e6 Mon Sep 17 00:00:00 2001 From: Zeyu Yang <40936154+zeyuyang42@users.noreply.github.com> Date: Thu, 20 Aug 2026 01:28:01 +0200 Subject: [PATCH] Run the core build on pull requests PRs #13 through #16 all merged without a single check running. The three workflows trigger only on push to main, workflow_dispatch, and (for PureData) workflow_run, so nothing gates a merge -- the only verification those PRs got was me dispatching a workflow by hand against the branch. Adding pull_request here closes the most important half of that: every PR is now gated on the core library still building on macOS, Linux and Windows. Left unfiltered on purpose, unlike the push trigger. A PR should be checked whichever directory it touched; the path filters are part of why a puredata- or maxmsp-only change currently triggers nothing at all. The other two workflows deliberately do not get the trigger yet. The PureData workflow reads its core artifact id from github.event.workflow_run, so on a pull_request event CORE_RUN_ID is empty and it fails at its own guard. The Doxygen deploy fails by design pending the organization owner's decision on Pages, and would mark every PR red. Both are resolved by the ci.yml restructure that follows, which replaces the cross-workflow artifact handoff with in-run job dependencies -- and which will itself be reviewed with these checks running. Co-Authored-By: Claude Opus 5 (1M context) --- .github/workflows/build-zerr-core-static-library.yml | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/.github/workflows/build-zerr-core-static-library.yml b/.github/workflows/build-zerr-core-static-library.yml index 24aae1f..0e471de 100644 --- a/.github/workflows/build-zerr-core-static-library.yml +++ b/.github/workflows/build-zerr-core-static-library.yml @@ -2,6 +2,16 @@ name: build zerr-core static library on: workflow_dispatch: + # Deliberately unfiltered, unlike the push trigger below: a pull request should + # be gated on the core still building regardless of which directory it touched. + # Nothing ran on PRs #13-#16 at all, so they merged on manual dispatch alone. + # + # Only this workflow gains the trigger for now. The PureData workflow takes its + # core artifact from `workflow_run`, so on a pull_request event its CORE_RUN_ID + # would be empty and it would fail at its own guard; the Doxygen deploy fails by + # design pending the org owner, and would paint every PR red. Both are addressed + # by the ci.yml restructure that follows this change. + pull_request: push: branches: - main