From fe726c3402efd23606a945330b12ffddfd145143 Mon Sep 17 00:00:00 2001 From: Stephan Hageboeck Date: Mon, 4 Aug 2025 15:27:43 +0200 Subject: [PATCH 1/3] [roottest] Add missing environment variable for tests. When gnuinstall=On, ROOT needs to ignore the library directory prefix while still in the build tree. --- roottest/root/core/CMakeLists.txt | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/roottest/root/core/CMakeLists.txt b/roottest/root/core/CMakeLists.txt index ac6c03e515830..eaebc761dceb0 100644 --- a/roottest/root/core/CMakeLists.txt +++ b/roottest/root/core/CMakeLists.txt @@ -33,7 +33,10 @@ ROOTTEST_ADD_TEST(StatusBitsCheck OUTREF execStatusBitsCheck.ref) add_test(NAME root_exe_exitStatus COMMAND $ "-e invalid" "--no_exist") -set_property(TEST root_exe_exitStatus PROPERTY WILL_FAIL True) +set_tests_properties(root_exe_exitStatus PROPERTIES + WILL_FAIL True + ENVIRONMENT ROOTIGNOREPREFIX=1) add_test(NAME root_exe_errorMessage COMMAND $ "-e invalid" "--no_exist") -set_property(TEST root_exe_errorMessage PROPERTY - PASS_REGULAR_EXPRESSION "root: unrecognized option '-e invalid'.*--no_exist.*Try 'root --help'") +set_tests_properties(root_exe_errorMessage PROPERTIES + PASS_REGULAR_EXPRESSION "root: unrecognized option '-e invalid'.*--no_exist.*Try 'root --help'" + ENVIRONMENT ROOTIGNOREPREFIX=1) From 0c5ebf5ccd4e651a556e177eb12853c0b3a9c620 Mon Sep 17 00:00:00 2001 From: Stephan Hageboeck Date: Tue, 22 Jul 2025 16:05:41 +0200 Subject: [PATCH 2/3] [CI] Enable gnuinstall for two special builds. To cover the gnuninstall case, switch mac beta and the linux arch-native builds to gnuinstall. This is done as an option override on special builds to not affect the binaries we produce. --- .github/workflows/root-ci.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/root-ci.yml b/.github/workflows/root-ci.yml index 540752428518f..2916f9d7bde45 100644 --- a/.github/workflows/root-ci.yml +++ b/.github/workflows/root-ci.yml @@ -111,6 +111,7 @@ jobs: - platform: mac-beta is_special: true arch: ARM64 + overrides: ["gnuinstall=ON"] runs-on: # Using '[self-hosted, ..., ...]' does not work for some reason :) - self-hosted @@ -405,8 +406,8 @@ jobs: overrides: ["runtime_cxxmodules=Off"] - image: alma9 is_special: true - property: march_native - overrides: ["CMAKE_BUILD_TYPE=RelWithDebInfo", "CMAKE_CXX_FLAGS=-march=native", "CMAKE_C_FLAGS=-march=native", "builtin_zlib=ON", "builtin_zstd=ON"] + property: "march_native, gnuinstall" + overrides: ["CMAKE_BUILD_TYPE=RelWithDebInfo", "CMAKE_CXX_FLAGS=-march=native", "CMAKE_C_FLAGS=-march=native", "builtin_zlib=ON", "builtin_zstd=ON", "gnuinstall=ON"] - image: alma9 is_special: true property: arm64 From b775d16c5823e0e3544a520e336b14a90cc6f3af Mon Sep 17 00:00:00 2001 From: Stephan Hageboeck Date: Wed, 8 Oct 2025 14:09:14 +0200 Subject: [PATCH 3/3] [CI] Enable output-on-failure in post-install tests. --- .github/workflows/root-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/root-ci.yml b/.github/workflows/root-ci.yml index 2916f9d7bde45..58193a333149c 100644 --- a/.github/workflows/root-ci.yml +++ b/.github/workflows/root-ci.yml @@ -607,7 +607,7 @@ jobs: - name: CTest in post-install test project working-directory: ${{ env.POST_INSTALL_DIR }} - run: ctest -j $(nproc) + run: ctest --output-on-failure -j event_file: # For any event that is not a PR, the CI will always run. In PRs, the CI