Skip to content

Re-check .github/actionlint.yaml's workflow_repository/sha ignore after bumping baseline past v0.13.1 #105

Description

@ineedjet

Problem

.github/actionlint.yaml in this repo carries a repo-local ignore for
deploy-shared.yml:

paths:
  .github/workflows/deploy-shared.yml:
    # actionlint 1.7.12 predates these GitHub job context properties.
    ignore:
      - 'property "workflow_(repository|sha)" is not defined in object type'

This exists because actionlint doesn't yet understand
job.workflow_repository/job.workflow_sha, the newer GitHub Actions
context properties deploy-shared.yml relies on (used to self-checkout the
correct repo/ref inside a reusable workflow). Baseline's own
hooks/actionlint.sh carries the equivalent -ignore flags for the same
gap, plus two more for the $/... self-reference convention used
throughout this repo's workflows (Copilot's automated review on #102 flagged
those $/... references as invalid — false positive, same root cause: the
reviewing tool doesn't know about this newer GitHub Actions behavior
either).

Baseline released
v0.13.1
("ignore unsupported reusable workflow context") while this PR was still
open — this repo is still pinned to v0.13.0 in lint.yml, embedder.yml,
github.yml, and notify-telegram-pr.yml.

Proposed change

Once this repo bumps its rubykatzen/baseline@vX pin past v0.13.1 (likely
via the existing Dependabot flow), re-check whether v0.13.1 actually changed
actionlint's handling of workflow_repository/workflow_sha (upgraded
actionlint version, or adjusted ignore list). If it did, drop the
now-redundant ignore block from this repo's own .github/actionlint.yaml.

Related

Surfaced while triaging Copilot's automated review on #102.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions