refactor: move format/with_format from builder to formatter#363
Draft
djugei wants to merge 3 commits into
Draft
Conversation
djugei
force-pushed
the
with_format
branch
3 times, most recently
from
c4ace12 to
ced793e
Compare
Author
|
obviously a breaking change cause the interface is different. still unsure if that signature should be used (more generic but requires type annotations) or if what was on builder should be kept (less generic, no type annotations) or maybe both with different names. currently leaning towards both. |
Contributor
|
FYI if you are wanting to propose a change, I require an issue to exist for it that explains the problem and the solution. |
djugei
force-pushed
the
with_format
branch
3 times, most recently
from
aff2c2f to
6cbf356
Compare
Author
|
i have split the commit to make reviews easier, and rebased on top of latest main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as mentioned in #360