Skip to content

Dep graph parallel frontend UI test failures #157607

@zetanumbers

Description

@zetanumbers

Part of #154314

There are a number of tests for the -Zquery-dep-graph option. Some of them fail with --parallel-frontend-threads set. That's because of this line:

// Do not ICE when a query is called from within `with_query`.
if let Some(retained_graph) = &mut retained_graph.try_lock() {
retained_graph.push(index, *node, &edges);
}

Mutex::try_lock might not succeed in parallel and currently such failure is ignored, leaving the retained graph incomplete.

More at #157352

Affected UI tests:

  • tests/ui/dep-graph/dep-graph-assoc-type-codegen.rs
  • tests/ui/dep-graph/dep-graph-caller-callee.rs
  • tests/ui/dep-graph/dep-graph-struct-signature.rs
  • tests/ui/dep-graph/dep-graph-trait-impl-two-traits-same-method.rs
  • tests/ui/dep-graph/dep-graph-trait-impl.rs
  • tests/ui/dep-graph/dep-graph-type-alias.rs
  • tests/ui/dep-graph/dep-graph-variance-alias.rs

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-parallel-compilerArea: parallel compilerA-testsuiteArea: The testsuite used to check the correctness of rustcC-bugCategory: This is a bug.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions