Skip to content

Tests: remaining getrandom 0.2 API call breaks full suite on 0.4.3 #33

Description

@samjanny

Summary

The current main branch does not compile the full Rust test suite after the Dependabot update to getrandom 0.4.3.

Commit 4127672 adapted entangled-core/src/types/keys.rs from getrandom::getrandom to getrandom::fill, but the same legacy call remains in the test-only SigningKey::generate helper at entangled-core/src/crypto/ed25519.rs:166.

Reproduction

cargo test --workspace --all-targets --locked

Compiler result:

error[E0425]: cannot find function `getrandom` in crate `getrandom`
  --> entangled-core/src/crypto/ed25519.rs:166:20

The dedicated conformance integration target still compiles because the stale helper is behind cfg(test) and is not enabled when the library is built as a dependency of that target.

Suggested fix

Replace the remaining call with getrandom::fill(&mut seed) and run the full locked workspace test suite. This is a repository-maintenance bug independent of any Entangled specification revision.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions