Commit cd36f46
committed
do not configure logging on import, use named logger
`convert_airtable.py` was configuring the logger for the root level,
which clashes with other loggers that are properly configured via a
logging dict, like how it's done normally in applications like django.
In applications that configure their own
logging this caused duplicated log lines and third-party output in
seatable's format.
It should be possible to toggle seatable_api logging on explicitly if it's needed.
In general, libraries should only configure their own named logging space.
See https://docs.python.org/3/howto/logging.html#configuring-logging-for-a-library1 parent 2e75909 commit cd36f46
2 files changed
Lines changed: 9 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
| 3 | + | |
3 | 4 | | |
4 | 5 | | |
5 | 6 | | |
| |||
31 | 32 | | |
32 | 33 | | |
33 | 34 | | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
34 | 42 | | |
35 | 43 | | |
36 | 44 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
5 | 4 | | |
6 | 5 | | |
7 | 6 | | |
| |||
27 | 26 | | |
28 | 27 | | |
29 | 28 | | |
30 | | - | |
31 | | - | |
| 29 | + | |
32 | 30 | | |
33 | 31 | | |
34 | 32 | | |
| |||
0 commit comments