diff --git a/.github/workflows/check_dependencies.yml b/.github/workflows/check_dependencies.yml index ef1c532..9fd856a 100644 --- a/.github/workflows/check_dependencies.yml +++ b/.github/workflows/check_dependencies.yml @@ -3,8 +3,7 @@ # Reusable workflow: call from a consumer repo with pull_request (labeled) and/or workflow_dispatch. # # Does not run check_auth: that job updates CONFIG_JSON via gh secret set, which notifies -# repo/org admins by email. The CLI check-dependencies command only scans local Liquid Test -# YAML files and does not need API credentials. +# repo/org admins by email. check-dependencies only scans local Liquid Test YAML files. name: Check dependencies run-name: Check dependencies for changed reconciliation templates on: @@ -140,12 +139,6 @@ jobs: }); } - - name: Setup Node and Silverfin CLI - if: steps.handles.outputs.handles_json != '[]' - run: | - npm install https://github.com/silverfin/silverfin-cli.git - node ./node_modules/silverfin-cli/bin/cli.js -V - # Run check-dependencies for each handle and collect results - name: Run check-dependencies per handle id: run-check @@ -153,6 +146,7 @@ jobs: env: HANDLES_JSON: ${{ steps.handles.outputs.handles_json }} run: | + npm install https://github.com/silverfin/silverfin-cli.git job_failed=0 : > check_results.txt while IFS= read -r handle; do