[Bug?]: dev hmr error: "template2 is not a function"

[drdxk]

Duplicates

• I have searched the existing issues

Latest version

• I have tested the latest version

Current behavior 😯

npm run dev causes HMR error for notes template

Expected behavior 🤔

no error

Steps to reproduce 🕹

Steps:

1. npm init solid@latest
2. select TypeScript, notes
3. npm i
4. npm run dev, open browser
5. modify src/routes/(home).tsx, e.g. add extra "!"
6. observe browser state

Context 🔦

No response

Your environment 🌎

[brenelz]

Can verify this issue.

[brenelz]

Do we know is it only the notes template? I tried downgrading and the same issue with HMR

[drdxk]

fwiw, I was checking out some other templates and building something small off of the basic template and haven't seen that issue elsewhere

[dennev]

The use of $ServerOnly causes this issue. If you remove the $ServerOnly in
examples/notes/src/app.tsx:14, examples/notes/src/components/SearchField.tsx:15
HMR works fine.

In the mentioned issue:

Of course if the browser ever tried to re-rerun it well you are in trouble.

So, by inference, it's probably not a good fit for HMR either.

While I recognize the intent of $ServerOnly from a performance perspective, I also consider that the benefits of HMR may outweigh the opportunity cost of performance improvements due to $ServerOnly, and that there may be other potential issues.
Therefore, I have prepared a commit that removes $ServerOnly from this example. (I have reserved judgment on the $ServerOnly that exists in archived_examples).

Should I replace this example? Or does anyone have another opinion?

[htndev]

I'm encountering the same issue in my pet project. Could you give some hints on where this problem stems from?

[vladmiller]

Same issue here, randomly getting these errors until I comment out line by line and figure out which line causes this. Unfortunately, this makes solid quite hard to develop.

[Langlw1992]

Got the same issue. But i use @tanstack/solid-start ranther the solid-start

[freakingeek]

I have the same issue. Still no fix?

[vladmiller]

@Langlw1992 I've got the same issue on both tanstack/start and solid start

[lxsmnsyc]

@vladmiller I'll check if we can transfer this to solid-refresh