Skip to content

Stale "SNPaaS Mission Control" link in deploy-cf GitHub Actions summary #339

Description

@jossy

What'''s happening

Every deploy-cf task rendered for GitHub Actions gets a fixed final "Summary" step from SummaryStep():

func (a *Actions) SummaryStep() Step {
	sRun := []string{}
	sRun = append(sRun, `echo ":rocket: **Deployment Successful**" >> $GITHUB_STEP_SUMMARY`)
	sRun = append(sRun, `echo "" >> $GITHUB_STEP_SUMMARY`)
	sRun = append(sRun, `echo "[SNPaaS Mission Control](https://mission-control.snpaas.eu/)" >> $GITHUB_STEP_SUMMARY`)
	return Step{
		Name: "Summary",
		Run:  strings.Join(sRun, "\n"),
	}
}

https://mission-control.snpaas.eu/ has been decommissioned - it now just shows a splash page saying so and points people to Central Grafana (https://grafana.ee.springernature.io) instead.

Version

Confirmed on the latest halfpipe CLI (3.238.0, halfpipe sync reports "Already on latest version!"), so this isn'''t a stale-local-binary issue.

Suggested fix

Update (or drop) the hardcoded Mission Control link in SummaryStep(). A link to Central Grafana (https://grafana.ee.springernature.io) would be a reasonable replacement, or simply remove the link if there'''s no direct per-app equivalent.

Repro

Any repo using a deploy-cf task with platform: actions in .halfpipe.io will show this in the job'''s GitHub Actions summary after a successful deploy. E.g. springernature/ee-snpaas-console.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions