Fix #2468 alterCollection, approach 2 (like "alterTable") -- PRIMARY option#2471
Draft
tatu-at-datastax wants to merge 27 commits into
Draft
Fix #2468 alterCollection, approach 2 (like "alterTable") -- PRIMARY option#2471tatu-at-datastax wants to merge 27 commits into
tatu-at-datastax wants to merge 27 commits into
Conversation
Contributor
📉 Unit Test Coverage Delta vs Main Branch
|
Contributor
Unit Test Coverage Report
|
Contributor
📉 Integration Test Coverage Delta vs Main Branch (dse69-it)
|
Contributor
Integration Test Coverage Report (dse69-it)
|
Contributor
📈 Integration Test Coverage Delta vs Main Branch (hcd-it)
|
Contributor
Integration Test Coverage Report (hcd-it)
|
tatu-at-datastax
changed the title
…lection-approach-2' into tatu/2468-alter-collection-approach-2
| description = | ||
| "Command that alters mutable settings of an existing collection. Currently supports enabling the 'lexical' feature.") | ||
| @JsonTypeName(CommandName.Names.ALTER_COLLECTION) | ||
| public record AlterCollectionCommand(AlterCollectionOperation operation) |
Contributor
Author
There was a problem hiding this comment.
Modeled after AlterTableCommand, same approach with polymorphich operation types.
| */ | ||
| @JsonTypeInfo(use = JsonTypeInfo.Id.NAME, include = JsonTypeInfo.As.WRAPPER_OBJECT) | ||
| @JsonSubTypes({@JsonSubTypes.Type(value = AlterCollectionOperationImpl.EnableLexical.class)}) | ||
| public sealed interface AlterCollectionOperation |
Contributor
Author
There was a problem hiding this comment.
Modeled after AlterTableOperation, but uses sealed types to reduce likelihood of missing handlers
| import org.eclipse.microprofile.openapi.annotations.media.Schema; | ||
|
|
||
| /** Each operation that {@link AlterCollectionCommand} understands is represented by a record. */ | ||
| public class AlterCollectionOperationImpl { |
Contributor
Author
There was a problem hiding this comment.
and this is modeled after AlterTableOperationImpl.
tatu-at-datastax
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Implements "alterCollection" command to allow enabling of "lexical" indexing, with "alterTable" style
Which issue(s) this PR fixes:
Fixes #2468
Checklist