Skip to content

Fix #2134: mismatching scope#2481

Open
tatu-at-datastax wants to merge 4 commits into
mainfrom
tatu/2134-embedding-provider-timeout-reranking
Open

Fix #2134: mismatching scope#2481
tatu-at-datastax wants to merge 4 commits into
mainfrom
tatu/2134-embedding-provider-timeout-reranking

Conversation

@tatu-at-datastax
Copy link
Copy Markdown
Contributor

What this PR does:

Fixes mismatched error scope, adds tests to verify fix

Which issue(s) this PR fixes:
Fixes #2134

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CLA Signed: DataStax CLA

@tatu-at-datastax tatu-at-datastax self-assigned this May 22, 2026
@tatu-at-datastax tatu-at-datastax requested a review from a team as a code owner May 22, 2026 19:55
# ================================================================================================================

- scope: RERANKING
- scope: RERANKING_PROVIDER
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actual fix: Scope.RERANKING_PROVIDER exists, NOT Scope.RERANKING.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 22, 2026

📈 Unit Test Coverage Delta vs Main Branch

Metric Value
Main Branch 51.67%
This PR 51.75%
Delta 🟢 +0.08%
✅ Coverage improved!

@github-actions
Copy link
Copy Markdown
Contributor

Unit Test Coverage Report

Overall Project 51.75% 🍏

There is no coverage information present for the Files changed

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 22, 2026

➡️ Integration Test Coverage Delta vs Main Branch (dse69-it)

Metric Value
Main Branch 72.77%
This PR 72.77%
Delta ⚪ 0.00%
ℹ️ Coverage unchanged

@github-actions
Copy link
Copy Markdown
Contributor

Integration Test Coverage Report (dse69-it)

Overall Project 72.77% 🍏

There is no coverage information present for the Files changed

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 22, 2026

📉 Integration Test Coverage Delta vs Main Branch (hcd-it)

Metric Value
Main Branch 74.19%
This PR 74.19%
Delta 🔴 -0.00%
⚠️ Coverage decreased

@github-actions
Copy link
Copy Markdown
Contributor

Integration Test Coverage Report (hcd-it)

Overall Project 74.19% 🍏

There is no coverage information present for the Files changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Get EMBEDDING_PROVIDER_TIMEOUT when using reranking provider

1 participant