From 76c5787c25eb1a3ac37b6275db19dfdb4d4b33a2 Mon Sep 17 00:00:00 2001 From: Claude Date: Sun, 16 Aug 2026 06:21:08 +0000 Subject: [PATCH] test: migrate `stats/base/dists/rayleigh/logcdf` to ULP-based assertions Replaces relative tolerance comparisons with `isAlmostSameValue` checks in the test fixture loops. The JavaScript and native implementations both reproduce the Julia reference values exactly over all three fixture files, so the ULP bound was tightened to `0`. Ref: https://github.com/stdlib-js/stdlib/issues/11352 Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_01E1SM9ZH1ZA2Gamaz998sP9 --- .../rayleigh/logcdf/test/test.factory.js | 33 +++---------------- .../dists/rayleigh/logcdf/test/test.logcdf.js | 33 +++---------------- .../dists/rayleigh/logcdf/test/test.native.js | 33 +++---------------- 3 files changed, 12 insertions(+), 87 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/rayleigh/logcdf/test/test.factory.js b/lib/node_modules/@stdlib/stats/base/dists/rayleigh/logcdf/test/test.factory.js index 3b8259614916..88b8006e31d0 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/rayleigh/logcdf/test/test.factory.js +++ b/lib/node_modules/@stdlib/stats/base/dists/rayleigh/logcdf/test/test.factory.js @@ -21,11 +21,10 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var factory = require( './../lib/factory.js' ); @@ -127,9 +126,7 @@ tape( 'if `sigma` equals `0`, the created function evaluates a degenerate distri tape( 'the created function evaluates the logcdf for `x` given small scale parameter `sigma`', function test( t ) { var expected; var logcdf; - var delta; var sigma; - var tol; var i; var x; var y; @@ -140,13 +137,7 @@ tape( 'the created function evaluates the logcdf for `x` given small scale param for ( i = 0; i < x.length; i++ ) { logcdf = factory( sigma[i] ); y = logcdf( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', sigma: '+sigma[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. sigma: '+sigma[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } t.end(); }); @@ -154,9 +145,7 @@ tape( 'the created function evaluates the logcdf for `x` given small scale param tape( 'the created function evaluates the logcdf for `x` given medium scale parameter `sigma`', function test( t ) { var expected; var logcdf; - var delta; var sigma; - var tol; var i; var x; var y; @@ -167,13 +156,7 @@ tape( 'the created function evaluates the logcdf for `x` given medium scale para for ( i = 0; i < x.length; i++ ) { logcdf = factory( sigma[i] ); y = logcdf( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', sigma: '+sigma[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. sigma: '+sigma[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } t.end(); }); @@ -181,9 +164,7 @@ tape( 'the created function evaluates the logcdf for `x` given medium scale para tape( 'the created function evaluates the logcdf for `x` given large scale parameter `sigma`', function test( t ) { var expected; var logcdf; - var delta; var sigma; - var tol; var i; var x; var y; @@ -194,13 +175,7 @@ tape( 'the created function evaluates the logcdf for `x` given large scale param for ( i = 0; i < x.length; i++ ) { logcdf = factory( sigma[i] ); y = logcdf( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', sigma: '+sigma[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. sigma: '+sigma[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/rayleigh/logcdf/test/test.logcdf.js b/lib/node_modules/@stdlib/stats/base/dists/rayleigh/logcdf/test/test.logcdf.js index 8601a1e6ceed..df811de87ab2 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/rayleigh/logcdf/test/test.logcdf.js +++ b/lib/node_modules/@stdlib/stats/base/dists/rayleigh/logcdf/test/test.logcdf.js @@ -21,11 +21,10 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var logcdf = require( './../lib' ); @@ -93,9 +92,7 @@ tape( 'if provided `sigma` equals `0`, the function evaluates a degenerate distr tape( 'the function evaluates the logcdf for `x` given small scale parameter `sigma`', function test( t ) { var expected; - var delta; var sigma; - var tol; var i; var x; var y; @@ -105,22 +102,14 @@ tape( 'the function evaluates the logcdf for `x` given small scale parameter `si sigma = smallScale.sigma; for ( i = 0; i < x.length; i++ ) { y = logcdf( x[i], sigma[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', sigma: '+sigma[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. sigma: '+sigma[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function evaluates the logcdf for `x` given medium scale parameter `sigma`', function test( t ) { var expected; - var delta; var sigma; - var tol; var i; var x; var y; @@ -130,22 +119,14 @@ tape( 'the function evaluates the logcdf for `x` given medium scale parameter `s sigma = mediumScale.sigma; for ( i = 0; i < x.length; i++ ) { y = logcdf( x[i], sigma[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', sigma: '+sigma[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. sigma: '+sigma[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function evaluates the logcdf for `x` given large scale parameter `sigma`', function test( t ) { var expected; - var delta; var sigma; - var tol; var i; var x; var y; @@ -155,13 +136,7 @@ tape( 'the function evaluates the logcdf for `x` given large scale parameter `si sigma = largeScale.sigma; for ( i = 0; i < x.length; i++ ) { y = logcdf( x[i], sigma[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', sigma: '+sigma[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. sigma: '+sigma[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/rayleigh/logcdf/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/rayleigh/logcdf/test/test.native.js index 3a1a8eee8107..3b2a317a148a 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/rayleigh/logcdf/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/rayleigh/logcdf/test/test.native.js @@ -22,12 +22,11 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var tryRequire = require( '@stdlib/utils/try-require' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); // FIXTURES // @@ -102,9 +101,7 @@ tape( 'if provided `sigma` equals `0`, the function evaluates a degenerate distr tape( 'the function evaluates the logcdf for `x` given small scale parameter `sigma`', opts, function test( t ) { var expected; - var delta; var sigma; - var tol; var i; var x; var y; @@ -114,22 +111,14 @@ tape( 'the function evaluates the logcdf for `x` given small scale parameter `si sigma = smallScale.sigma; for ( i = 0; i < x.length; i++ ) { y = logcdf( x[i], sigma[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', sigma: '+sigma[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. sigma: '+sigma[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function evaluates the logcdf for `x` given medium scale parameter `sigma`', opts, function test( t ) { var expected; - var delta; var sigma; - var tol; var i; var x; var y; @@ -139,22 +128,14 @@ tape( 'the function evaluates the logcdf for `x` given medium scale parameter `s sigma = mediumScale.sigma; for ( i = 0; i < x.length; i++ ) { y = logcdf( x[i], sigma[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', sigma: '+sigma[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. sigma: '+sigma[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function evaluates the logcdf for `x` given large scale parameter `sigma`', opts, function test( t ) { var expected; - var delta; var sigma; - var tol; var i; var x; var y; @@ -164,13 +145,7 @@ tape( 'the function evaluates the logcdf for `x` given large scale parameter `si sigma = largeScale.sigma; for ( i = 0; i < x.length; i++ ) { y = logcdf( x[i], sigma[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', sigma: '+sigma[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. sigma: '+sigma[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } t.end(); });