From 651231586c8221e2917aa424325ea2068b7c18c6 Mon Sep 17 00:00:00 2001 From: subzeroid <143403577+subzeroid@users.noreply.github.com> Date: Sat, 20 Jun 2026 20:04:02 +0300 Subject: [PATCH] docs(test): clarify e2e proxy default reasoning Reword the proxy comments in the aiograpi /info e2e: the default is no proxy because the seeded session (client_settings) carries the account's device trust, not because pooled proxies are inherently unreliable. Comment-only; behaviour unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) --- tests/live/aiograpi_info_e2e.py | 9 +++++---- tests/test_aiograpi_info_e2e.py | 2 +- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/tests/live/aiograpi_info_e2e.py b/tests/live/aiograpi_info_e2e.py index bf59762..f4e67c0 100644 --- a/tests/live/aiograpi_info_e2e.py +++ b/tests/live/aiograpi_info_e2e.py @@ -103,7 +103,7 @@ def _build_subprocess_env( ``HIKERAPI_PROXY`` is the proxy the CLI feeds to *every* backend (``cli._build_backend`` passes ``config.hiker_proxy`` to aiograpi too). - An explicit ``IG_PROXY`` wins over the account's own proxy. + Only an explicit ``IG_PROXY`` is honoured. """ env = dict(base_env) env["INSTO_HOME"] = tmp_home @@ -111,9 +111,10 @@ def _build_subprocess_env( env["AIOGRAPI_USERNAME"] = str(account.get("username") or "") env["AIOGRAPI_PASSWORD"] = str(account.get("password") or "") env["AIOGRAPI_TOTP_SEED"] = _account_totp(account) - # Pooled account proxies are unreliable (frequently 302 on CONNECT, which - # surfaces as AuthRequiredProxyError). Only honour an explicit IG_PROXY, - # matching the saved-feed audit's default behaviour. + # Default to no proxy: the seeded session (client_settings) carries the + # account's device trust, so the login does not need one. Honour an + # explicit IG_PROXY when the caller supplies it, matching the saved-feed + # audit's default behaviour. proxy = base_env.get("IG_PROXY") if proxy: env["HIKERAPI_PROXY"] = str(proxy) diff --git a/tests/test_aiograpi_info_e2e.py b/tests/test_aiograpi_info_e2e.py index dc2f3b5..472520a 100644 --- a/tests/test_aiograpi_info_e2e.py +++ b/tests/test_aiograpi_info_e2e.py @@ -89,7 +89,7 @@ def test_build_subprocess_env_wires_aiograpi_creds() -> None: def test_build_subprocess_env_ignores_account_proxy_without_ig_proxy() -> None: - # Pooled account proxies are unreliable (often 302 on CONNECT); only an + # Default is no proxy (the seeded session carries device trust); only an # explicit IG_PROXY is honoured, matching the saved-feed audit default. account = { "username": "u",