Skip to content

Mobile menu doesn't close on pressing escape key  #7

Description

@AbhishekGMV

@thecodercoder

What
The burger mobile menu doesn't close on pressing escape key

Why
Edge case is not handled either in JS or CSS code

Fix
JavaScript code to close the modal

document.addEventListener("keyup", (event) => {
  if (event.keyCode === 27 && header.classList.contains("open")) {
    header.classList.remove("open");
    body.classList.remove("noscroll");
    fadeElems.forEach(function (element) {
      element.classList.remove("fade-in");
      element.classList.add("fade-out");
  });
  }
});

Also
Moving the code to close the modal into a function to maintain DRY

const closeModal = () => {
  header.classList.remove("open");
  body.classList.remove("noscroll");
  fadeElems.forEach(function (element) {
    element.classList.remove("fade-in");
    element.classList.add("fade-out");
  });
};

document.addEventListener("keyup", (event) => {
  if (event.keyCode == 27 && header.classList.contains("open")) {
    closeModal();
  }
});

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions