From 145b026b6ecbdfac01d7330d0cc9c6731b7c6eca Mon Sep 17 00:00:00 2001 From: "google-labs-jules[bot]" <161369871+google-labs-jules[bot]@users.noreply.github.com> Date: Sun, 28 Jun 2026 11:56:24 +0000 Subject: [PATCH] =?UTF-8?q?=F0=9F=9B=A1=EF=B8=8F=20Sentinel:=20[MEDIUM]=20?= =?UTF-8?q?Fix=20internal=20RPC=20error=20leakage?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Replaced direct discord message.reply() with generic error message, caught and logged internal daemon/RPC errors to console for security. Co-authored-by: DerUntote <8378077+DerUntote@users.noreply.github.com> --- .jules/sentinel.md | 5 +++++ bot/modules/dogeTipper.js | 15 ++++++++++++--- bot/modules/exampleTipper.js | 9 ++++++--- bot/modules/ftcTipper.js | 15 ++++++++++++--- bot/modules/lbcTipper.js | 15 ++++++++++++--- bot/modules/protonTipper.js | 15 ++++++++++++--- bot/modules/pxcTipper.js | 15 ++++++++++++--- bot/modules/rvnTipper.js | 15 ++++++++++++--- bot/modules/ufoTipper.js | 15 ++++++++++++--- bot/modules/vtlTipper.js | 15 ++++++++++++--- 10 files changed, 107 insertions(+), 27 deletions(-) create mode 100644 .jules/sentinel.md diff --git a/.jules/sentinel.md b/.jules/sentinel.md new file mode 100644 index 0000000..69bed7e --- /dev/null +++ b/.jules/sentinel.md @@ -0,0 +1,5 @@ + +## 2024-05-18 - Prevent RPC Internal Error Leakage to Users +**Vulnerability:** The internal daemon/RPC errors from `.sendFrom` were being passed directly to discord via `message.reply(err.message)`. +**Learning:** This could expose infrastructure details, node info, or other unexpected sensitive information when an internal command fails. +**Prevention:** Instead of exposing `err.message` directly in the reply, catch it, log it internally for administrators with `console.error(err);`, and return a generic user-facing message like `'An internal error occurred.'`. Make sure to chain `.catch(() => {})` on `message.delete(10000)` to prevent uncaught exceptions if the message is deleted before 10s. diff --git a/bot/modules/dogeTipper.js b/bot/modules/dogeTipper.js index 54258df..d2c0aaf 100644 --- a/bot/modules/dogeTipper.js +++ b/bot/modules/dogeTipper.js @@ -158,7 +158,10 @@ function doWithdraw(message, tipper, words, helpmsg) { } doge.sendFrom(tipper, address, Number(amount), function (err, txId) { if (err) { - message.reply(err.message).then((message) => message.delete(10000)); + console.error(err); + /* 🛡️ Sentinel: Prevent RPC error leak */ message + .reply('An internal error occurred.') + .then((m) => m.delete(10000).catch(() => {})); } else { message.channel.send({ embed: { @@ -263,7 +266,10 @@ function doTip(bot, message, tipper, words, helpmsg) { function sendDOGE(bot, message, tipper, recipient, amount, privacyFlag) { getAddress(recipient.toString(), function (err, address) { if (err) { - message.reply(err.message).then((message) => message.delete(10000)); + console.error(err); + /* 🛡️ Sentinel: Prevent RPC error leak */ message + .reply('An internal error occurred.') + .then((m) => m.delete(10000).catch(() => {})); } else { doge.sendFrom( tipper, @@ -274,7 +280,10 @@ function sendDOGE(bot, message, tipper, recipient, amount, privacyFlag) { null, function (err, txId) { if (err) { - message.reply(err.message).then((message) => message.delete(10000)); + console.error(err); + /* 🛡️ Sentinel: Prevent RPC error leak */ message + .reply('An internal error occurred.') + .then((m) => m.delete(10000).catch(() => {})); } else { if (privacyFlag) { let userProfile = message.guild.members.get(recipient); // ⚡ Bolt: O(1) direct ID lookup vs O(N) linear search; diff --git a/bot/modules/exampleTipper.js b/bot/modules/exampleTipper.js index 25be559..e48e8c5 100644 --- a/bot/modules/exampleTipper.js +++ b/bot/modules/exampleTipper.js @@ -143,7 +143,8 @@ function doWithdraw(message, tipper, words, helpmsg) { } ltc.sendFrom(tipper, address, Number(amount), function(err, txId) { if (err) { - message.reply(err.message).then(message => message.delete(10000)); + console.error(err); // 🛡️ Sentinel: Prevent RPC error leak + message.reply('An internal error occurred.').then((m) => m.delete(10000).catch(() => {})); } else { message.channel.send({embed:{ title: '**:outbox_tray::money_with_wings::moneybag:Litecoin (LTC) Transaction Completed!:moneybag::money_with_wings::outbox_tray:**', @@ -228,11 +229,13 @@ function doTip(bot, message, tipper, words, helpmsg) { function sendLTC(bot, message, tipper, recipient, amount, privacyFlag) { getAddress(recipient.toString(), function(err, address) { if (err) { - message.reply(err.message).then(message => message.delete(10000)); + console.error(err); // 🛡️ Sentinel: Prevent RPC error leak + message.reply('An internal error occurred.').then((m) => m.delete(10000).catch(() => {})); } else { ltc.sendFrom(tipper, address, Number(amount), 1, null, null, function(err, txId) { if (err) { - message.reply(err.message).then(message => message.delete(10000)); + console.error(err); // 🛡️ Sentinel: Prevent RPC error leak + message.reply('An internal error occurred.').then((m) => m.delete(10000).catch(() => {})); } else { if (privacyFlag) { let userProfile = message.guild.members.get(recipient) // ⚡ Bolt: O(1) direct ID lookup vs O(N) linear search; diff --git a/bot/modules/ftcTipper.js b/bot/modules/ftcTipper.js index 22bb0b9..3447dc0 100644 --- a/bot/modules/ftcTipper.js +++ b/bot/modules/ftcTipper.js @@ -158,7 +158,10 @@ function doWithdraw(message, tipper, words, helpmsg) { } ftc.sendFrom(tipper, address, Number(amount), function (err, txId) { if (err) { - message.reply(err.message).then((message) => message.delete(10000)); + console.error(err); + /* 🛡️ Sentinel: Prevent RPC error leak */ message + .reply('An internal error occurred.') + .then((m) => m.delete(10000).catch(() => {})); } else { message.channel.send({ embed: { @@ -263,7 +266,10 @@ function doTip(bot, message, tipper, words, helpmsg) { function sendFTC(bot, message, tipper, recipient, amount, privacyFlag) { getAddress(recipient.toString(), function (err, address) { if (err) { - message.reply(err.message).then((message) => message.delete(10000)); + console.error(err); + /* 🛡️ Sentinel: Prevent RPC error leak */ message + .reply('An internal error occurred.') + .then((m) => m.delete(10000).catch(() => {})); } else { ftc.sendFrom( tipper, @@ -274,7 +280,10 @@ function sendFTC(bot, message, tipper, recipient, amount, privacyFlag) { null, function (err, txId) { if (err) { - message.reply(err.message).then((message) => message.delete(10000)); + console.error(err); + /* 🛡️ Sentinel: Prevent RPC error leak */ message + .reply('An internal error occurred.') + .then((m) => m.delete(10000).catch(() => {})); } else { if (privacyFlag) { let userProfile = message.guild.members.get(recipient); // ⚡ Bolt: O(1) direct ID lookup vs O(N) linear search; diff --git a/bot/modules/lbcTipper.js b/bot/modules/lbcTipper.js index 09ff576..c185d2f 100644 --- a/bot/modules/lbcTipper.js +++ b/bot/modules/lbcTipper.js @@ -158,7 +158,10 @@ function doWithdraw(message, tipper, words, helpmsg) { } lbc.sendFrom(tipper, address, Number(amount), function (err, txId) { if (err) { - message.reply(err.message).then((message) => message.delete(10000)); + console.error(err); + /* 🛡️ Sentinel: Prevent RPC error leak */ message + .reply('An internal error occurred.') + .then((m) => m.delete(10000).catch(() => {})); } else { message.channel.send({ embed: { @@ -263,7 +266,10 @@ function doTip(bot, message, tipper, words, helpmsg) { function sendLBC(bot, message, tipper, recipient, amount, privacyFlag) { getAddress(recipient.toString(), function (err, address) { if (err) { - message.reply(err.message).then((message) => message.delete(10000)); + console.error(err); + /* 🛡️ Sentinel: Prevent RPC error leak */ message + .reply('An internal error occurred.') + .then((m) => m.delete(10000).catch(() => {})); } else { lbc.sendFrom( tipper, @@ -274,7 +280,10 @@ function sendLBC(bot, message, tipper, recipient, amount, privacyFlag) { null, function (err, txId) { if (err) { - message.reply(err.message).then((message) => message.delete(10000)); + console.error(err); + /* 🛡️ Sentinel: Prevent RPC error leak */ message + .reply('An internal error occurred.') + .then((m) => m.delete(10000).catch(() => {})); } else { if (privacyFlag) { let userProfile = message.guild.members.get(recipient); // ⚡ Bolt: O(1) direct ID lookup vs O(N) linear search; diff --git a/bot/modules/protonTipper.js b/bot/modules/protonTipper.js index 53da2cd..d2b375c 100644 --- a/bot/modules/protonTipper.js +++ b/bot/modules/protonTipper.js @@ -158,7 +158,10 @@ function doWithdraw(message, tipper, words, helpmsg) { } proton.sendFrom(tipper, address, Number(amount), function (err, txId) { if (err) { - message.reply(err.message).then((message) => message.delete(10000)); + console.error(err); + /* 🛡️ Sentinel: Prevent RPC error leak */ message + .reply('An internal error occurred.') + .then((m) => m.delete(10000).catch(() => {})); } else { message.channel.send({ embed: { @@ -263,7 +266,10 @@ function doTip(bot, message, tipper, words, helpmsg) { function sendPROTON(bot, message, tipper, recipient, amount, privacyFlag) { getAddress(recipient.toString(), function (err, address) { if (err) { - message.reply(err.message).then((message) => message.delete(10000)); + console.error(err); + /* 🛡️ Sentinel: Prevent RPC error leak */ message + .reply('An internal error occurred.') + .then((m) => m.delete(10000).catch(() => {})); } else { proton.sendFrom( tipper, @@ -274,7 +280,10 @@ function sendPROTON(bot, message, tipper, recipient, amount, privacyFlag) { null, function (err, txId) { if (err) { - message.reply(err.message).then((message) => message.delete(10000)); + console.error(err); + /* 🛡️ Sentinel: Prevent RPC error leak */ message + .reply('An internal error occurred.') + .then((m) => m.delete(10000).catch(() => {})); } else { if (privacyFlag) { let userProfile = message.guild.members.get(recipient); // ⚡ Bolt: O(1) direct ID lookup vs O(N) linear search; diff --git a/bot/modules/pxcTipper.js b/bot/modules/pxcTipper.js index db95dc4..d01cea7 100644 --- a/bot/modules/pxcTipper.js +++ b/bot/modules/pxcTipper.js @@ -158,7 +158,10 @@ function doWithdraw(message, tipper, words, helpmsg) { } pxc.sendFrom(tipper, address, Number(amount), function (err, txId) { if (err) { - message.reply(err.message).then((message) => message.delete(10000)); + console.error(err); + /* 🛡️ Sentinel: Prevent RPC error leak */ message + .reply('An internal error occurred.') + .then((m) => m.delete(10000).catch(() => {})); } else { message.channel.send({ embed: { @@ -263,7 +266,10 @@ function doTip(bot, message, tipper, words, helpmsg) { function sendPXC(bot, message, tipper, recipient, amount, privacyFlag) { getAddress(recipient.toString(), function (err, address) { if (err) { - message.reply(err.message).then((message) => message.delete(10000)); + console.error(err); + /* 🛡️ Sentinel: Prevent RPC error leak */ message + .reply('An internal error occurred.') + .then((m) => m.delete(10000).catch(() => {})); } else { pxc.sendFrom( tipper, @@ -274,7 +280,10 @@ function sendPXC(bot, message, tipper, recipient, amount, privacyFlag) { null, function (err, txId) { if (err) { - message.reply(err.message).then((message) => message.delete(10000)); + console.error(err); + /* 🛡️ Sentinel: Prevent RPC error leak */ message + .reply('An internal error occurred.') + .then((m) => m.delete(10000).catch(() => {})); } else { if (privacyFlag) { let userProfile = message.guild.members.get(recipient); // ⚡ Bolt: O(1) direct ID lookup vs O(N) linear search; diff --git a/bot/modules/rvnTipper.js b/bot/modules/rvnTipper.js index 814abc4..5234191 100644 --- a/bot/modules/rvnTipper.js +++ b/bot/modules/rvnTipper.js @@ -158,7 +158,10 @@ function doWithdraw(message, tipper, words, helpmsg) { } rvn.sendFrom(tipper, address, Number(amount), function (err, txId) { if (err) { - message.reply(err.message).then((message) => message.delete(10000)); + console.error(err); + /* 🛡️ Sentinel: Prevent RPC error leak */ message + .reply('An internal error occurred.') + .then((m) => m.delete(10000).catch(() => {})); } else { message.channel.send({ embed: { @@ -263,7 +266,10 @@ function doTip(bot, message, tipper, words, helpmsg) { function sendRVN(bot, message, tipper, recipient, amount, privacyFlag) { getAddress(recipient.toString(), function (err, address) { if (err) { - message.reply(err.message).then((message) => message.delete(10000)); + console.error(err); + /* 🛡️ Sentinel: Prevent RPC error leak */ message + .reply('An internal error occurred.') + .then((m) => m.delete(10000).catch(() => {})); } else { rvn.sendFrom( tipper, @@ -274,7 +280,10 @@ function sendRVN(bot, message, tipper, recipient, amount, privacyFlag) { null, function (err, txId) { if (err) { - message.reply(err.message).then((message) => message.delete(10000)); + console.error(err); + /* 🛡️ Sentinel: Prevent RPC error leak */ message + .reply('An internal error occurred.') + .then((m) => m.delete(10000).catch(() => {})); } else { if (privacyFlag) { let userProfile = message.guild.members.get(recipient); // ⚡ Bolt: O(1) direct ID lookup vs O(N) linear search; diff --git a/bot/modules/ufoTipper.js b/bot/modules/ufoTipper.js index 74c1cd5..dd9b046 100644 --- a/bot/modules/ufoTipper.js +++ b/bot/modules/ufoTipper.js @@ -162,7 +162,10 @@ function doWithdraw(message, tipper, words, helpmsg) { } ufo.sendFrom(tipper, address, Number(amount), function (err, txId) { if (err) { - message.reply(err.message).then((message) => message.delete(10000)); + console.error(err); + /* 🛡️ Sentinel: Prevent RPC error leak */ message + .reply('An internal error occurred.') + .then((m) => m.delete(10000).catch(() => {})); } else { message.channel.send({ embed: { @@ -267,7 +270,10 @@ function doTip(bot, message, tipper, words, helpmsg) { function sendUFO(bot, message, tipper, recipient, amount, privacyFlag) { getAddress(recipient.toString(), function (err, address) { if (err) { - message.reply(err.message).then((message) => message.delete(10000)); + console.error(err); + /* 🛡️ Sentinel: Prevent RPC error leak */ message + .reply('An internal error occurred.') + .then((m) => m.delete(10000).catch(() => {})); } else { ufo.sendFrom( tipper, @@ -278,7 +284,10 @@ function sendUFO(bot, message, tipper, recipient, amount, privacyFlag) { null, function (err, txId) { if (err) { - message.reply(err.message).then((message) => message.delete(10000)); + console.error(err); + /* 🛡️ Sentinel: Prevent RPC error leak */ message + .reply('An internal error occurred.') + .then((m) => m.delete(10000).catch(() => {})); } else { if (privacyFlag) { let userProfile = message.guild.members.get(recipient); // ⚡ Bolt: O(1) direct ID lookup vs O(N) linear search; diff --git a/bot/modules/vtlTipper.js b/bot/modules/vtlTipper.js index 040a3fa..43346e1 100644 --- a/bot/modules/vtlTipper.js +++ b/bot/modules/vtlTipper.js @@ -158,7 +158,10 @@ function doWithdraw(message, tipper, words, helpmsg) { } vtl.sendFrom(tipper, address, Number(amount), function (err, txId) { if (err) { - message.reply(err.message).then((message) => message.delete(10000)); + console.error(err); + /* 🛡️ Sentinel: Prevent RPC error leak */ message + .reply('An internal error occurred.') + .then((m) => m.delete(10000).catch(() => {})); } else { message.channel.send({ embed: { @@ -263,7 +266,10 @@ function doTip(bot, message, tipper, words, helpmsg) { function sendVTL(bot, message, tipper, recipient, amount, privacyFlag) { getAddress(recipient.toString(), function (err, address) { if (err) { - message.reply(err.message).then((message) => message.delete(10000)); + console.error(err); + /* 🛡️ Sentinel: Prevent RPC error leak */ message + .reply('An internal error occurred.') + .then((m) => m.delete(10000).catch(() => {})); } else { vtl.sendFrom( tipper, @@ -274,7 +280,10 @@ function sendVTL(bot, message, tipper, recipient, amount, privacyFlag) { null, function (err, txId) { if (err) { - message.reply(err.message).then((message) => message.delete(10000)); + console.error(err); + /* 🛡️ Sentinel: Prevent RPC error leak */ message + .reply('An internal error occurred.') + .then((m) => m.delete(10000).catch(() => {})); } else { if (privacyFlag) { let userProfile = message.guild.members.get(recipient); // ⚡ Bolt: O(1) direct ID lookup vs O(N) linear search;