diff --git a/.jules/bolt.md b/.jules/bolt.md index e79ba97..f290f38 100644 --- a/.jules/bolt.md +++ b/.jules/bolt.md @@ -1,3 +1,6 @@ ## 2024-05-17 - O(N) lookup optimizations for Discord.js **Learning:** Found two O(N) operations in bot.js and module Tipper scripts when looking up members or guild count. **Action:** Replaced `bot.guilds.array().length` with `bot.guilds.size` (O(1)) and `message.guild.members.find('id', recipient)` with `message.guild.members.get(recipient)` (O(1)). +## 2024-07-04 - [Optimized token extraction] +**Learning:** Codebase-specific performance pattern: Avoid using `.trim().split(' ').filter(...)` for token extraction in message parsing, as it allocates intermediate arrays. +**Action:** Use `.match(/\S+/g) || []` instead to extract words efficiently. Use `(match || [''])[0]` as a safe string fallback when chaining methods if necessary. diff --git a/bot/modules/dogeTipper.js b/bot/modules/dogeTipper.js index 54258df..fec503f 100644 --- a/bot/modules/dogeTipper.js +++ b/bot/modules/dogeTipper.js @@ -20,11 +20,9 @@ exports.tipdoge = { process: async function (bot, msg, suffix) { let tipper = msg.author.id.replace('!', ''), words = msg.content - .trim() - .split(' ') - .filter(function (n) { - return n !== ''; - }), + + // Bolt: Optimized token extraction to prevent intermediate array allocations + .match(/\S+/g) || [], subcommand = words.length >= 2 ? words[1] : 'help', helpmsg = '__**Dogecoin (DOGE) Tipper**__\nTransaction Fees: **' + diff --git a/bot/modules/exampleTipper.js b/bot/modules/exampleTipper.js index 25be559..1c4d67f 100644 --- a/bot/modules/exampleTipper.js +++ b/bot/modules/exampleTipper.js @@ -29,11 +29,9 @@ exports.tipltc = { process: async function(bot, msg, suffix) { let tipper = msg.author.id.replace('!', ''), words = msg.content - .trim() - .split(' ') - .filter(function(n) { - return n !== ''; - }), + + // Bolt: Optimized token extraction to prevent intermediate array allocations + .match(/\S+/g) || [], subcommand = words.length >= 2 ? words[1] : 'help', helpmsg = '__**Litecoin (LTC) Tipper**__\nTransaction Fees: **' + paytxfee + '**\n **!tipltc** : Displays This Message\n **!tipltc balance** : get your balance\n **!tipltc deposit** : get address for your deposits\n **!tipltc withdraw
** : withdraw coins to specified address\n **!tipltc <@user> ** :mention a user with @ and then the amount to tip them\n **!tipltc private ** : put private before Mentioning a user to tip them privately.\n\n **<> : Replace with appropriate value.**', diff --git a/bot/modules/ftcTipper.js b/bot/modules/ftcTipper.js index 22bb0b9..4448202 100644 --- a/bot/modules/ftcTipper.js +++ b/bot/modules/ftcTipper.js @@ -20,11 +20,9 @@ exports.tipftc = { process: async function (bot, msg, suffix) { let tipper = msg.author.id.replace('!', ''), words = msg.content - .trim() - .split(' ') - .filter(function (n) { - return n !== ''; - }), + + // Bolt: Optimized token extraction to prevent intermediate array allocations + .match(/\S+/g) || [], subcommand = words.length >= 2 ? words[1] : 'help', helpmsg = '__**Feathercoin (FTC) Tipper**__\nTransaction Fees: **' + diff --git a/bot/modules/lbcTipper.js b/bot/modules/lbcTipper.js index 09ff576..64d9aab 100644 --- a/bot/modules/lbcTipper.js +++ b/bot/modules/lbcTipper.js @@ -20,11 +20,9 @@ exports.tiplbc = { process: async function (bot, msg, suffix) { let tipper = msg.author.id.replace('!', ''), words = msg.content - .trim() - .split(' ') - .filter(function (n) { - return n !== ''; - }), + + // Bolt: Optimized token extraction to prevent intermediate array allocations + .match(/\S+/g) || [], subcommand = words.length >= 2 ? words[1] : 'help', helpmsg = '__**LBRY Credit (LBC) Tipper**__\nTransaction Fees: **' + diff --git a/bot/modules/protonTipper.js b/bot/modules/protonTipper.js index 53da2cd..20ed012 100644 --- a/bot/modules/protonTipper.js +++ b/bot/modules/protonTipper.js @@ -20,11 +20,9 @@ exports.tipproton = { process: async function (bot, msg, suffix) { let tipper = msg.author.id.replace('!', ''), words = msg.content - .trim() - .split(' ') - .filter(function (n) { - return n !== ''; - }), + + // Bolt: Optimized token extraction to prevent intermediate array allocations + .match(/\S+/g) || [], subcommand = words.length >= 2 ? words[1] : 'help', helpmsg = '__**Proton (PROTON) Tipper**__\nTransaction Fees: **' + diff --git a/bot/modules/pxcTipper.js b/bot/modules/pxcTipper.js index db95dc4..38b83f3 100644 --- a/bot/modules/pxcTipper.js +++ b/bot/modules/pxcTipper.js @@ -20,11 +20,9 @@ exports.tippxc = { process: async function (bot, msg, suffix) { let tipper = msg.author.id.replace('!', ''), words = msg.content - .trim() - .split(' ') - .filter(function (n) { - return n !== ''; - }), + + // Bolt: Optimized token extraction to prevent intermediate array allocations + .match(/\S+/g) || [], subcommand = words.length >= 2 ? words[1] : 'help', helpmsg = '__**Phoenixcoin (PXC) Tipper**__\nTransaction Fees: **' + diff --git a/bot/modules/rvnTipper.js b/bot/modules/rvnTipper.js index 814abc4..7ba87f7 100644 --- a/bot/modules/rvnTipper.js +++ b/bot/modules/rvnTipper.js @@ -20,11 +20,9 @@ exports.tiprvn = { process: async function (bot, msg, suffix) { let tipper = msg.author.id.replace('!', ''), words = msg.content - .trim() - .split(' ') - .filter(function (n) { - return n !== ''; - }), + + // Bolt: Optimized token extraction to prevent intermediate array allocations + .match(/\S+/g) || [], subcommand = words.length >= 2 ? words[1] : 'help', helpmsg = '__**Ravencoin (RVN) Tipper**__\nTransaction Fees: **' + diff --git a/bot/modules/ufoTipper.js b/bot/modules/ufoTipper.js index 74c1cd5..2448584 100644 --- a/bot/modules/ufoTipper.js +++ b/bot/modules/ufoTipper.js @@ -20,11 +20,9 @@ exports.tipufo = { process: async function (bot, msg, suffix) { let tipper = msg.author.id.replace('!', ''), words = msg.content - .trim() - .split(' ') - .filter(function (n) { - return n !== ''; - }), + + // Bolt: Optimized token extraction to prevent intermediate array allocations + .match(/\S+/g) || [], subcommand = words.length >= 2 ? words[1] : 'help', helpmsg = '__**Uniform Fiscal Object (UFO) Tipper**__\nTransaction Fees: **' + diff --git a/bot/modules/vtlTipper.js b/bot/modules/vtlTipper.js index 040a3fa..fd7141c 100644 --- a/bot/modules/vtlTipper.js +++ b/bot/modules/vtlTipper.js @@ -20,11 +20,9 @@ exports.tipvtl = { process: async function (bot, msg, suffix) { let tipper = msg.author.id.replace('!', ''), words = msg.content - .trim() - .split(' ') - .filter(function (n) { - return n !== ''; - }), + + // Bolt: Optimized token extraction to prevent intermediate array allocations + .match(/\S+/g) || [], subcommand = words.length >= 2 ? words[1] : 'help', helpmsg = '__**Vertical (VTL) Tipper**__\nTransaction Fees: **' +