From 2b37d832aaf7e073e6b297940e9df22a03cfca12 Mon Sep 17 00:00:00 2001 From: "google-labs-jules[bot]" <161369871+google-labs-jules[bot]@users.noreply.github.com> Date: Wed, 8 Jul 2026 11:40:15 +0000 Subject: [PATCH] =?UTF-8?q?=F0=9F=9B=A1=EF=B8=8F=20Sentinel:=20[CRITICAL]?= =?UTF-8?q?=20Fix=20internal=20error=20information=20leakage?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 🚨 Severity: CRITICAL 💡 Vulnerability: Internal RPC errors (like bitcoind-rpc connection issues) were being directly sent to users in Discord via message.reply(err.message). This leaks system internals, database details, and backend connection details, potentially exposing attack surface. 🎯 Impact: Attackers could gain insights into the system's infrastructure and error handling mechanisms to craft further attacks. 🔧 Fix: Replaced message.reply(err.message) with a generic, sanitized error message. Internal errors are now securely logged via console.error(err) for developers. Added a .catch() handler for message deletion to prevent unhandled promise rejections on already-deleted messages. Applied across all Tipper modules. ✅ Verification: Ran syntax validation (node -c) on all modified *Tipper.js modules to ensure no regression was introduced. Verified via code review. Co-authored-by: DerUntote <8378077+DerUntote@users.noreply.github.com> --- .jules/sentinel.md | 4 ++++ bot/modules/dogeTipper.js | 6 +++--- bot/modules/exampleTipper.js | 6 +++--- bot/modules/ftcTipper.js | 6 +++--- bot/modules/lbcTipper.js | 6 +++--- bot/modules/protonTipper.js | 6 +++--- bot/modules/pxcTipper.js | 6 +++--- bot/modules/rvnTipper.js | 6 +++--- bot/modules/ufoTipper.js | 6 +++--- bot/modules/vtlTipper.js | 6 +++--- 10 files changed, 31 insertions(+), 27 deletions(-) create mode 100644 .jules/sentinel.md diff --git a/.jules/sentinel.md b/.jules/sentinel.md new file mode 100644 index 0000000..c995d1e --- /dev/null +++ b/.jules/sentinel.md @@ -0,0 +1,4 @@ +## 2024-06-03 - Exposing Internal RPC Errors to Users +**Vulnerability:** Internal RPC errors were being directly sent to users in Discord via `message.reply(err.message)`, exposing system internals and sensitive backend details. +**Learning:** Direct pass-through of backend errors (like `bitcoind-rpc` connection errors) to frontend interfaces like Discord messages creates a significant information leakage risk. +**Prevention:** Always log full errors internally via `console.error(err)` and present only generic, sanitized error messages (e.g., "An error occurred") to end-users. diff --git a/bot/modules/dogeTipper.js b/bot/modules/dogeTipper.js index 54258df..1c1afdf 100644 --- a/bot/modules/dogeTipper.js +++ b/bot/modules/dogeTipper.js @@ -158,7 +158,7 @@ function doWithdraw(message, tipper, words, helpmsg) { } doge.sendFrom(tipper, address, Number(amount), function (err, txId) { if (err) { - message.reply(err.message).then((message) => message.delete(10000)); + console.error(err); message.reply("An error occurred while processing your request.").then((m) => m.delete(10000).catch(() => {})); } else { message.channel.send({ embed: { @@ -263,7 +263,7 @@ function doTip(bot, message, tipper, words, helpmsg) { function sendDOGE(bot, message, tipper, recipient, amount, privacyFlag) { getAddress(recipient.toString(), function (err, address) { if (err) { - message.reply(err.message).then((message) => message.delete(10000)); + console.error(err); message.reply("An error occurred while processing your request.").then((m) => m.delete(10000).catch(() => {})); } else { doge.sendFrom( tipper, @@ -274,7 +274,7 @@ function sendDOGE(bot, message, tipper, recipient, amount, privacyFlag) { null, function (err, txId) { if (err) { - message.reply(err.message).then((message) => message.delete(10000)); + console.error(err); message.reply("An error occurred while processing your request.").then((m) => m.delete(10000).catch(() => {})); } else { if (privacyFlag) { let userProfile = message.guild.members.get(recipient); // ⚡ Bolt: O(1) direct ID lookup vs O(N) linear search; diff --git a/bot/modules/exampleTipper.js b/bot/modules/exampleTipper.js index 25be559..5cd4dec 100644 --- a/bot/modules/exampleTipper.js +++ b/bot/modules/exampleTipper.js @@ -143,7 +143,7 @@ function doWithdraw(message, tipper, words, helpmsg) { } ltc.sendFrom(tipper, address, Number(amount), function(err, txId) { if (err) { - message.reply(err.message).then(message => message.delete(10000)); + console.error(err); message.reply("An error occurred while processing your request.").then((m) => m.delete(10000).catch(() => {})); } else { message.channel.send({embed:{ title: '**:outbox_tray::money_with_wings::moneybag:Litecoin (LTC) Transaction Completed!:moneybag::money_with_wings::outbox_tray:**', @@ -228,11 +228,11 @@ function doTip(bot, message, tipper, words, helpmsg) { function sendLTC(bot, message, tipper, recipient, amount, privacyFlag) { getAddress(recipient.toString(), function(err, address) { if (err) { - message.reply(err.message).then(message => message.delete(10000)); + console.error(err); message.reply("An error occurred while processing your request.").then((m) => m.delete(10000).catch(() => {})); } else { ltc.sendFrom(tipper, address, Number(amount), 1, null, null, function(err, txId) { if (err) { - message.reply(err.message).then(message => message.delete(10000)); + console.error(err); message.reply("An error occurred while processing your request.").then((m) => m.delete(10000).catch(() => {})); } else { if (privacyFlag) { let userProfile = message.guild.members.get(recipient) // ⚡ Bolt: O(1) direct ID lookup vs O(N) linear search; diff --git a/bot/modules/ftcTipper.js b/bot/modules/ftcTipper.js index 22bb0b9..ec09e68 100644 --- a/bot/modules/ftcTipper.js +++ b/bot/modules/ftcTipper.js @@ -158,7 +158,7 @@ function doWithdraw(message, tipper, words, helpmsg) { } ftc.sendFrom(tipper, address, Number(amount), function (err, txId) { if (err) { - message.reply(err.message).then((message) => message.delete(10000)); + console.error(err); message.reply("An error occurred while processing your request.").then((m) => m.delete(10000).catch(() => {})); } else { message.channel.send({ embed: { @@ -263,7 +263,7 @@ function doTip(bot, message, tipper, words, helpmsg) { function sendFTC(bot, message, tipper, recipient, amount, privacyFlag) { getAddress(recipient.toString(), function (err, address) { if (err) { - message.reply(err.message).then((message) => message.delete(10000)); + console.error(err); message.reply("An error occurred while processing your request.").then((m) => m.delete(10000).catch(() => {})); } else { ftc.sendFrom( tipper, @@ -274,7 +274,7 @@ function sendFTC(bot, message, tipper, recipient, amount, privacyFlag) { null, function (err, txId) { if (err) { - message.reply(err.message).then((message) => message.delete(10000)); + console.error(err); message.reply("An error occurred while processing your request.").then((m) => m.delete(10000).catch(() => {})); } else { if (privacyFlag) { let userProfile = message.guild.members.get(recipient); // ⚡ Bolt: O(1) direct ID lookup vs O(N) linear search; diff --git a/bot/modules/lbcTipper.js b/bot/modules/lbcTipper.js index 09ff576..96dce65 100644 --- a/bot/modules/lbcTipper.js +++ b/bot/modules/lbcTipper.js @@ -158,7 +158,7 @@ function doWithdraw(message, tipper, words, helpmsg) { } lbc.sendFrom(tipper, address, Number(amount), function (err, txId) { if (err) { - message.reply(err.message).then((message) => message.delete(10000)); + console.error(err); message.reply("An error occurred while processing your request.").then((m) => m.delete(10000).catch(() => {})); } else { message.channel.send({ embed: { @@ -263,7 +263,7 @@ function doTip(bot, message, tipper, words, helpmsg) { function sendLBC(bot, message, tipper, recipient, amount, privacyFlag) { getAddress(recipient.toString(), function (err, address) { if (err) { - message.reply(err.message).then((message) => message.delete(10000)); + console.error(err); message.reply("An error occurred while processing your request.").then((m) => m.delete(10000).catch(() => {})); } else { lbc.sendFrom( tipper, @@ -274,7 +274,7 @@ function sendLBC(bot, message, tipper, recipient, amount, privacyFlag) { null, function (err, txId) { if (err) { - message.reply(err.message).then((message) => message.delete(10000)); + console.error(err); message.reply("An error occurred while processing your request.").then((m) => m.delete(10000).catch(() => {})); } else { if (privacyFlag) { let userProfile = message.guild.members.get(recipient); // ⚡ Bolt: O(1) direct ID lookup vs O(N) linear search; diff --git a/bot/modules/protonTipper.js b/bot/modules/protonTipper.js index 53da2cd..f7a30eb 100644 --- a/bot/modules/protonTipper.js +++ b/bot/modules/protonTipper.js @@ -158,7 +158,7 @@ function doWithdraw(message, tipper, words, helpmsg) { } proton.sendFrom(tipper, address, Number(amount), function (err, txId) { if (err) { - message.reply(err.message).then((message) => message.delete(10000)); + console.error(err); message.reply("An error occurred while processing your request.").then((m) => m.delete(10000).catch(() => {})); } else { message.channel.send({ embed: { @@ -263,7 +263,7 @@ function doTip(bot, message, tipper, words, helpmsg) { function sendPROTON(bot, message, tipper, recipient, amount, privacyFlag) { getAddress(recipient.toString(), function (err, address) { if (err) { - message.reply(err.message).then((message) => message.delete(10000)); + console.error(err); message.reply("An error occurred while processing your request.").then((m) => m.delete(10000).catch(() => {})); } else { proton.sendFrom( tipper, @@ -274,7 +274,7 @@ function sendPROTON(bot, message, tipper, recipient, amount, privacyFlag) { null, function (err, txId) { if (err) { - message.reply(err.message).then((message) => message.delete(10000)); + console.error(err); message.reply("An error occurred while processing your request.").then((m) => m.delete(10000).catch(() => {})); } else { if (privacyFlag) { let userProfile = message.guild.members.get(recipient); // ⚡ Bolt: O(1) direct ID lookup vs O(N) linear search; diff --git a/bot/modules/pxcTipper.js b/bot/modules/pxcTipper.js index db95dc4..27be3c9 100644 --- a/bot/modules/pxcTipper.js +++ b/bot/modules/pxcTipper.js @@ -158,7 +158,7 @@ function doWithdraw(message, tipper, words, helpmsg) { } pxc.sendFrom(tipper, address, Number(amount), function (err, txId) { if (err) { - message.reply(err.message).then((message) => message.delete(10000)); + console.error(err); message.reply("An error occurred while processing your request.").then((m) => m.delete(10000).catch(() => {})); } else { message.channel.send({ embed: { @@ -263,7 +263,7 @@ function doTip(bot, message, tipper, words, helpmsg) { function sendPXC(bot, message, tipper, recipient, amount, privacyFlag) { getAddress(recipient.toString(), function (err, address) { if (err) { - message.reply(err.message).then((message) => message.delete(10000)); + console.error(err); message.reply("An error occurred while processing your request.").then((m) => m.delete(10000).catch(() => {})); } else { pxc.sendFrom( tipper, @@ -274,7 +274,7 @@ function sendPXC(bot, message, tipper, recipient, amount, privacyFlag) { null, function (err, txId) { if (err) { - message.reply(err.message).then((message) => message.delete(10000)); + console.error(err); message.reply("An error occurred while processing your request.").then((m) => m.delete(10000).catch(() => {})); } else { if (privacyFlag) { let userProfile = message.guild.members.get(recipient); // ⚡ Bolt: O(1) direct ID lookup vs O(N) linear search; diff --git a/bot/modules/rvnTipper.js b/bot/modules/rvnTipper.js index 814abc4..b2480b6 100644 --- a/bot/modules/rvnTipper.js +++ b/bot/modules/rvnTipper.js @@ -158,7 +158,7 @@ function doWithdraw(message, tipper, words, helpmsg) { } rvn.sendFrom(tipper, address, Number(amount), function (err, txId) { if (err) { - message.reply(err.message).then((message) => message.delete(10000)); + console.error(err); message.reply("An error occurred while processing your request.").then((m) => m.delete(10000).catch(() => {})); } else { message.channel.send({ embed: { @@ -263,7 +263,7 @@ function doTip(bot, message, tipper, words, helpmsg) { function sendRVN(bot, message, tipper, recipient, amount, privacyFlag) { getAddress(recipient.toString(), function (err, address) { if (err) { - message.reply(err.message).then((message) => message.delete(10000)); + console.error(err); message.reply("An error occurred while processing your request.").then((m) => m.delete(10000).catch(() => {})); } else { rvn.sendFrom( tipper, @@ -274,7 +274,7 @@ function sendRVN(bot, message, tipper, recipient, amount, privacyFlag) { null, function (err, txId) { if (err) { - message.reply(err.message).then((message) => message.delete(10000)); + console.error(err); message.reply("An error occurred while processing your request.").then((m) => m.delete(10000).catch(() => {})); } else { if (privacyFlag) { let userProfile = message.guild.members.get(recipient); // ⚡ Bolt: O(1) direct ID lookup vs O(N) linear search; diff --git a/bot/modules/ufoTipper.js b/bot/modules/ufoTipper.js index 74c1cd5..883f196 100644 --- a/bot/modules/ufoTipper.js +++ b/bot/modules/ufoTipper.js @@ -162,7 +162,7 @@ function doWithdraw(message, tipper, words, helpmsg) { } ufo.sendFrom(tipper, address, Number(amount), function (err, txId) { if (err) { - message.reply(err.message).then((message) => message.delete(10000)); + console.error(err); message.reply("An error occurred while processing your request.").then((m) => m.delete(10000).catch(() => {})); } else { message.channel.send({ embed: { @@ -267,7 +267,7 @@ function doTip(bot, message, tipper, words, helpmsg) { function sendUFO(bot, message, tipper, recipient, amount, privacyFlag) { getAddress(recipient.toString(), function (err, address) { if (err) { - message.reply(err.message).then((message) => message.delete(10000)); + console.error(err); message.reply("An error occurred while processing your request.").then((m) => m.delete(10000).catch(() => {})); } else { ufo.sendFrom( tipper, @@ -278,7 +278,7 @@ function sendUFO(bot, message, tipper, recipient, amount, privacyFlag) { null, function (err, txId) { if (err) { - message.reply(err.message).then((message) => message.delete(10000)); + console.error(err); message.reply("An error occurred while processing your request.").then((m) => m.delete(10000).catch(() => {})); } else { if (privacyFlag) { let userProfile = message.guild.members.get(recipient); // ⚡ Bolt: O(1) direct ID lookup vs O(N) linear search; diff --git a/bot/modules/vtlTipper.js b/bot/modules/vtlTipper.js index 040a3fa..e6b7afd 100644 --- a/bot/modules/vtlTipper.js +++ b/bot/modules/vtlTipper.js @@ -158,7 +158,7 @@ function doWithdraw(message, tipper, words, helpmsg) { } vtl.sendFrom(tipper, address, Number(amount), function (err, txId) { if (err) { - message.reply(err.message).then((message) => message.delete(10000)); + console.error(err); message.reply("An error occurred while processing your request.").then((m) => m.delete(10000).catch(() => {})); } else { message.channel.send({ embed: { @@ -263,7 +263,7 @@ function doTip(bot, message, tipper, words, helpmsg) { function sendVTL(bot, message, tipper, recipient, amount, privacyFlag) { getAddress(recipient.toString(), function (err, address) { if (err) { - message.reply(err.message).then((message) => message.delete(10000)); + console.error(err); message.reply("An error occurred while processing your request.").then((m) => m.delete(10000).catch(() => {})); } else { vtl.sendFrom( tipper, @@ -274,7 +274,7 @@ function sendVTL(bot, message, tipper, recipient, amount, privacyFlag) { null, function (err, txId) { if (err) { - message.reply(err.message).then((message) => message.delete(10000)); + console.error(err); message.reply("An error occurred while processing your request.").then((m) => m.delete(10000).catch(() => {})); } else { if (privacyFlag) { let userProfile = message.guild.members.get(recipient); // ⚡ Bolt: O(1) direct ID lookup vs O(N) linear search;