From 01478d94d049e50097e9a059be37932a36a5f747 Mon Sep 17 00:00:00 2001 From: Thomas Arrow Date: Wed, 10 Jun 2026 12:04:11 +0100 Subject: [PATCH 1/9] testing: use production environment for e2e tests When using the development environment if a request fails the screen is blocked by a helpful debugging message. I believe the `login` request that happens in the background regularly fails since we updated passport in the platform api. The e2e tests rely on the main branch of api to test against which explains why we transition into status tests failing without merging a PR that had failing status tests. Bug: T428389 --- .env.development.test | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.env.development.test b/.env.development.test index 7246f560..7f8e0494 100644 --- a/.env.development.test +++ b/.env.development.test @@ -1,5 +1,5 @@ # For running GitHub Actions tests using docker -NODE_ENV=development +NODE_ENV=production VUE_APP_API_URL=http://host.docker.internal:8082 VUE_APP_API_MOCK=0 VUE_APP_RECAPTCHA_SITE_KEY="6LeHzbMUAAAAABjNp0vILaWr5ZeYHmteF7rGuZNV" # todo replace with test key From a6aea6907e226918f53375fe5169ad63b01f6926 Mon Sep 17 00:00:00 2001 From: Thomas Arrow Date: Wed, 10 Jun 2026 12:25:24 +0100 Subject: [PATCH 2/9] remove -d to see if there are logs causing this to fail on GH but not on my machine --- .github/workflows/browser-tests.js.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/browser-tests.js.yml b/.github/workflows/browser-tests.js.yml index fec4fc1e..970753fe 100644 --- a/.github/workflows/browser-tests.js.yml +++ b/.github/workflows/browser-tests.js.yml @@ -42,7 +42,7 @@ jobs: - run: docker compose run --rm ui npm install working-directory: ui - - run: docker compose --profile browser-tests up -d --wait + - run: docker compose --profile browser-tests up --wait working-directory: ui - run: docker compose exec -it ui npm run test:e2e From c32613a31a6a95c880e71419a709b5ef3e4cfa10 Mon Sep 17 00:00:00 2001 From: Thomas Arrow Date: Wed, 10 Jun 2026 17:26:40 +0100 Subject: [PATCH 3/9] run profile to try and get log output --- .github/workflows/browser-tests.js.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/browser-tests.js.yml b/.github/workflows/browser-tests.js.yml index 970753fe..45d81bb5 100644 --- a/.github/workflows/browser-tests.js.yml +++ b/.github/workflows/browser-tests.js.yml @@ -42,7 +42,7 @@ jobs: - run: docker compose run --rm ui npm install working-directory: ui - - run: docker compose --profile browser-tests up --wait + - run: docker compose --profile browser-tests up working-directory: ui - run: docker compose exec -it ui npm run test:e2e From cfd991b47a1867783acfaeccefae0f4c36712eb0 Mon Sep 17 00:00:00 2001 From: Thomas Arrow Date: Wed, 10 Jun 2026 17:43:12 +0100 Subject: [PATCH 4/9] still wait; don't mess with perms --- .github/workflows/browser-tests.js.yml | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/.github/workflows/browser-tests.js.yml b/.github/workflows/browser-tests.js.yml index 45d81bb5..75cd043c 100644 --- a/.github/workflows/browser-tests.js.yml +++ b/.github/workflows/browser-tests.js.yml @@ -36,13 +36,10 @@ jobs: - run: cp .env.development.test .env working-directory: ui - - run: sudo chown -R 1000:1000 . - working-directory: ui - - run: docker compose run --rm ui npm install working-directory: ui - - run: docker compose --profile browser-tests up + - run: docker compose --profile browser-tests up --wait working-directory: ui - run: docker compose exec -it ui npm run test:e2e From 24d51d293331f6df26aa87798a9890e131000817 Mon Sep 17 00:00:00 2001 From: Thomas Arrow Date: Wed, 10 Jun 2026 17:47:35 +0100 Subject: [PATCH 5/9] perms are clearly needed --- .github/workflows/browser-tests.js.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/browser-tests.js.yml b/.github/workflows/browser-tests.js.yml index 75cd043c..970753fe 100644 --- a/.github/workflows/browser-tests.js.yml +++ b/.github/workflows/browser-tests.js.yml @@ -36,6 +36,9 @@ jobs: - run: cp .env.development.test .env working-directory: ui + - run: sudo chown -R 1000:1000 . + working-directory: ui + - run: docker compose run --rm ui npm install working-directory: ui From 68cebc86dd03df681fa13bd5d719c6fe76cf56c3 Mon Sep 17 00:00:00 2001 From: Thomas Arrow Date: Wed, 10 Jun 2026 17:48:29 +0100 Subject: [PATCH 6/9] also build; hope the logs are nicer --- .github/workflows/browser-tests.js.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/browser-tests.js.yml b/.github/workflows/browser-tests.js.yml index 970753fe..3e14962f 100644 --- a/.github/workflows/browser-tests.js.yml +++ b/.github/workflows/browser-tests.js.yml @@ -42,6 +42,9 @@ jobs: - run: docker compose run --rm ui npm install working-directory: ui + - run: docker compose run --rm ui npm run build + working-directory: ui + - run: docker compose --profile browser-tests up --wait working-directory: ui From 17e9aa8bb6a360fd4c5f3dfff60266659ffc3bef Mon Sep 17 00:00:00 2001 From: Thomas Arrow Date: Wed, 10 Jun 2026 17:54:34 +0100 Subject: [PATCH 7/9] use npm ci --- .github/workflows/browser-tests.js.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/browser-tests.js.yml b/.github/workflows/browser-tests.js.yml index 3e14962f..1370017e 100644 --- a/.github/workflows/browser-tests.js.yml +++ b/.github/workflows/browser-tests.js.yml @@ -39,7 +39,7 @@ jobs: - run: sudo chown -R 1000:1000 . working-directory: ui - - run: docker compose run --rm ui npm install + - run: docker compose run --rm ui npm ci working-directory: ui - run: docker compose run --rm ui npm run build From 94508840891fb68d5c8fc1a67838dc041b93b0ea Mon Sep 17 00:00:00 2001 From: Thomas Arrow Date: Wed, 10 Jun 2026 18:01:52 +0100 Subject: [PATCH 8/9] set dev env just for ci --- .github/workflows/browser-tests.js.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/browser-tests.js.yml b/.github/workflows/browser-tests.js.yml index 1370017e..ccdf3c41 100644 --- a/.github/workflows/browser-tests.js.yml +++ b/.github/workflows/browser-tests.js.yml @@ -39,7 +39,7 @@ jobs: - run: sudo chown -R 1000:1000 . working-directory: ui - - run: docker compose run --rm ui npm ci + - run: docker compose run --rm --env NODE_ENV=development ui npm ci working-directory: ui - run: docker compose run --rm ui npm run build From 48d18048e156f41966c3c62486e6917ccbbf745d Mon Sep 17 00:00:00 2001 From: Thomas Arrow Date: Wed, 10 Jun 2026 18:06:13 +0100 Subject: [PATCH 9/9] ci not install and no build; I saw it start working --- .github/workflows/browser-tests.js.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.github/workflows/browser-tests.js.yml b/.github/workflows/browser-tests.js.yml index ccdf3c41..1202d3b2 100644 --- a/.github/workflows/browser-tests.js.yml +++ b/.github/workflows/browser-tests.js.yml @@ -42,9 +42,6 @@ jobs: - run: docker compose run --rm --env NODE_ENV=development ui npm ci working-directory: ui - - run: docker compose run --rm ui npm run build - working-directory: ui - - run: docker compose --profile browser-tests up --wait working-directory: ui