lua

[1Holy-Z]

ADDON VERSION: latest

Describe the bug
not sure

3x HandyNotes_Midnight/core/rewards.lua:818: attempt to concatenate field 'itemLink' (a nil value)
[HandyNotes_Midnight/core/rewards.lua]:818: in function 'GetText'
[HandyNotes_Midnight/core/rewards.lua]:64: in function 'Render'
[HandyNotes_Midnight/core/nodes.lua]:429: in function 'RenderRewards'
[HandyNotes_Midnight/core/nodes.lua]:400: in function 'Render'
[HandyNotes_Midnight/core/core.lua]:141: in function <HandyNotes_Midnight/core/core.lua:140>

Locals:
self=

{
id=15746
itemIcon=7252953
__address="000001904757B720"
__class=
}
(*temporary)="|T7252953:0:0:1:-1|t "
(*temporary)=nil
(*temporary)=" (Housing Decor)"
(*temporary)="Housing Decor"
(*temporary)=")"
(*temporary)="attempt to concatenate field 'itemLink' (a nil value)"
Item={
setters=
__parent=
getters=
}

[adavak]

This is a bug in the Decor reward path — the code doesn't guard against C_HousingDecor.GetDecorName returning nil.

C_HousingDecor.GetDecorName is documented as MayReturnNothing, and it returns nil when the housing decor data hasn't been loaded on the client yet (it's lazy-loaded). Decor:Initialize stores that nil into self.itemLink, then Decor:GetText crashes concatenating it at rewards.lua:818:

return Icon(self.itemIcon) .. self.itemLink .. ' (' .. self.type .. ')'

Suggested fix — mirror how Item handles missing data by falling back to L['retrieving']:

-- rewards.lua, Decor:Initialize
self.itemLink = C_HousingDecor.GetDecorName(self.id) or L['retrieving']

One caveat: reward objects are only initialized once at addon load, so a placeholder only resolves on /reload. If there's a reliable event for when the lazy housing data arrives (does HOUSING_CATALOG_UPDATED cover it?), Decor could refresh asynchronously the same way Item:CacheItem does.