feat: into_package() for ProtocolLib and StandardLib + CI Artifact#2859
Open
lima-limon-inc wants to merge 1 commit into0xMiden:nextfrom
Open
feat: into_package() for ProtocolLib and StandardLib + CI Artifact#2859lima-limon-inc wants to merge 1 commit into0xMiden:nextfrom
into_package() for ProtocolLib and StandardLib + CI Artifact#2859lima-limon-inc wants to merge 1 commit into0xMiden:nextfrom
Conversation
lima-limon-inc
force-pushed
the
fabrizioorsi/libs-as-masps
branch
from
885c68c to
a9148d7
Compare
lima-limon-inc
force-pushed
the
fabrizioorsi/libs-as-masps
branch
from
a9148d7 to
86f8f70
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes 0xMiden/midenup#200
This PR is part of an ongoing effort to migrate serialization towards the
.maspPackageformat exclusively (see 0xMiden/midenup#191 (comment)).A new
into_package()method for bothProtocolLibandStandardLibwas added which directly returns the correspondingPackage.This new method is then used in
generate_package.rsscript, which publishs themaspartifact onto the Github release page.Notes:
into_package()was also added forStandardLibfor consistency's sake, it wasn't strictly necessary.