Skip to content

Fix deployment scripts#68

Open
daveroga wants to merge 11 commits intov3from
PID-3778-update-deployment-scripts
Open

Fix deployment scripts#68
daveroga wants to merge 11 commits intov3from
PID-3778-update-deployment-scripts

Conversation

@daveroga
Copy link
Copy Markdown
Contributor

@daveroga daveroga commented Apr 18, 2026

  • Fix deployment scripts
  • Fix README with unified addresses
  • Remove unnecessary scripts

@daveroga daveroga marked this pull request as ready for review April 20, 2026 10:16
@daveroga daveroga requested a review from Copilot April 20, 2026 10:16
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates deployment/testing utilities and project configuration to support newer Polygon ID / iden3 packages and “unified address” deployments across networks.

Changes:

  • Refactors request packing / request-id generation flows to use @0xpolygonid/js-sdk helpers and ethers ABI encoding.
  • Updates Hardhat network + env configuration and bumps key iden3/Polygon ID dependency versions.
  • Refreshes scripts/README to use unified contract addresses and newer request-setting patterns (setRequests).

Reviewed changes

Copilot reviewed 19 out of 20 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
test/utils/utils.ts Removes local query-hash / verifier-id helpers; adds getChainId() using Hardhat provider.
test/utils/pack-utils.ts Replaces web3 ABI encoding with ethers AbiCoder for packing validator params/proofs.
scripts/upgradeV3Validator.ts Updates example validator address and removes unused imports.
scripts/upgradeSigValidator.ts Updates example validator address and removes unused imports.
scripts/upgradeMTPValidator.ts Updates example validator address and removes unused imports.
scripts/setRequests-v3validator.ts Moves to unified addresses + setRequests, uses SDK helpers for request id/hash.
scripts/setRequests-v2validator.ts Moves to unified addresses + setRequests, uses SDK helpers for request id/hash.
scripts/deployV3Validator.ts Updates wrapper name and deployProxy initializer args/output.
scripts/deploySigV2Validator.ts Updates wrapper name and deployProxy initializer args/output.
scripts/deployMTPV2Validator.ts Updates wrapper name and deployProxy initializer args/output.
scripts/deployIdentityExample.ts Updates default state address to unified address.
scripts/deployERC20SelectiveDisclosure.ts Adds verifier lib deployment/linking and setRequests flow with computed requestId.
scripts/deployERC20LinkedUniversalVerifier.ts Fixes constructor args passed to deployContract.
scripts/deployERC20.ts Reworks deploy + request creation to support multiple circuit ids and setRequests.
scripts/deployBalanceCredentialIssuer.ts Updates default state address to unified address.
package.json Bumps iden3/PolygonID deps; removes Mumbai scripts.
hardhat.config.ts Renames/adds networks, updates Etherscan config, disables contract sizer on compile.
README.md Replaces per-network address tables with unified-address docs and notes.
.env.sample Switches to a single PRIVATE_KEY plus per-network RPC URLs and Etherscan key.
Comments suppressed due to low confidence (3)

README.md:22

  • Spelling: “which where deployed” should be “which were deployed”.
    README.md:16
  • Markdown formatting: **Universal Verifier V2**** has an extra ** which breaks the bolding and table alignment. Remove the extra asterisks so the label renders correctly.
    README.md:26
  • Grammar: “There are a few libraries, which does not tend to evolve much …” is ungrammatical; it should be “which do not tend …” (or rephrase the sentence).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread hardhat.config.ts
Comment thread hardhat.config.ts
Comment thread test/utils/pack-utils.ts Outdated
Comment thread scripts/setRequests-v2validator.ts Outdated
Comment thread hardhat.config.ts
Comment thread test/utils/pack-utils.ts Outdated
Comment thread scripts/setRequests-v2validator.ts Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread Readme.md
Comment thread Readme.md
Comment thread scripts/deployERC20.ts Outdated
@daveroga daveroga requested a review from OBrezhniev April 24, 2026 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants