Replace ModelOverride "undoVanillaShading" with "shadingMode" - #1164
Draft
RuffledPlume wants to merge 1 commit into
Draft
Replace ModelOverride "undoVanillaShading" with "shadingMode"#1164RuffledPlume wants to merge 1 commit into
RuffledPlume wants to merge 1 commit into
Conversation
* Converted existing `undoVanillaShading` -> `shadingMode * Unlit Colors Flag enabled at all times * SceneUploader now checks the `FaceOverride::ShadingMode` * Original Vertex Colours are used due to existing ModelOverrides not being configured for Unlit Vertex Colour Values in Colour Expressions
Contributor
|
Should there be a difference between "UNLIT" and "NONE"? Also should i look for performance regressions? |
Contributor
Author
Typically means that there is no shading on the model, meaning |
Contributor
Ignore the few shaded tiles as this was for examples.
UNLIT appears to be perfect assuming it doesn't goof up color overrides. 
To me NONE always seems identical to UNLIT for what its worth.
I will say when using UNLIT it highlights how over bright everything is... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
undoVanillaShading-> `shadingModeFaceOverride::ShadingModeModelOverride.Shading.Mode.mp4