[CLOSE] fix: Fix the . dot in the regex not matching \n#5158
[CLOSE] fix: Fix the . dot in the regex not matching \n#5158wangliang181230 wants to merge 10 commits into1Panel-dev:v2from
. dot in the regex not matching \n#5158Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| file = QuerySet(File).filter(id=r).first() | ||
| if file is None: | ||
| break | ||
| continue |
There was a problem hiding this comment.
顺便修复：所有图片处理完
| text = re.sub(r'\s+', ' ', text) | ||
| # 去除表单渲染 | ||
| re.sub(r'<form_rander>[\s\S]*?<\/form_rander>', '', text) | ||
| text = re.sub(r'<form_rander>[\d\D]*?</form_rander>', '', text) |
There was a problem hiding this comment.
遗漏了 text =
| if model is None: | ||
| raise AppApiException(500, _('Model does not exist')) | ||
| if model is None: | ||
| raise AppApiException(500, _('Model does not exist')) |
There was a problem hiding this comment.
顺便优化：if with_valid 未进入时，model 也为 None，也要抛出该异常，所以移到 if with_valid 之外。
| return simple_trigger_handler.undeploy(trigger, **kwargs) | ||
| if simple_trigger_handler.support(trigger, **kwargs): | ||
| return simple_trigger_handler.undeploy(trigger, **kwargs) | ||
| raise Exception("不支持的触发器类型") |
There was a problem hiding this comment.
顺便优化：遗漏了判断。
|
感谢你的代码贡献。 经过初步检查，这个 PR 里包含了多个独立的功能点。按照我们的协作规范，建议将一个功能对应一个 PR，这样有助于： 每个 PR 聚焦单一职责 Code Review 更容易 部分功能可以先合并上线 可以请你把这个 PR 拆成几个独立的 PR 吗？每个 PR 只改动一个功能。完成后我们立即开始 Review。 感谢理解！ |
|
好的。 |
wangliang181230
changed the title
. dot in the regex not matching \n. dot in the regex not matching \n
|
@shaohuzhang1 see the new PR #5179 |
wangliang181230
changed the title
. dot in the regex not matching \n. dot in the regex not matching \n
2 participants
What this PR does / why we need it?
fix: Fix the
.dot in the regex not matching\nSummary of your change
修复正则表达式中的点未匹配换行符的问题
Please indicate you've done the following: