fix: release flickering - #16
Open
3L0C wants to merge 3 commits into
Open
Conversation
a70dc46 causes `+keep` keys to switch focus between windows and the wk menu. When repeatedly pressing `+keep` keys, this causes noticeable flicker in the menu. This patch fixes that, but breaks existing workflows where a `+keep` commannd needed wk to not be in focus to work correctly. The old behavior can be reinstated with `:release` or `+release` on global or per-chord basis, respectively.
3L0C
force-pushed
the
fix/release-flicker
branch
from
July 24, 2026 00:17
8b6b959 to
bd58ae6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes keyboard release flickering introduced in a70dc46.
When repeatedly pressing
+keepkeys, the menu will noticeably flicker. This is because a70dc46 made the default behavior to release the keyboard after any keypress, causing focus to switch between wk and the last focused window. This patch fixes the resulting flicker, but breaks existing workflows where a+keepcommand required wk to not be in focus to work correctly. The old behavior can be reinstated with:releaseor+releaseon global or per-chord basis, respectively.