feat(#635): Support isExpanded on KtDrawer - #641
Open
carsoli wants to merge 3 commits into
Open
Conversation
|
Your Render PR Server URL is https://kotti-pr-641.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-caq83hvs437gvhlcqe6g. |
carsoli
force-pushed
the
635-support-is-expanded-on-kt-drawer
branch
from
June 23, 2022 15:09
09cb5de to
b20fff7
Compare
FlorianWendelborn
force-pushed
the
635-support-is-expanded-on-kt-drawer
branch
6 times, most recently
from
June 24, 2022 12:29
88765af to
015da93
Compare
santiagoballadares
previously approved these changes
Jun 27, 2022
FlorianWendelborn
force-pushed
the
635-support-is-expanded-on-kt-drawer
branch
from
June 27, 2022 14:03
015da93 to
cf976e5
Compare
carsoli
force-pushed
the
635-support-is-expanded-on-kt-drawer
branch
from
June 27, 2022 14:03
cf976e5 to
015da93
Compare
FlorianWendelborn
force-pushed
the
635-support-is-expanded-on-kt-drawer
branch
3 times, most recently
from
June 28, 2022 17:06
cb1c39d to
b9ad6d9
Compare
FlorianWendelborn
requested changes
Jun 28, 2022
| // Utility classes | ||
| @import 'utilities'; | ||
| @import 'media'; | ||
| @import 'mixins'; |
Collaborator
There was a problem hiding this comment.
Not 100% sure, but this looks like a no-op.
Contributor
Author
There was a problem hiding this comment.
i moved it under kotti-style, so
Contributor
Author
There was a problem hiding this comment.
@FlorianWendelborn can this be resolved?
Collaborator
There was a problem hiding this comment.
Still seems like a noop
Contributor
Author
There was a problem hiding this comment.
can you either elaborate on why you think it is or test it?
isExpanded on KtDrawerisExpanded on KtDrawer
carsoli
force-pushed
the
635-support-is-expanded-on-kt-drawer
branch
from
July 25, 2022 11:28
b9ad6d9 to
3dcd403
Compare
santiagoballadares
previously approved these changes
Jul 25, 2022
FlorianWendelborn
force-pushed
the
635-support-is-expanded-on-kt-drawer
branch
2 times, most recently
from
October 14, 2022 13:36
1c48fdc to
3a898f6
Compare
FlorianWendelborn
force-pushed
the
635-support-is-expanded-on-kt-drawer
branch
5 times, most recently
from
November 29, 2022 11:28
1178f95 to
bc552ab
Compare
FlorianWendelborn
force-pushed
the
635-support-is-expanded-on-kt-drawer
branch
5 times, most recently
from
December 9, 2022 14:27
41bfafa to
18c0352
Compare
FlorianWendelborn
force-pushed
the
635-support-is-expanded-on-kt-drawer
branch
3 times, most recently
from
December 14, 2022 11:05
86d32b9 to
8a79034
Compare
FlorianWendelborn
force-pushed
the
635-support-is-expanded-on-kt-drawer
branch
from
December 19, 2022 15:09
8a79034 to
2285841
Compare
FlorianWendelborn
force-pushed
the
635-support-is-expanded-on-kt-drawer
branch
2 times, most recently
from
December 30, 2022 01:18
c075a6c to
ca86592
Compare
isExpanded on KtDrawerisExpanded on KtDrawer
used by more than just the kotti-fields now
use variables for transitions
carsoli
force-pushed
the
635-support-is-expanded-on-kt-drawer
branch
from
February 1, 2023 10:53
ca86592 to
7adaca5
Compare
Isokaeder
force-pushed
the
master
branch
4 times, most recently
from
May 14, 2024 14:01
c23cd01 to
ecc7eba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.