Skip to content

fix(common): handle dynamic scroll ancestors and cell CSS overlays - #1279

Merged
6pac merged 1 commit into
masterfrom
chore/todo-part1
Aug 17, 2026
Merged

fix(common): handle dynamic scroll ancestors and cell CSS overlays#1279
6pac merged 1 commit into
masterfrom
chore/todo-part1

Conversation

@ghiscoding

@ghiscoding ghiscoding commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

replicate Slickgrid-Universal PR 2735 into SlickGrid. You can see the included ChatGPT summary below.

asked Codex to review very old TODOs left in SlickGrid file by the original author and fixed using ChatGPT Terra 5.6 model

Summary

  • Replace static ancestor scroll bindings with a capture-phase listener that continues working when the grid is reparented.
  • Merge keyed cell CSS overlays when styles are added, updated, or removed, avoiding repeated lookups during cell rendering.
  • Add unit tests covering both behaviors.

Validation

  • SlickGrid core and RTL tests: 443 passed
  • TypeScript check with tsc --noEmit
  • Prettier and Oxlint checks passed

column-rendering loop TODOs remain deferred for separate work.

@6pac
6pac merged commit 4dade5c into master Aug 17, 2026
5 checks passed
@6pac
6pac deleted the chore/todo-part1 branch August 17, 2026 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants