Fix server VME in radio auto-tune when a character despawns mid-retune#88
Open
Smiggus wants to merge 1 commit into
Open
Fix server VME in radio auto-tune when a character despawns mid-retune#88Smiggus wants to merge 1 commit into
Smiggus wants to merge 1 commit into
Conversation
The component schedules DeferredHook and up to 20 WaitForFactionThenRetune retries (200 ms apart) on the call queue. If the owning character is deleted inside that window (player disconnect, GM cleanup), the queued calls still fire and dereference m_Owner (FindComponent/GetChildren) on a destroyed entity, producing a NULL pointer VME on the server. - Cancel both queued callbacks in OnDelete - Null-guard m_Owner in WaitForFactionThenRetune, LocateInvMgr, FindGroupSettings and FindAffiliationComp
Smiggus
force-pushed
the
fix/radio-autotune-callqueue-safety
branch
from
3aa84a6 to
2ccba4c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CAV_RadioAutoTuneComponentschedulesDeferredHook(+50 ms) and up to 20WaitForFactionThenRetuneretries at 200 ms intervals, a window of roughly 4 seconds after spawn. If the owning character is deleted inside that window (player disconnects during spawn, GM deletes the unit, respawn race), the queued callbacks still fire and callFindComponent/GetChildrenon the destroyed entity, producing a NULL pointer VME on the dedicated server. This lines up with intermittent radio-related errors on our servers.Changes:
OnDeletem_OwnerinWaitForFactionThenRetune,LocateInvMgr,FindGroupSettings,FindAffiliationCompNo change to tuning behavior on the normal path.