fix: Python 3.8 compatibility#63
Merged
Merged
Conversation
Copilot created this pull request from a session on behalf of
alaurenzi
June 3, 2026 10:09
View session
Contributor
|
@copilot Add python 3.8 to the test matrix (gh workflow) |
Contributor
Author
Done — added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two type annotation constructs introduced after Python 3.8 were used at module/function scope, causing
TypeErrorat import time on Python 3.8.Changes
sys_deps.py: Addfrom __future__ import annotations(PEP 563) — defers annotation evaluation sostr | None(PEP 604, 3.10+) andlist[str](PEP 585, 3.9+) are never evaluated as expressions at runtimeparser.py: Use raw strings for regex patterns to eliminate invalid escape sequences (\[,\s) that produceSyntaxWarning.github/workflows/python-tests.yml: Add Python 3.8 to the CI test matrix to explicitly verify compatibility going forward