Add recipe editing to the web client#127
Open
jschoedl wants to merge 4 commits into
Open
Conversation
Verify py-recipe-service and py-help-service responses conform to the internal OpenAPI contract, run in-process over ASGI with the LLM stubbed. Both service CI workflows now also trigger on api/openapi-internal.yaml. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Consumer-driven Pact over the public REST boundary: the web-client consumer test generates web-client/pacts/, which the spring-api provider test verifies against the real app (JWT auth real, Python GenAI clients mocked). Covers every route the client uses, happy and error paths. The committed pact is the filesystem handoff; spring-api CI triggers on it. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Editable pages for both generated (unsaved) and library recipes, backed by
PUT /recipes/{id} pact and Spring API contract coverage.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This comment was marked as low quality.
This comment was marked as low quality.
|
🚀 Frontend preview ↗ · commit |
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an edit page for recipes, reachable from the recipe view for both generated (unsaved) recipes and saved library recipes. Editing a library recipe saves via
PUT /recipes/{id}; editing a generated recipe asks whether to also store it in the library. Unsaved edits are guarded by a discard prompt on navigation and on tab close.Also extracts the auto-growing
AutoTextareashared by the editor and the existing "get help" input, and adds pact + Spring API contract coverage forPUT /recipes/{id}.Type of change
API changes
api/openapi.yamlupdated andapi/scripts/gen-all.shre-runDefinition of Done
🤖 Generated with Claude Code