D5-GOV contingent: declare brokeEmaWithBody stub + conviction alias (zero-movement) - #29
Merged
Merged
Conversation
… (zero-movement) Make the live silent defaults explicit without changing any emitted score: named BROKE_EMA_WITH_BODY_UNIMPLEMENTED_STUB=false, and document conviction as a declared uwrScore alias. Contingent on owner acceptance of D5-GOV; does not implement a candle producer or distinct conviction metric. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
Kilo Code Review could not run — your account is out of credits. Add credits or switch to a free model to enable reviews on this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BROKE_EMA_WITH_BODY_UNIMPLEMENTED_STUB = falseand uses it as the adapter fallback forbrokeEmaWithBody(explicit unimplemented-input law, not a silent default).convictionas a declared alias ofuwrScorefor froggytrend_pullback_v1(template JSDoc + scorer comment).afi-governancefiling, Status Proposed). Implementation is not an argument for this option.Merge order
ref:)Test plan
npm test— 12 files / 233 tests (was 231; +2 assertions)npm run build:cleanMade with Cursor