D5-GOV contingent: pin brokeEmaWithBody to declared stub (zero-movement) - #79
Conversation
…b (zero-movement) Import BROKE_EMA_WITH_BODY_UNIMPLEMENTED_STUB from afi-core and pin viewTechnical to that constant instead of a bare false literal. Ambient typings updated so tsc sees the export. No golden/score change. Merge after afi-core PR (CI checks out afi-core default branch with no ref). Co-authored-by: Cursor <cursoragent@cursor.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
Kilo Code Review could not run — your account is out of credits. Add credits or switch to a free model to enable reviews on this change. |
D8 (PR #77) deleted the ambient afi-core shims, including the froggy.enrichment_adapter block this branch had patched to declare BROKE_EMA_WITH_BODY_UNIMPLEMENTED_STUB. Conflict resolved by taking main's typings.d.ts. The shim declaration is now unnecessary and must NOT be reinstated: the constant resolves from afi-core's real published dist/*.d.ts (afi-core PR #29, on main). Keeping both sides here would have silently restored the `any` boundary D8 removed.
|
Updated this branch: merged Conflict resolved deliberately. D8 deleted the ambient Worth recording why the other resolution was dangerous: keeping both sides would have reinstated the shim block and silently restored the Verified on the merged result, against afi-core@main built clean:
|
1 participant
Summary
viewTechnicalpinsbrokeEmaWithBodytoBROKE_EMA_WITH_BODY_UNIMPLEMENTED_STUBfrom afi-core (same effectivefalse, now named).typings.d.tsshim updated so tsc can see the new export (ambient modules shadow real resolution — same class of issue as D8).312da1180b0bd418c03f595093516ebdc755ba81465a0b526ace43d002126e06. All 141 golden/fixture sha256s identical before/after. 12/12 oraclescorerInput→analystScoreidentity preserved.Merge order (critical)
afi-coreat its default branch with noref:, so this PR will fail CI until the stub export is on main.Test plan
Made with Cursor