fix(parser): SQLite $name parameters (P0 Forge compat)#1
Closed
KarataevDmitry wants to merge 4 commits into
Closed
fix(parser): SQLite $name parameters (P0 Forge compat)#1KarataevDmitry wants to merge 4 commits into
KarataevDmitry wants to merge 4 commits into
Conversation
PARAM_DOLLAR_NAMED is lexed before $n numbered params; evaluator and serializer round-trip $paramName for Microsoft.Data.Sqlite compat.
ADO $id placeholders no longer become @$id in execution context.
Includes Forge-style MigrationHistory WHERE MigrationId = $id scenario.
4 tasks
Member
Author
|
Superseded by upstream PR: dmitrat#2 (cross-repo to dmitrat/WitDatabase). Fork PR was opened by mistake before upstream PR existed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PARAM_DOLLAR_NAMEDin WitSQL lexer/parser (distinct from numbered).ParameterType.DollarNamedthrough visitor, evaluator, and serializer.@/:/$prefixes in engine parameter binding (WitSqlParameterKeys) so ADO `` maps correctly.__EFMigrationsHistorypattern).Motivation
Microsoft.Data.Sqlite / EF ADO uses
WHERE col = $idplaceholders. WitSQL previously threwWitSqlParsingExceptionon ``. Agent Forge worked around this with inline literals inMigrationHistory.IsApplied.Test plan
dotnet test OutWit.slnx --configuration Release(full suite; one pre-existing flaky perf test on net10 under load)