Fix ROCm/HIP build, GraphBolt, and OnDiskDataset compatibility - #26
Open
awelling2801 wants to merge 3 commits into
Open
Fix ROCm/HIP build, GraphBolt, and OnDiskDataset compatibility#26awelling2801 wants to merge 3 commits into
awelling2801 wants to merge 3 commits into
Conversation
Updates GraphBolt and the tensor adapter to use PyTorch's CUDA-masquerading HIP APIs, fixes hipCUB 5.0 iterator compatibility, and hardens ROCm CI with dynamic test ports and isolated DataLoader test runs.
Pandas can return read-only numpy views from to_numpy(), which breaks in-place node-type offset updates during heterogeneous graph preprocessing. Co-authored-by: Cursor <cursoragent@cursor.com>
Introduce docker/Dockerfile.rocm, sync the legacy CI Dockerfile, apply cuco header patches during GraphBolt deps install, and restore HIP masquerading aliases so GraphBolt builds against recent PyTorch ROCm stacks. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docker/Dockerfile.rocm(and sync the legacy CI Dockerfile) for building and testing DGL on ROCm.Test plan
docker/Dockerfile.rocm(setARG_GPU_BUILD_TARGETSfor target GPU, e.g.gfx950)bash tests/scripts/task_unit_test_rocm.sh pytorch gpuin containertest_OnDiskDataset_heterogeneous[csv-*]andtest_OnDiskDataset_preprocess_graph_with_single_typepass after pandas read-only fixMade with Cursor